[bug?] workflow part design pocket and pad

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
User avatar
NormandC
Veteran
Posts: 18587
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: [bug?] workflow part design pocket and pad

Post by NormandC »

Jee-Bee wrote: Sat Oct 20, 2018 7:56 pm Who is the creator of the part design WB? Is that @ickby ??
chrisb wrote: Sat Oct 20, 2018 9:14 pm Yes, it's ickby.
No, he isn't. He is one of many developers who have worked on the PartDesign workbench over the years. The first developer who actually created PartDesign was FreeCAD's founder jriegel. There were a few others who helped around 2011-2012, among them mrlukeparry and logari81 (who also created the first implementation of the Sketcher solver). In 2013 jrheinlaender was the one who did the initial ground work on what would be known for a 2-year period (2016-2018) as "PartDesignNext". His code sat abandoned in a separate branch until a small team made of ickby, DeepSOIC and others I forget (sorry) salvaged it by the end of 2015. ickby was the de-facto lead (and sometimes only) dev for about 2 years then he stopped working on it around September of last year. Since then, PartDesign has been orphaned again; even though some devs occasionally commit bug fixes and enhancements, none of them has officially taken charge of its long term development.

Most of what has been discussed here predates ickby's involvement. I'm pretty sure PartDesign Groove was developed by jrheinlaender. He's the one who created the wiki page back in 2012.
User avatar
NormandC
Veteran
Posts: 18587
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: [bug?] workflow part design pocket and pad

Post by NormandC »

Jee-Bee wrote: Fri Oct 19, 2018 12:21 pm Would it be a idea to add a config option for setting the normal direction for cutting part design features?
in the parameter editor: Preferences>>Mod>>PartDesign ...
That would be a very bad idea, because it will not rely on how the sketch is actually attached. So you will still have this issue.

As previously replied by chrisb, it makes perfect sense for a pocket to extrude "downward" from the sketch plane, and for a pad to extrude "upward" from the sketch plane. With this default behaviour, you cover 80% of the use cases. The remaining 20% is catered to by the "Reversed" checkbox.

What you are asking for requires a little more "intelligence" from the tool; it would need to evaluate where the solid is in reference to the sketch normal, and switch the direction accordingly. This will make the code base more complicated. While this can be desirable for end users, the current behaviour is in no way a bug.

You mention how other software deal with it. In Solid Edge, you need to define the direction manually in the 3D view. An arrow appears in the 3D view and the direction it points to changes depending on where your mouse cursor is in the 3D view. You then click where your mouse is to define the direction.
GeneFC
Veteran
Posts: 5373
Joined: Sat Mar 19, 2016 3:36 pm
Location: Punta Gorda, FL

Re: [bug?] workflow part design pocket and pad

Post by GeneFC »

Jee-Bee wrote: Sat Oct 20, 2018 7:56 pm This is what i get on my mac
same as on windows...
Well, that is certainly curious. I took your file and made absolutely no changes except to play with "reverse" for the groove. These are the results

Reversed-TRUE.png
Reversed-TRUE.png (79.79 KiB) Viewed 928 times

Reversed-FALSE.png
Reversed-FALSE.png (80.82 KiB) Viewed 928 times

I have no idea why you find the opposite result.

OS: Windows 7
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.14993 (Git)
Build type: Release
Branch: master
Hash: 1e6818b6fbf86ad08d8fc85252dddcae8891dd54
Python version: 2.7.14
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: English/UnitedStates (en_US)


Gene
Jee-Bee
Veteran
Posts: 2566
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: [bug?] workflow part design pocket and pad

Post by Jee-Bee »

GeneFC wrote: Sun Oct 21, 2018 2:15 am except to play with "reverse" for the groove.
there are 2 reverse in the model.
Sketch have a reverse option but also the groove feature....

Can you shared the NOT reversed model?
Jee-Bee
Veteran
Posts: 2566
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: [bug?] workflow part design pocket and pad

Post by Jee-Bee »

NormandC wrote: Sat Oct 20, 2018 10:33 pm As previously replied by chrisb, it makes perfect sense for a pocket to extrude "downward" from the sketch plane, and for a pad to extrude "upward" from the sketch plane.
I guess it is NOT perfect sense otherwise it was not 3 against 1 excluding FC.
NormandC wrote: Sat Oct 20, 2018 10:33 pm You mention how other software deal with it. In Solid Edge, you need to define the direction manually in the 3D view. An arrow appears in the 3D view and the direction it points to changes depending on where your mouse cursor is in the 3D view. You then click where your mouse is to define the direction.
I had to check youtube to see what you meant... i guess solid edge don`t show the initial situation and do the reverse automaticly under the hood...
chrisb
Veteran
Posts: 53930
Joined: Tue Mar 17, 2015 9:14 am

Re: [bug?] workflow part design pocket and pad

Post by chrisb »

Same result as Gene here:
reverseFalse.png
reverseFalse.png (43.93 KiB) Viewed 915 times
reverseTrue.png
reverseTrue.png (41.66 KiB) Viewed 915 times
@GeneFC: I wonder why the length is different, if you changed only the reversed attribute?

OS: macOS High Sierra (10.13)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.14976 (Git)
Build type: Release
Branch: (HEAD detached at e79a19828)
Hash: e79a19828e2e92269ff96110dfeadaa245ad17c2
Python version: 2.7.15
Qt version: 5.11.2
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: German/Germany (de_DE)
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Jee-Bee
Veteran
Posts: 2566
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: [bug?] workflow part design pocket and pad

Post by Jee-Bee »

What FC verion do you use
chrisb
Veteran
Posts: 53930
Joined: Tue Mar 17, 2015 9:14 am

Re: [bug?] workflow part design pocket and pad

Post by chrisb »

Jee-Bee wrote: Sun Oct 21, 2018 8:54 am What FC verion do you use
Oops, I forgot. I added it to the post above.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
chrisb
Veteran
Posts: 53930
Joined: Tue Mar 17, 2015 9:14 am

Re: [bug?] workflow part design pocket and pad

Post by chrisb »

Behaviour on Ubuntu is the same as on the Mac (one state is enough):
reverseFalseUbuntu.png
reverseFalseUbuntu.png (33.55 KiB) Viewed 906 times
Have you tried resetting or renaming your config files? This is the only thing I can think of if identical versions behave differently.

OS: Ubuntu 16.04.5 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.14995 (Git)
Build type: Release
Branch: master
Hash: 7b866816785ac1ca9787b63d4bff12873bb3a593
Python version: 2.7.12
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
chrisb
Veteran
Posts: 53930
Joined: Tue Mar 17, 2015 9:14 am

Re: [bug?] workflow part design pocket and pad

Post by chrisb »

Same behaviour in 0.17.

OS: Mac OS X
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.13541 (Git)
Build type: Release
Branch: releases/FreeCAD-0-17
Hash: 9948ee4f1570df9216862a79705afb367b2c6ffb
Python version: 2.7.14
Qt version: 5.10.1
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: German/Germany (de_DE)
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Post Reply