Automate Reinforcement GSoC proposal

[bernd]

This FEM code style is a bit outdated. I really need to update this. Mainly I gone do the following

FEM:
- pep8 whenever possible. There are rare cases which do not work ATM.
- to check I use the following code:

Code: Select all

find src/Mod/Fem/ -name "*\.py" | grep -v InitGui.py | grep -v TestFem.py | xargs -I [] flake8 --ignore=E266,E402,E722,W503 --max-line-length=200 []
 

- in Python FEM code I only use snake_case where as the C++ exposed Pythonmethods like all C++ uses camelCase
- typos in FEM are found with:

Code: Select all

codespell -q 3 -L aci,aline,alledges,als,ang,beginn,behaviour,bloaded,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,currenty,doubleclick,dum,eiter,elemente,feld,freez,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,ot,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,vertexes,uint,unter,whitespaces -S *.ts,*.po src/Mod/Fem

Material:
- it is pep8 compliant too, there I do not need any flake8 ignores :

Code: Select all

find src/Mod/Material/ -name "*\.py" | grep -v InitGui.py | xargs -I [] flake8 --max-line-length=100 []

typos in Material are found with:

Code: Select all

codespell -q 3 -L aci,aline,alledges,als,ang,beginn,behaviour,bloaded,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,currenty,doubleclick,dum,eiter,elemente,feld,freez,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,ot,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,vertexes,uint,unter,whitespaces -S *.ts,*.po src/Mod/Material

[Kunda1]

typos in FEM are found with: codespell

Awesome, please make sure you are using the dev version of codespell with the most up to date dictionary.
https://github.com/codespell-project/co ... /#updating
You can also keep the dictionary up to date this way: https://github.com/codespell-project/co ... dictionary

[Suraj Dadral]

Hi @all

I would like to thank you all for your support and guidance. This will going to be a huge learning experience for me.
I will keep sharing my progress and goals here.

My current goal is:
- Create UI for recently created function of column reinforcement.

Regards,

[amrit3701]

Hi @all

I would like to thank you all for your support and guidance. This will going to be a huge learning experience for me.
I will keep sharing my progress and goals here.

My current goal is:
- Create UI for recently created function of column reinforcement.

Hi @Suraj,

Congratulations! I hope this will be a great summer.

I suggest to do the following tasks at main priority:

• Publish your final project proposal either on BRL-CAD or FreeCAD wiki.

• Share a link of your blog where we can see your daily progress.

We will schedule a meeting every week where we will discuss your progress and doubts.

If you have any queries feel free to ask here or on IRC (amritpal).

Thanks,

[Kunda1]

Hi @all

I would like to thank you all for your support and guidance. This will going to be a huge learning experience for me.
I will keep sharing my progress and goals here.

Congrats Suraj!
How exciting for all of us.
Thank you in advance for all you've contributed so far and for all that you will contribute.

[vocx]

FEM:
- pep8 whenever possible. There are rare cases which do not work ATM.
- to check I use the following code:

Code: Select all

find src/Mod/Fem/ -name "*\.py" | grep -v InitGui.py | grep -v TestFem.py | xargs -I [] flake8 --ignore=E266,E402,E722,W503 --max-line-length=200 []

This code is too convoluted because you are calling twice grep and then using xargs. This can be done by find alone.

Code: Select all

find /usr/share/freecad/Mod/Fem/ -name '*.py' ! -name InitGui.py ! -name TestFem.py -exec flake8 {} '+'

Use 'single quotes' to prevent expansion by the shell, Bash, in this case. The exclamation mark ! is used to negate the expression and omit those files from the search. What follows after -exec is a program to call. A file is represented by the braces {}. The final plus sign '+' indicates that all the files are put in a single line. It basically does the same as xargs.

Code: Select all

flake8 one.py two.py three.py four.py ...

You will probably see online examples that have a semicolon at the end ';'. This is slower because it calls the program each time for each file.

Code: Select all

flake8 one.py
flake8 two.py
flake8 three.py
flake8 ...

So I'd suggest this

Code: Select all

find /usr/share/freecad/Mod/Fem/ -name '*.py' ! -name InitGui.py ! -name TestFem.py -exec flake8 --ignore=E266,E402,E722,W503 --max-line-length=100 {} '+'

Damn, man. Why do you even have lines longer than 100 characters? You know you can break lines, especially comments, which seem to be a lot.

Code: Select all

        # Algorithm3D
        # known_mesh_algorithm_3D = ['Automatic', 'Delaunay', 'New Delaunay', 'Frontal', 'Frontal Delaunay', 'Frontal Hex', 'MMG3D', 'R-tree']

Code: Select all

        # Algorithm3D 
        # known_mesh_algorithm_3D = ['Automatic', 'Delaunay', 
        #                            'New Delaunay', 'Frontal', 
        #                            'Frontal Delaunay', 'Frontal Hex', 
        #                            'MMG3D', 'R-tree'] 

[Suraj Dadral]

Hi @Suraj,

Congratulations! I hope this will be a great summer.

Thanks @amrit3701

I suggest to do the following tasks at main priority:

• Publish your final project proposal either on BRL-CAD or FreeCAD wiki.

I published my project proposal on BRL-CAD and FreeCAD wiki and here are related links:
Wiki pages on BRL-CAD wiki:
User Page: https://brlcad.org/wiki/User:Suraj
Project Page: https://brlcad.org/wiki/User:Suraj/gsoc_proposal

Wiki pages on FreeCAD wiki:
User Page: https://www.freecadweb.org/wiki/User:Suraj_Dadral
Project Page: https://www.freecadweb.org/wiki/User:Su ... c_proposal

• Share a link of your blog where we can see your daily progress.

Here is the blog link, where @all can see my daily progress:
https://hacksj4u.wordpress.com/category/gsoc2019/

We will schedule a meeting every week where we will discuss your progress and doubts.

If you have any queries feel free to ask here or on IRC (amritpal).

OK, I will ask if I have any difficulties.

Thanks,

[hardeeprai]

I would like to thank you all for your support and guidance. This will going to be a huge learning experience for me.
I will keep sharing my progress and goals here.

Congrats Suraj!
How exciting for all of us.
Thank you in advance for all you've contributed so far and for all that you will contribute.

Congratulations to @Suraj and to FreeCAD community !

Let us resolve to make this ReBar addon more useful than any such product available in the market. For that we really need feedback and wish list of heavy users of such tools.

[amrit3701]

I published my project proposal on BRL-CAD and FreeCAD wiki and here are related links:
Wiki pages on BRL-CAD wiki:
User Page: https://brlcad.org/wiki/User:Suraj
Project Page: https://brlcad.org/wiki/User:Suraj/gsoc_proposal

Wiki pages on FreeCAD wiki:
User Page: https://www.freecadweb.org/wiki/User:Suraj_Dadral
Project Page: https://www.freecadweb.org/wiki/User:Su ... c_proposal

Nice job.

Here is the blog link, where @all can see my daily progress:
https://hacksj4u.wordpress.com/category/gsoc2019/

I suggest to put daily progress on FreeCAD wiki rather than on personal site.

[Joel_graff]

Let us resolve to make this ReBar addon more useful than any such product available in the market. For that we really need feedback and wish list of heavy users of such tools.

For culverts, the primary needs would be:

1. Ability to specify primary face or ring of faces along which rebar is placed (maybe offset by a depth of cover)
2. Parametric rebar