Automate Reinforcement GSoC proposal
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: Automate Reinforcement GSoC proposal
looks good to me!
Re: Automate Reinforcement GSoC proposal
Nice! Please create an MR to https://github.com/FreeCAD/FreeCAD for review.Suraj Dadral wrote: ↑Thu May 23, 2019 8:18 am While creating stirrups, if we set offset of tie to zero, then the bottom stirrup will go out of column as in below image:
<snip>
Please check if above solution is right and give your suggestions.
- hardeeprai
- Posts: 177
- Joined: Sun May 23, 2010 2:41 pm
- Location: Ludhiana, Punjab, India
- Contact:
Re: Automate Reinforcement GSoC proposal
IMO, in this case offset should be from end face of column to centre line of tie / stirrup. The checking its placement with zero offset, is just to check your logic. Practically, it never be less than 30 mm.Suraj Dadral wrote: ↑Thu May 23, 2019 8:18 amWhile creating stirrups, if we set offset of tie to zero, then the bottom stirrup will go out of column
--
H.S.Rai
H.S.Rai
- Suraj Dadral
- Posts: 307
- Joined: Fri Sep 07, 2018 5:32 pm
- Contact:
Re: Automate Reinforcement GSoC proposal
Today, I modified basic functionality of Rebar Addon to accept clear cover instead of effective cover.
And related git commit and PR is here: commit, PR
Now, user can input clear cover instead of effective cover in Rebar Dialog box.
My next task is:
Thanks,
And related git commit and PR is here: commit, PR
Now, user can input clear cover instead of effective cover in Rebar Dialog box.
My next task is:
- Modify function makeSingleTieFourRebars() according to changes done above.
- Create function to edit column reinforcement created using Column Reinforcement dialog box.
Thanks,
- Suraj Dadral
- Posts: 307
- Joined: Fri Sep 07, 2018 5:32 pm
- Contact:
Re: Automate Reinforcement GSoC proposal
Here is MR: https://github.com/FreeCAD/FreeCAD/pull/2199amrit3701 wrote: ↑Thu May 23, 2019 6:11 pm Nice! Please create an MR to https://github.com/FreeCAD/FreeCAD for review.
Please review and suggest changes.
Thanks,
Re: Automate Reinforcement GSoC proposal
Merged! Thanks!Suraj Dadral wrote: ↑Mon May 27, 2019 4:59 am Here is MR: https://github.com/FreeCAD/FreeCAD/pull/2199
Please review and suggest changes.
- Suraj Dadral
- Posts: 307
- Joined: Fri Sep 07, 2018 5:32 pm
- Contact:
Re: Automate Reinforcement GSoC proposal
Hello everyone,
I have implemented editing of column reinforcement created through UI.
Upto this point, user can create and edit SingleTieFourRebars column reinforcement through Column Reinforcement dialog box.
Related PR can be found here: PR
Please give your suggestions and changes you may like to have.
Thanks,
I have implemented editing of column reinforcement created through UI.
Upto this point, user can create and edit SingleTieFourRebars column reinforcement through Column Reinforcement dialog box.
Related PR can be found here: PR
Please give your suggestions and changes you may like to have.
Thanks,
Re: Automate Reinforcement GSoC proposal
When I click on "Column Reinforcement" toolbars, In "Report View" window show error as below.
\Reinforcement\ColumnReinforcement\SingleTie.py", line 29, in <module>
if FreeCAD.GuiUp:
name 'FreeCAD' is not defined
Re: Automate Reinforcement GSoC proposal
After I fixed "SingleTie.py" by insert "import FreeCAD".
The Dialog is shown, but when I click "Apply" button, Rebar is not insert to the column
The Dialog is shown, but when I click "Apply" button, Rebar is not insert to the column
Code: Select all
OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16687 (Git)
Build type: Release
Branch: master
Hash: ff1fb11af15a7c5f7f0ba3ef79588e128f397c2c
Python version: 3.6.6
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)
- Suraj Dadral
- Posts: 307
- Joined: Fri Sep 07, 2018 5:32 pm
- Contact: