Automate Reinforcement GSoC proposal

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
User avatar
Suraj Dadral
Posts: 99
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Postby Suraj Dadral » Wed Aug 07, 2019 5:23 pm

amrit3701 wrote:
Wed Aug 07, 2019 1:58 pm
Suraj Dadral wrote:
Sat Aug 03, 2019 4:56 pm

Please check and give your suggestions.
Looks good! :)
Thanks

I have completed storing reinforcement data into rebar groups as per commit: https://github.com/SurajDadral/FreeCAD- ... 3f1afca815

Now, I am working on creating ui to create beam reinforcement.

Previews:
Stirrups.png
Stirrups.png (66.19 KiB) Viewed 703 times
TopBottomReinforcement.png
TopBottomReinforcement.png (60.19 KiB) Viewed 703 times

When user will click on edit button, a new dialog box will be opened like rebar distribution dialog box, in which user will give input data.

Please check if it is user friendly or may suggest better way.

Thanks,
User avatar
ebrahim raeyat
Posts: 159
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: Automate Reinforcement GSoC proposal

Postby ebrahim raeyat » Sat Aug 10, 2019 6:07 pm

Thanks @Suraj Dadral.

Do you plan for additional rebar in beams? I mean rebar that not continued throughout beam.

like this one:

https://github.com/chakkreetiya/FreeCAD-Rebars
User avatar
amrit3701
Posts: 234
Joined: Mon Jun 13, 2016 5:37 pm

Re: Automate Reinforcement GSoC proposal

Postby amrit3701 » Sun Aug 11, 2019 6:02 pm

Suraj Dadral wrote:
Wed Aug 07, 2019 5:23 pm
When user will click on edit button, a new dialog box will be opened like rebar distribution dialog box, in which user will give input data.

Please check if it is user friendly or may suggest better way.
I tested your code and currently it is only working through the Python console. So, I suggest to integrated it with beam reinforcement dialog fast and write its user-documentation as the deadline of last evaluation is closer.
User avatar
Suraj Dadral
Posts: 99
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Postby Suraj Dadral » Mon Aug 12, 2019 11:42 am

ebrahim raeyat wrote:
Sat Aug 10, 2019 6:07 pm
Thanks @Suraj Dadral.

Do you plan for additional rebar in beams? I mean rebar that not continued throughout beam.
Thanks @ebrahim for letting me know. I will do it after GSoC.
User avatar
Suraj Dadral
Posts: 99
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Postby Suraj Dadral » Mon Aug 12, 2019 12:04 pm

amrit3701 wrote:
Sun Aug 11, 2019 6:02 pm

I tested your code and currently it is only working through the Python console. So, I suggest to integrated it with beam reinforcement dialog fast and write its user-documentation as the deadline of last evaluation is closer.
Yes @amrit3701, I am trying to complete implementation of beam reinforcement dialog box. I hope I will complete it by 14 August, after that we will left with 12 days (26 August deadline of GSoC) to write user-documentation.

Some previews of beam reinforcement dialog box:
NumberDiamaterOffsetEditDialog.png
NumberDiamaterOffsetEditDialog.png (54.23 KiB) Viewed 588 times
RebarTypeEditDialog.png
RebarTypeEditDialog.png (27.04 KiB) Viewed 588 times
HookOrientationEditDialog.png
HookOrientationEditDialog.png (25.39 KiB) Viewed 588 times
HookExtensionEditDialog.png
HookExtensionEditDialog.png (29.04 KiB) Viewed 588 times

Thanks,
User avatar
Suraj Dadral
Posts: 99
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Postby Suraj Dadral » Wed Aug 14, 2019 5:40 pm

Suraj Dadral wrote:
Mon Aug 12, 2019 12:04 pm

Yes @amrit3701, I am trying to complete implementation of beam reinforcement dialog box. I hope I will complete it by 14 August, after that we will left with 12 days (26 August deadline of GSoC) to write user-documentation.
Hello everyone,

I have completed creation of beam reinforcement through ui.

Example output with default values:
BeamReinforcement.png
BeamReinforcement.png (23.48 KiB) Viewed 541 times

Please test it and give your suggestions.
Now, I will start writing user documentation for beam reinforcement as suggested by @amrit3701.

Thanks,
Attachments
beam.FCStd
(81.79 KiB) Downloaded 17 times
User avatar
chakkree
Posts: 288
Joined: Tue Jun 30, 2015 12:58 am
Location: Bangkok Thailand

Re: Automate Reinforcement GSoC proposal

Postby chakkree » Thu Aug 15, 2019 4:31 am

From your dialog, I have some question.
1. How do I set the top rebars with L-shaped, "2-DB20"?
2. How do I set the bottom rebars with straight-rebar, "2-DB20"?

Beam02.png
Beam02.png (253.08 KiB) Viewed 520 times
BeamSection.png
BeamSection.png (30.76 KiB) Viewed 520 times
beam02.FCStd
(61.69 KiB) Downloaded 28 times
User avatar
Suraj Dadral
Posts: 99
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Postby Suraj Dadral » Thu Aug 15, 2019 4:46 pm

chakkree wrote:
Thu Aug 15, 2019 4:31 am
From your dialog, I have some question.
1. How do I set the top rebars with L-shaped, "2-DB20"?
Hi @chakkree,
To set as above. You can edit Number#Diameter@Offset to have only one set as below image.

NumberDiamaterOffsetEdit.png
NumberDiamaterOffsetEdit.png (23.82 KiB) Viewed 484 times

And then edit rebar type value to LShapeRebar.

RebarTypeEdit.png
RebarTypeEdit.png (58.22 KiB) Viewed 484 times

After that edit hook orientation value to front inside.

edithookorienation.png
edithookorienation.png (57.02 KiB) Viewed 484 times
chakkree wrote:
Thu Aug 15, 2019 4:31 am

2. How do I set the bottom rebars with straight-rebar, "2-DB20"?
For this, you can do same as above for bottom reinforcement, but select StraightRebar as rebar type.

Please let me know if anything is not clear.

Thanks,
User avatar
yorik
Site Admin
Posts: 11547
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Automate Reinforcement GSoC proposal

Postby yorik » Tue Aug 20, 2019 2:10 pm

Hi Suraj,

As you know we need to finish this week. I am looking at your code now, your work is basically in the "automate" branch on your github repo, is that correct? I think it would be good if you could write a wrap-up explaining how to use your work, how to install, etc. I know you are busy writing docs, so probably you are doing this already.

Great work so far anyway! Congrats!
User avatar
amrit3701
Posts: 234
Joined: Mon Jun 13, 2016 5:37 pm

Re: Automate Reinforcement GSoC proposal

Postby amrit3701 » Tue Aug 20, 2019 4:35 pm

yorik wrote:
Tue Aug 20, 2019 2:10 pm
As you know we need to finish this week. I am looking at your code now, your work is basically in the "automate" branch on your github repo, is that correct? I think it would be good if you could write a wrap-up explaining how to use your work, how to install, etc. I know you are busy writing docs, so probably you are doing this already.
Hi Yorik and Suraj,

The stable code of Suraj work is present in `gsoc19` branch (https://github.com/amrit3701/FreeCAD-Re ... ree/gsoc19). Right now, code related to beam reinforcement is not merged yet. Anyway, I am planning when beam reinforcement will complete then I merge `gsoc19` branch into `master` branch. Then everyone can install Suraj code from the addon manager.

@Suraj,

I am trying to create reinforcement in beam by using your beam reinforcement dialog (`suraj/gsoc19-two-legged-stirrup` branch). It only creates stirrups rebars, no longitudinal rebars. Also, it throws below error in the `Report view`:

Code: Select all

Traceback (most recent call last):
  File "/Users/ambu/Library/Preferences/FreeCAD/Mod/Reinforcement/BeamReinforcement/MainBeamReinforcement.py", line 1171, in clicked
    self.accept(button)
  File "/Users/ambu/Library/Preferences/FreeCAD/Mod/Reinforcement/BeamReinforcement/MainBeamReinforcement.py", line 1233, in accept
    self.FaceName,
  File "/Users/ambu/Library/Preferences/FreeCAD/Mod/Reinforcement/BeamReinforcement/TwoLeggedBeam.py", line 240, in makeReinforcement
    structure,
  File "/Users/ambu/Library/Preferences/FreeCAD/Mod/Reinforcement/BeamReinforcement/TwoLeggedBeam.py", line 306, in makeTopReinforcement
    facename, structure
  File "/Users/ambu/Library/Preferences/FreeCAD/Mod/Reinforcement/Rebarfunc.py", line 701, in getFacenamesforBeamReinforcement
    return (facename_for_tb_rebars, facename_for_s_rebars)
UnboundLocalError: local variable 'facename_for_s_rebars' referenced before assignment
Also, there is no image of beam reinforcement present in the dialog box. Please take a look on this issue.