Automate Reinforcement GSoC proposal

Contributions from the participants, questions and answers to their projects.
Discussions of proposals for upcoming events.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
ebrahim raeyat
Posts: 621
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: Automate Reinforcement GSoC proposal

Post by ebrahim raeyat »

Bance wrote: Sun Jul 26, 2020 6:07 pm
FYI this thread is continued here:-https://forum.freecadweb.org/viewtopic. ... &start=170

Steve.
thanks, i will follow that.
User avatar
ebrahim raeyat
Posts: 621
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: Automate Reinforcement GSoC proposal

Post by ebrahim raeyat »

Suraj Dadral wrote: Sun Jul 26, 2020 7:25 pm
ebrahim raeyat wrote: Mon Jul 13, 2020 1:44 pm
Suraj Dadral wrote: Sun Jan 19, 2020 2:06 pm
I will first read your provided links and will then let you know.

Thanks,
Hi @Suraj, did you read my links about continuous beams? I am trying to implement my pyconcrete in FreeCAD. I will be appreciated to look at that
Hi @ebrahim raeyat,

I apologies for being late as I was focusing on Automated Reinforcement Drawing/Dimensioning as pointed by @Bance.

I had a look at your latest work (on 14 March).
The drawing plan dxf output produced by your code looks marvelous :D.

As we are now moving towards automated drawing/dimensioning of rebars, so we can also utilize your code to generated drawings in dxf format.
Please let me know if I may help you in any way.

Thanks,
thanks, my focus is on continuous beam, as I call it BeamType. I think in the real building there isn't one beam only and we have continuous beam as here:

https://forum.freecadweb.org/viewtopic. ... 74#p183274
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: Automate Reinforcement GSoC proposal

Post by balrobs »

Hi @Suraj, hi @amrit3701,
thought this could be the appropriate topic for reporting an issue I noticed with rebar-addon dialogs.
Here is the Link to my original post.
https://forum.freecadweb.org/viewtopic.php?f=23&t=50669
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: Automate Reinforcement GSoC proposal

Post by balrobs »

Hi @amrit3701, hi @Suraj Dadral,

while using the BeamReinforcement tool to create the Beam_TwoLeggedStirrups.svg (see post https://forum.freecadweb.org/viewtopic. ... 69#p436693)
I noticed an issue affecting the upper and lower longitudinal beam bars.
I can reproduce the issue both in my Windows and in my Ubuntu environment. Here is a screencast showing the problem:
https://drive.google.com/file/d/1BRt4UT ... sp=sharing

Cheers
User avatar
amrit3701
Posts: 343
Joined: Mon Jun 13, 2016 5:37 pm

Re: Automate Reinforcement GSoC proposal

Post by amrit3701 »

balrobs wrote: Mon Oct 05, 2020 1:27 pm Hi @amrit3701, hi @Suraj Dadral,

while using the BeamReinforcement tool to create the Beam_TwoLeggedStirrups.svg (see post https://forum.freecadweb.org/viewtopic. ... 69#p436693)
I noticed an issue affecting the upper and lower longitudinal beam bars.
I can reproduce the issue both in my Windows and in my Ubuntu environment. Here is a screencast showing the problem:
https://drive.google.com/file/d/1BRt4UT ... sp=sharing

Cheers
Hi @balrobs,

Thanks for reporting the issue. I will take a look and let you know soon. :)
Amritpal Singh
Github, Like my work, sponsor me!
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: Automate Reinforcement GSoC proposal

Post by balrobs »

amrit3701 wrote: Wed Oct 07, 2020 4:10 pm Hi @balrobs,
Thanks for reporting the issue. I will take a look and let you know soon. :)
Thanks @amrit3701 for taking your time and tracking down the issue.
BTW I noticed another thing. Rebars hosted by a structure that were generated by the comands "Reinforcement_StraightRebar", "Reinforcement_UShapeRebar", "Reinforcement_LShapeRebar" and "Reinforcement_BentShapeRebar" are moved with their hosts.
But this is not the case for rebars cretated with "Reinforcement_StirrupRebar" and "Reinforcement_HelicalRebar".
So when a column or a beam is moved all rebars do so except stirrups and helical reinforcements.
User avatar
Suraj Dadral
Posts: 307
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Post by Suraj Dadral »

balrobs wrote: Thu Oct 08, 2020 12:49 pm BTW I noticed another thing. Rebars hosted by a structure that were generated by the comands "Reinforcement_StraightRebar", "Reinforcement_UShapeRebar", "Reinforcement_LShapeRebar" and "Reinforcement_BentShapeRebar" are moved with their hosts.
But this is not the case for rebars cretated with "Reinforcement_StirrupRebar" and "Reinforcement_HelicalRebar".
So when a column or a beam is moved all rebars do so except stirrups and helical reinforcements.
Hi @balrobs

All above rebars except stirrup and helical rebars are based on sketch which can be attached to face of structure, thus moves with structure.
So, to move stirrup and helical rebars, you can double click on rebar object in side panel and click ok.
Another method to accomplish similar behaviour in case of stirrup and helical rebar, we may need to create recomputable object for each, which will consider parameters added by Reinforcement workbench and recompute object accordingly.

So, created related issue to track its status here: Create parametric object for Stirrup and Helical Rebars

Thanks,
User avatar
Suraj Dadral
Posts: 307
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Post by Suraj Dadral »

balrobs wrote: Mon Oct 05, 2020 1:27 pm while using the BeamReinforcement tool to create the Beam_TwoLeggedStirrups.svg (see post https://forum.freecadweb.org/viewtopic. ... 69#p436693)
I noticed an issue affecting the upper and lower longitudinal beam bars.
I can reproduce the issue both in my Windows and in my Ubuntu environment. Here is a screencast showing the problem:
https://drive.google.com/file/d/1BRt4UT ... sp=sharing
Hi @balrobs

This issue has been fixed as per commit: https://github.com/amrit3701/FreeCAD-Re ... b2c5bd8b0b
So, you may now update Reinforcement workbench and check if things are working fine. ;)

Thanks,
balrobs
Posts: 449
Joined: Fri Apr 24, 2020 8:58 pm

Re: Automate Reinforcement GSoC proposal

Post by balrobs »

Hi @Suraj,
thank you for the fix. I tested the BeamReinforcement tool by selecting as well the front face as the back face of the beam and your fix works fine :D
However selecting a lateral face of the beam I expected the reinforcement to be laid in trasversal direction ... it happened that way except for the rebar marked in red in the below picture.
Thanks for your efforts!
beam_reinforcement.png
beam_reinforcement.png (149.18 KiB) Viewed 3449 times
jtm2020hyo
Posts: 594
Joined: Wed Aug 12, 2020 1:24 am

Re: Automate Reinforcement GSoC proposal

Post by jtm2020hyo »

I am interested in this feature, any date for release it with the dev version?
Post Reply