yorik wrote: ↑Tue Aug 20, 2019 2:10 pm
As you know we need to finish this week. I am looking at your code now, your work is basically in the "automate" branch on your github repo, is that correct? I think it would be good if you could write a wrap-up explaining how to use your work, how to install, etc. I know you are busy writing docs, so probably you are doing this already.
Hi Yorik and Suraj,
The stable code of Suraj work is present in `gsoc19` branch (
https://github.com/amrit3701/FreeCAD-Re ... ree/gsoc19). Right now, code related to beam reinforcement is not merged yet. Anyway, I am planning when beam reinforcement will complete then I merge `gsoc19` branch into `master` branch. Then everyone can install Suraj code from the addon manager.
@Suraj,
I am trying to create reinforcement in beam by using your beam reinforcement dialog (`suraj/gsoc19-two-legged-stirrup` branch). It only creates stirrups rebars, no longitudinal rebars. Also, it throws below error in the `Report view`:
Code: Select all
Traceback (most recent call last):
File "/Users/ambu/Library/Preferences/FreeCAD/Mod/Reinforcement/BeamReinforcement/MainBeamReinforcement.py", line 1171, in clicked
self.accept(button)
File "/Users/ambu/Library/Preferences/FreeCAD/Mod/Reinforcement/BeamReinforcement/MainBeamReinforcement.py", line 1233, in accept
self.FaceName,
File "/Users/ambu/Library/Preferences/FreeCAD/Mod/Reinforcement/BeamReinforcement/TwoLeggedBeam.py", line 240, in makeReinforcement
structure,
File "/Users/ambu/Library/Preferences/FreeCAD/Mod/Reinforcement/BeamReinforcement/TwoLeggedBeam.py", line 306, in makeTopReinforcement
facename, structure
File "/Users/ambu/Library/Preferences/FreeCAD/Mod/Reinforcement/Rebarfunc.py", line 701, in getFacenamesforBeamReinforcement
return (facename_for_tb_rebars, facename_for_s_rebars)
UnboundLocalError: local variable 'facename_for_s_rebars' referenced before assignment
Also, there is no image of beam reinforcement present in the dialog box. Please take a look on this issue.