Automate Reinforcement GSoC proposal

[yorik]

looks good to me!

[amrit3701]

While creating stirrups, if we set offset of tie to zero, then the bottom stirrup will go out of column as in below image:

<snip>

Please check if above solution is right and give your suggestions.

Nice! Please create an MR to https://github.com/FreeCAD/FreeCAD for review.

[hardeeprai]

While creating stirrups, if we set offset of tie to zero, then the bottom stirrup will go out of column

IMO, in this case offset should be from end face of column to centre line of tie / stirrup. The checking its placement with zero offset, is just to check your logic. Practically, it never be less than 30 mm.

[Suraj Dadral]

Today, I modified basic functionality of Rebar Addon to accept clear cover instead of effective cover.
And related git commit and PR is here: commit, PR
Now, user can input clear cover instead of effective cover in Rebar Dialog box.

My next task is:

• Modify function makeSingleTieFourRebars() according to changes done above.
• Create function to edit column reinforcement created using Column Reinforcement dialog box.

Suggestions are always welcome.

Thanks,

[Suraj Dadral]

Nice! Please create an MR to https://github.com/FreeCAD/FreeCAD for review.

Here is MR: https://github.com/FreeCAD/FreeCAD/pull/2199
Please review and suggest changes.

Thanks,

[yorik]

Here is MR: https://github.com/FreeCAD/FreeCAD/pull/2199
Please review and suggest changes.

Merged! Thanks!

[Suraj Dadral]

Hello everyone,
I have implemented editing of column reinforcement created through UI.
Upto this point, user can create and edit SingleTieFourRebars column reinforcement through Column Reinforcement dialog box.

Related PR can be found here: PR

Please give your suggestions and changes you may like to have.

Thanks,

[chakkree]

When I click on "Column Reinforcement" toolbars, In "Report View" window show error as below.

\Reinforcement\ColumnReinforcement\SingleTie.py", line 29, in <module>
if FreeCAD.GuiUp:

name 'FreeCAD' is not defined

[chakkree]

After I fixed "SingleTie.py" by insert "import FreeCAD".
The Dialog is shown, but when I click "Apply" button, Rebar is not insert to the column

TestColumnDialog.png (535.9 KiB) Viewed 1485 times

Code: Select all

OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16687 (Git)
Build type: Release
Branch: master
Hash: ff1fb11af15a7c5f7f0ba3ef79588e128f397c2c
Python version: 3.6.6
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)

[Suraj Dadral]

When I click on "Column Reinforcement" toolbars, In "Report View" window show error as below.

\Reinforcement\ColumnReinforcement\SingleTie.py", line 29, in <module>
if FreeCAD.GuiUp:

name 'FreeCAD' is not defined

Hi @chakkree
Try using latest branch "automate"

Thanks,