Automate Reinforcement GSoC proposal

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
User avatar
ebrahim raeyat
Posts: 159
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: Automate Reinforcement GSoC proposal

Postby ebrahim raeyat » Sat Jun 01, 2019 9:00 pm

Suraj Dadral wrote:
Sat Jun 01, 2019 1:27 pm
Try using latest branch "automate"
I clone latest automate branch and i have 1 notation and 1 error:

1- tab order in Ui form is not in sequence.
2- when i want to draw a column and click apply i give this error:

Code: Select all

Traceback (most recent call last):
  File "/home/ebi/.FreeCAD/Mod/FreeCAD-Reinforcement/ColumnReinforcement/ColumnReinforcement.py", line 133, in clicked
    self.accept(button)
  File "/home/ebi/.FreeCAD/Mod/FreeCAD-Reinforcement/ColumnReinforcement/ColumnReinforcement.py", line 206, in accept
    self.RebarGroup = RebarGroup
<class 'UnboundLocalError'>: local variable 'RebarGroup' referenced before assignment
User avatar
ebrahim raeyat
Posts: 159
Joined: Sun Sep 09, 2018 7:00 pm
Location: Iran
Contact:

Re: Automate Reinforcement GSoC proposal

Postby ebrahim raeyat » Sat Jun 01, 2019 9:04 pm

in previous post i have been used custom configuration.
3- also i think "cover" can be equal for all side of column in real work. this way form become shorter and cleaner.
User avatar
Suraj Dadral
Posts: 99
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Postby Suraj Dadral » Sun Jun 02, 2019 3:03 am

ebrahim raeyat wrote:
Sat Jun 01, 2019 9:00 pm

I clone latest automate branch and i have 1 notation and 1 error:

1- tab order in Ui form is not in sequence.
I have set tab order in this commit.
ebrahim raeyat wrote:
Sat Jun 01, 2019 9:00 pm

2- when i want to draw a column and click apply i give this error:

Code: Select all

Traceback (most recent call last):
  File "/home/ebi/.FreeCAD/Mod/FreeCAD-Reinforcement/ColumnReinforcement/ColumnReinforcement.py", line 133, in clicked
    self.accept(button)
  File "/home/ebi/.FreeCAD/Mod/FreeCAD-Reinforcement/ColumnReinforcement/ColumnReinforcement.py", line 206, in accept
    self.RebarGroup = RebarGroup
<class 'UnboundLocalError'>: local variable 'RebarGroup' referenced before assignment
That is because "Custom Configuration" for Column Reinforcement is not implemented yet.
You can try "SingleTieFourRebars" configuration.

Thanks,
User avatar
chakkree
Posts: 288
Joined: Tue Jun 30, 2015 12:58 am
Location: Bangkok Thailand

Re: Automate Reinforcement GSoC proposal

Postby chakkree » Sun Jun 02, 2019 10:03 am

Suraj Dadral wrote:
Sat Jun 01, 2019 1:27 pm
Hi @chakkree
Try using latest branch "automate"

Thanks,
Ok, from your branch, I can run to create rebar in a column and can be re-edit

TestSingleTieFourRebar.png
TestSingleTieFourRebar.png (437.99 KiB) Viewed 439 times
User avatar
chakkree
Posts: 288
Joined: Tue Jun 30, 2015 12:58 am
Location: Bangkok Thailand

Re: Automate Reinforcement GSoC proposal

Postby chakkree » Sun Jun 02, 2019 10:09 am

The group of rebar is not a child of structure.
but Amrit's picture is inside a column.

TestSingleTieFourRebar01.png
TestSingleTieFourRebar01.png (508.68 KiB) Viewed 436 times

Code: Select all

OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16687 (Git)
Build type: Release
Branch: master
Hash: ff1fb11af15a7c5f7f0ba3ef79588e128f397c2c
Python version: 3.6.6
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)
User avatar
amrit3701
Posts: 234
Joined: Mon Jun 13, 2016 5:37 pm

Re: Automate Reinforcement GSoC proposal

Postby amrit3701 » Sun Jun 02, 2019 12:17 pm

chakkree wrote:
Sun Jun 02, 2019 10:09 am
The group of rebar is not a child of structure.
but Amrit's picture is inside a column.
Hi @chakkree,

You are right. Each structure can hold rebar objects and a group (for eg. SingeTie). But I am not sure it may effect other parts of FreeCAD or not (i.e ifc-exporter etc.) @Yorik, any comments?

@Suraj, I testing your gsoc19-ui branch and created SingleTieFourRebars. In the Ties section, top and bottom cover is not working. Fix this bug so that I can merge you PR.
User avatar
amrit3701
Posts: 234
Joined: Mon Jun 13, 2016 5:37 pm

Re: Automate Reinforcement GSoC proposal

Postby amrit3701 » Sun Jun 02, 2019 12:21 pm

ebrahim raeyat wrote:
Sat Jun 01, 2019 9:04 pm
in previous post i have been used custom configuration.
3- also i think "cover" can be equal for all side of column in real work. this way form become shorter and cleaner.
RIght now, "Custom Configuration" is not implemented yet. You may change it to "SingleTieFourRebars" for testing.
User avatar
Suraj Dadral
Posts: 99
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Postby Suraj Dadral » Sun Jun 02, 2019 6:31 pm

amrit3701 wrote:
Sun Jun 02, 2019 12:17 pm

@Suraj, I testing your gsoc19-ui branch and created SingleTieFourRebars. In the Ties section, top and bottom cover is not working. Fix this bug so that I can merge you PR.
According to current implementation, top/bottom/left/right covers are w.r.t. top view of column, which seems to work fine for me as intended.
Top view of column:
TopViewOfColumn.jpg
TopViewOfColumn.jpg (9.55 KiB) Viewed 392 times
I think according to you, top and bottom covers are w.r.t. front view of column.
Front View of column:
FrontViewOfColumn.jpg
FrontViewOfColumn.jpg (7.7 KiB) Viewed 392 times
I need to update image in UI to specify top, bottom, left and right cover.

Thanks,
User avatar
amrit3701
Posts: 234
Joined: Mon Jun 13, 2016 5:37 pm

Re: Automate Reinforcement GSoC proposal

Postby amrit3701 » Tue Jun 04, 2019 5:22 pm

Suraj Dadral wrote:
Sun Jun 02, 2019 6:31 pm
According to current implementation, top/bottom/left/right covers are w.r.t. top view of column, which seems to work fine for me as intended.
Top view of column:
TopViewOfColumn.jpg

I think according to you, top and bottom covers are w.r.t. front view of column.
Front View of column:
FrontViewOfColumn.jpg

I need to update image in UI to specify top, bottom, left and right cover.
Merged! https://github.com/amrit3701/FreeCAD-Re ... ree/gsoc19. Nice work so far. :)

Please share your next plan here.

Cheers!
User avatar
Suraj Dadral
Posts: 99
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Postby Suraj Dadral » Tue Jun 04, 2019 6:41 pm

amrit3701 wrote:
Tue Jun 04, 2019 5:22 pm

Merged! https://github.com/amrit3701/FreeCAD-Re ... ree/gsoc19. Nice work so far. :)
Thanks @amrit3701
amrit3701 wrote:
Tue Jun 04, 2019 5:22 pm

Please share your next plan here.
My next plan is to write function for "Custom Configuration" in Column Reinforcement. I am writing program for this and will share soon.
Then after that, I will implement "Custom Configuration" through dialog box.

Thanks,
cron