App::Link: the big merge

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: App::Link: the big merge

Postby abdullah » Sun Jul 21, 2019 1:34 pm

There is indeed a lot of work in here.

I am mobile, but I have been able to browse through part of the code. I have seen several things I have liked a lot, such as relying on templates for the property lists, or having a touched boolean property flag for groupextensions.

There are some modifications in App that will require some time to fully understand what is going on (and a proper screen).

I was not extremely enthusiastic to see extensive substitution of command instructions with the macro "FCMD_OBJ_CMD2". I read it like "freecad_command_object_command_two". I am by no means against reducing the typing and the footprint using a macro. It is probably that I do not get the name and thus the original command was clearer to me when reading the code despite its length. In any case, this is a non-issue probably falling within the realm of "matter of taste". Probably others will have differing opinions ;)

I will try to take a deeper look when I have a real screen.

Thanks for taking the time to prepare this PR. :)
User avatar
sgrogan
Posts: 5242
Joined: Wed Oct 22, 2014 5:02 pm

Re: App::Link: the big merge

Postby sgrogan » Wed Jul 31, 2019 9:51 pm

abdullah wrote:
Sun Jul 21, 2019 1:34 pm
Thanks for taking the time to prepare this PR. :)
+1
Would it help with testing if we provided binaries for testing on the FreeCAD release page on GitHub?
We could make a pre-release called big merge or something and post the binaries there?
Jee-Bee
Posts: 1942
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: App::Link: the big merge

Postby Jee-Bee » Thu Aug 01, 2019 7:23 am

If it isn't a to difficult task i would say yes
C_h_o_p_i_n
Posts: 45
Joined: Fri Apr 26, 2019 3:14 pm

Re: App::Link: the big merge

Postby C_h_o_p_i_n » Thu Aug 01, 2019 7:59 am

Hi,

in my humble opinion - this would help a lot to have the changes beeing tested by a broader community.

Regards,
Stefan
User avatar
kkremitzki
Posts: 1673
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: App::Link: the big merge

Postby kkremitzki » Thu Aug 01, 2019 8:06 am

I think I will create a freecad-staging PPA and provide a build there, it would be useful in general for these sorts of things where a daily PPA falls short. But the builds there should be considered temporary and infrequently in use. Additionally for ease of maintenance I was thinking of only providing an Ubuntu 18.04 package, or in general, latest Ubuntu LTS.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
wmayer
Site Admin
Posts: 14628
Joined: Thu Feb 19, 2009 10:32 am

Re: App::Link: the big merge

Postby wmayer » Thu Aug 01, 2019 8:12 am

sgrogan wrote:
Wed Jul 31, 2019 9:51 pm
abdullah wrote:
Sun Jul 21, 2019 1:34 pm
Thanks for taking the time to prepare this PR. :)
+1
Would it help with testing if we provided binaries for testing on the FreeCAD release page on GitHub?
We could make a pre-release called big merge or something and post the binaries there?
That would be good so that people may detect potential errors. I am still busy reviewing the code and it will take me a week (or more) to finish it.
chrisb
Posts: 17545
Joined: Tue Mar 17, 2015 9:14 am

Re: App::Link: the big merge

Postby chrisb » Thu Aug 01, 2019 10:22 am

I would approach this from the other side: After a big merge we keep the last version from before the merge for some time as a fallback.
0.19 is a development version and we would have the broadest test community at hand.
Jee-Bee
Posts: 1942
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: App::Link: the big merge

Postby Jee-Bee » Thu Aug 01, 2019 11:06 am

oke i think now this is +1 and the not merged version but still compiled version is +0.6
User avatar
sgrogan
Posts: 5242
Joined: Wed Oct 22, 2014 5:02 pm

Re: App::Link: the big merge

Postby sgrogan » Thu Aug 01, 2019 7:16 pm

wmayer wrote:
Thu Aug 01, 2019 8:12 am
That would be good so that people may detect potential errors. I am still busy reviewing the code and it will take me a week (or more) to finish it.
OK
realthunders branch compiles without issues, and self-tests passed without error. I used apeltauer's Libpack.
I'm building now with release pdb's, I will create a pre-release using kkremitzki suggestion of FreeCAD-staging.
chrisb wrote:
Thu Aug 01, 2019 10:22 am
I would approach this from the other side: After a big merge we keep the last version from before the merge for some time as a fallback.
Agreed here as well. When we did PDN we kept a "last stable-development build" until everything settled down. On win this is easy for me, if someone can ping me before the merge I will grab the .AppImage and .dmg releases to archive. The current build process will prune these with the merge, so we need to grab them before this happens.
User avatar
bernd
Posts: 8227
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: App::Link: the big merge

Postby bernd » Thu Aug 01, 2019 8:26 pm

sgrogan wrote:
Thu Aug 01, 2019 7:16 pm
chrisb wrote:
Thu Aug 01, 2019 10:22 am
... After a big merge we keep the last version from before the merge for some time as a fallback.
Agreed here as well. When we did PDN we kept a "last stable-development build" until everything settled down. On win this is easy for me, if someone can ping me before the merge I will grab the .AppImage and .dmg releases to archive. The current build process will prune these with the merge, so we need to grab them before this happens.
+1 from my side. In FEM I advise people to use 0.19 all the time. Since we did not have any big merge so far it runs very smooth :-)