PR submitted here
App::Link: the big merge
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
Be nice to others! Read the FreeCAD code of conduct!
-
- Veteran
- Posts: 2190
- Joined: Tue Jan 03, 2017 10:55 am
Re: App::Link: the big merge: Reverting crashes FreeCAD
Re: App::Link: the big merge
I guess Tree and Property view got disabled by default?
https://forum.freecadweb.org/viewtopic. ... 40#p331707
https://forum.freecadweb.org/viewtopic. ... 40#p331707
Re: App::Link: the big merge: Reverting crashes FreeCAD
Is there a reason why reverting a document should automatically make it active? When doing so from the GUI then it's anyway active but I doubt when running it from Python it's good idea to do it because this causes unexpected side-effects.
-
- Veteran
- Posts: 2190
- Joined: Tue Jan 03, 2017 10:55 am
Re: App::Link: the big merge: Reverting crashes FreeCAD
Previously, reverting a document signals deletion of every objects. However, for external links, object deletion and document close has different meaning. So I change it to signal document close. It's more efficient anyway. Then we need the matching new document signal. And follows the convention, I set this 'new' document to be active. I can of course check to see if this is the active document before reverting and set it back only if it is. How's that?
-
- Veteran
- Posts: 2190
- Joined: Tue Jan 03, 2017 10:55 am
Re: App::Link: the big merge: Reverting crashes FreeCAD
I have added a commit to check active document before reverting.
BTW, I will be on holiday till 15th, so may not be as responsive.
Re: App::Link: the big merge: Reverting crashes FreeCAD
Have nice holidays, and recover from all the work done here!realthunder wrote: ↑Thu Sep 05, 2019 1:50 am BTW, I will be on holiday till 15th, so may not be as responsive.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Re: App::Link: the big merge
Enjoy your free days. I think you have deserved itBTW, I will be on holiday till 15th, so may not be as responsive.
Re: App::Link: the big merge
I have seen a lot of accumulated App::Link related PRs, in-depth code reviews, people from discovering issues and reporting it, to asking what is it all about, to demanding there should be more of it. A small mention in BIM related area has been observed! Therefore i guess it's on the radar, and some possible feedback and suggestion might happen in the future in that area too. All in all thanks to all involved in making it happen and investing such amounts of effort in it. Should i guess be in optimal condition by FreeCAD 0.19 release time.
Have a nice holidays!
Have a nice holidays!
Re: App::Link: the big merge
Not technical feedback but I have always noticed a difference in color and light levels between all prior (to 0.19) versions of FreeCAD and realthunders code. I can tell you immediately if I open Assembly3 or regular FreeCAD, I don't get it. I see the same thing now when I start 0.19, it's like the overhead light is turned off and things are dim and the colors are different. Like I said, not very technical.
Re: App::Link: the big merge: Reverting crashes FreeCAD
That looks ok to me. Btw, we could add an explicit signal to clear a document (as it was said in a TODO comment in the restore() function) because when signalling to delete a document many dialog observers close themselves which might be unnecessary in some cases.realthunder wrote: ↑Wed Sep 04, 2019 11:25 pmPreviously, reverting a document signals deletion of every objects. However, for external links, object deletion and document close has different meaning. So I change it to signal document close. It's more efficient anyway. Then we need the matching new document signal. And follows the convention, I set this 'new' document to be active. I can of course check to see if this is the active document before reverting and set it back only if it is. How's that?