App::Link: the big merge
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
Be nice to others! Read the FreeCAD code of conduct!
Re: App::Link: the big merge
There is indeed a lot of work in here.
I am mobile, but I have been able to browse through part of the code. I have seen several things I have liked a lot, such as relying on templates for the property lists, or having a touched boolean property flag for groupextensions.
There are some modifications in App that will require some time to fully understand what is going on (and a proper screen).
I was not extremely enthusiastic to see extensive substitution of command instructions with the macro "FCMD_OBJ_CMD2". I read it like "freecad_command_object_command_two". I am by no means against reducing the typing and the footprint using a macro. It is probably that I do not get the name and thus the original command was clearer to me when reading the code despite its length. In any case, this is a non-issue probably falling within the realm of "matter of taste". Probably others will have differing opinions
I will try to take a deeper look when I have a real screen.
Thanks for taking the time to prepare this PR.
I am mobile, but I have been able to browse through part of the code. I have seen several things I have liked a lot, such as relying on templates for the property lists, or having a touched boolean property flag for groupextensions.
There are some modifications in App that will require some time to fully understand what is going on (and a proper screen).
I was not extremely enthusiastic to see extensive substitution of command instructions with the macro "FCMD_OBJ_CMD2". I read it like "freecad_command_object_command_two". I am by no means against reducing the typing and the footprint using a macro. It is probably that I do not get the name and thus the original command was clearer to me when reading the code despite its length. In any case, this is a non-issue probably falling within the realm of "matter of taste". Probably others will have differing opinions
I will try to take a deeper look when I have a real screen.
Thanks for taking the time to prepare this PR.
Re: App::Link: the big merge
+1
Would it help with testing if we provided binaries for testing on the FreeCAD release page on GitHub?
We could make a pre-release called big merge or something and post the binaries there?
"fight the good fight"
Re: App::Link: the big merge
If it isn't a to difficult task i would say yes
-
- Posts: 225
- Joined: Fri Apr 26, 2019 3:14 pm
Re: App::Link: the big merge
Hi,
in my humble opinion - this would help a lot to have the changes beeing tested by a broader community.
Regards,
Stefan
in my humble opinion - this would help a lot to have the changes beeing tested by a broader community.
Regards,
Stefan
- kkremitzki
- Veteran
- Posts: 2511
- Joined: Thu Mar 03, 2016 9:52 pm
- Location: Illinois
Re: App::Link: the big merge
I think I will create a freecad-staging PPA and provide a build there, it would be useful in general for these sorts of things where a daily PPA falls short. But the builds there should be considered temporary and infrequently in use. Additionally for ease of maintenance I was thinking of only providing an Ubuntu 18.04 package, or in general, latest Ubuntu LTS.
Re: App::Link: the big merge
That would be good so that people may detect potential errors. I am still busy reviewing the code and it will take me a week (or more) to finish it.
Re: App::Link: the big merge
I would approach this from the other side: After a big merge we keep the last version from before the merge for some time as a fallback.
0.19 is a development version and we would have the broadest test community at hand.
0.19 is a development version and we would have the broadest test community at hand.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Re: App::Link: the big merge
oke i think now this is +1 and the not merged version but still compiled version is +0.6
Re: App::Link: the big merge
OK
realthunders branch compiles without issues, and self-tests passed without error. I used apeltauer's Libpack.
I'm building now with release pdb's, I will create a pre-release using kkremitzki suggestion of FreeCAD-staging.
Agreed here as well. When we did PDN we kept a "last stable-development build" until everything settled down. On win this is easy for me, if someone can ping me before the merge I will grab the .AppImage and .dmg releases to archive. The current build process will prune these with the merge, so we need to grab them before this happens.
"fight the good fight"
Re: App::Link: the big merge
+1 from my side. In FEM I advise people to use 0.19 all the time. Since we did not have any big merge so far it runs very smoothsgrogan wrote: ↑Thu Aug 01, 2019 7:16 pmAgreed here as well. When we did PDN we kept a "last stable-development build" until everything settled down. On win this is easy for me, if someone can ping me before the merge I will grab the .AppImage and .dmg releases to archive. The current build process will prune these with the merge, so we need to grab them before this happens.