wmayer wrote: ↑
Tue Aug 13, 2019 6:02 pm
I think will happen by the end of this week
Many thanks for your work!
The one continuity issue, i wrote before (this is no stumbling block, only a suggestion):
When i place an array or make a group with links, then the original object raises in its origin and you do not see (at a glance) from where are the links, while working on a larger file. For parts and bodies that is not very important, because this is easy manageable. But if you work with the Part Workbenech, Draft Workbench, or other Workbeches with many small tree-unsorted elements in it, this can end in a mess.
(As you see in the *.webm , the hightlight error still exist still for me, i do not know why this is not repeatable for you).
So i have two suggestions (for later when it is merged):
I know from other CAD software, that linked objects like you make, have an extra group for linked objects (as far i remember the term is publication).
Sub objects like the screenshot and the original object vanish from the tree. And when you delete all links, the object raises in its origin. But i think that is not possible.
As i say before, this is no stumbling block. In the end every user is responsible himself to sort his work. I see that all what you have done as prework for assembly. Opinions from other users would be good, if this is a good workflow.
Also i found a very small bug:
When i link with array a linked group, i get
Code: Select all
('[Draft.todo.commit] Unexpected error:', <class 'AttributeError'>, 'in ', ['obj = Draft.makeArray(FreeCAD.ActiveDocument.LinkGroup,FreeCAD.Vector(1,0,0),FreeCAD.Vector(0,1,0),2,2,useLink=True)', 'Draft.autogroup(obj)', 'FreeCAD.ActiveDocument.recompute()'])
, but it works.
Many thanks you for your work!
tested all with:
git commit 1816b84cb1ace8d84508f4e75788a354e68a5bbc
Code: Select all
OS: Debian GNU/Linux 10 (buster) (X-Cinnamon/lightdm-xsession)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Build type: DebWithRelInfo
Python version: 3.7.3
Qt version: 5.11.3
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: C/Default (C)
on PR App::Link functionality #2350
Sorry for bad english