[Backported to 0.18] Start WB thumbnails aren't viewable in 0.18.x

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
User avatar
Kunda1
Posts: 6398
Joined: Thu Jan 05, 2017 9:03 pm

[Backported to 0.18] Start WB thumbnails aren't viewable in 0.18.x

Postby Kunda1 » Mon Sep 02, 2019 5:24 pm

kisolre wrote:
I'd like to also propose backporting a fix the StartWB thumbnails in 0.18 so that when users open their 0.18's they see the correct thumbs. What do you think ?
FC-0.18-missing-thumbs.png
FC-0.18-missing-thumbs.png (43.41 KiB) Viewed 391 times
This post was split off from https://forum.freecadweb.org/viewtopic. ... 20#p320236 in which this issue was fixed in 0.19
Image
This was merged in git commit ba6a6d63ee9c984
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
kisolre
Posts: 1428
Joined: Wed Nov 21, 2018 1:13 pm

Re: [Splved] FreeCAD AppImage (0.19.17147) Start WB thumbnails aren't viewable

Postby kisolre » Mon Sep 02, 2019 6:23 pm

Kunda1 wrote:
Mon Sep 02, 2019 5:24 pm
I'd like to also propose backporting
Well, since it is the new and latest final, people would expect that :)
triplus
Posts: 9124
Joined: Mon Dec 12, 2011 4:45 pm

Re: Start WB thumbnails aren't viewable in 0.18.x (Propose to backport)

Postby triplus » Tue Sep 03, 2019 8:35 pm

You could ask in the FreeCAD 0.18 backport thread.

P.S. In general, such feature request are usually not backported. Backporting is more about fixing mayor issues still detected in FreeCAD 0.18.
User avatar
Kunda1
Posts: 6398
Joined: Thu Jan 05, 2017 9:03 pm

Re: Start WB thumbnails aren't viewable in 0.18.x (Propose to backport)

Postby Kunda1 » Tue Sep 03, 2019 9:04 pm

triplus wrote:
Tue Sep 03, 2019 8:35 pm
You could ask in the FreeCAD 0.18 backport thread.
Thanks, forgot that step.
Done: https://forum.freecadweb.org/viewtopic. ... 18#p331618
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
chrisb
Posts: 21320
Joined: Tue Mar 17, 2015 9:14 am

Re: Start WB thumbnails aren't viewable in 0.18.x (Propose to backport)

Postby chrisb » Tue Sep 03, 2019 9:05 pm

Kunda1 wrote:
Mon Sep 02, 2019 5:24 pm
I'd like to also propose backporting a fix the StartWB thumbnails in 0.18 so that when users open their 0.18's they see the correct thumbs. What do you think ?
I'm against backporting. It's a rather cosmetic change, no crash, no destroyed models, no complicated workaround needed. Perhaps it's not even documented.
User avatar
Kunda1
Posts: 6398
Joined: Thu Jan 05, 2017 9:03 pm

Re: Start WB thumbnails aren't viewable in 0.18.x (Propose to backport)

Postby Kunda1 » Tue Sep 03, 2019 9:09 pm

chrisb wrote:
Tue Sep 03, 2019 9:05 pm
Kunda1 wrote:
Mon Sep 02, 2019 5:24 pm
I'd like to also propose backporting a fix the StartWB thumbnails in 0.18 so that when users open their 0.18's they see the correct thumbs. What do you think ?
I'm against backporting. It's a rather cosmetic change, no crash, no destroyed models, no complicated workaround needed. Perhaps it's not even documented.
A seemingly insignificant cosmetic change but for slow-poke distros like ubuntu/debian 18.x will be around for a while and people will produce videos and content and I think it makes sense from a aethetic and Public Relations point of view to tweek this. Do you get me?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
chrisb
Posts: 21320
Joined: Tue Mar 17, 2015 9:14 am

Re: Start WB thumbnails aren't viewable in 0.18.x (Propose to backport)

Postby chrisb » Tue Sep 03, 2019 10:48 pm

Kunda1 wrote:
Tue Sep 03, 2019 9:09 pm
Do you get me?
Yes; but it doesn't change my opinion. It's rather opposite: if all these different distributions need extra considerations it's extra work. And it's good PR too, if new releases have all these nice new thingies.

On the other hand: There is no need for extra long discussions. If it actually gets backported, it wouldn't hurt me at all.
User avatar
Kunda1
Posts: 6398
Joined: Thu Jan 05, 2017 9:03 pm

Re: Start WB thumbnails aren't viewable in 0.18.x (Propose to backport)

Postby Kunda1 » Wed Sep 04, 2019 3:47 am

kisolre wrote:
Do you mind sending me the 0.18.3 formatted FCStds. I can't generate them in 0.18.3 on the Arch AUR (I need to open a ticket for this, i think) or the 0.18.3 Appimage

I think the code that creates the thumbnails is broken on Arch/Manjaro for sure. Not sure about other Linux Distros.
@kisolre you're on windows, right?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
kisolre
Posts: 1428
Joined: Wed Nov 21, 2018 1:13 pm

Re: Start WB thumbnails aren't viewable in 0.18.x (Propose to backport)

Postby kisolre » Wed Sep 04, 2019 5:20 am

Kunda1 wrote:
Wed Sep 04, 2019 3:47 am
Do you mind sending me the 0.18.3 formatted FCStds.
N.p. but will try later in the day because quick experiment now makes some weird display with one of the FEM files.
I will use this version:

OS: Windows 8.1
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.16131 (Git)
Build type: Release
Branch: releases/FreeCAD-0-18
Hash: 3129ae4296e40ed20e7b3d460b86e6969acbe1c3
Python version: 3.6.6
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Bulgarian/Bulgaria (bg_BG)
kisolre
Posts: 1428
Joined: Wed Nov 21, 2018 1:13 pm

Re: Start WB thumbnails aren't viewable in 0.18.x (Propose to backport)

Postby kisolre » Wed Sep 04, 2019 9:09 am

FemCalculixCantilever3D_newSolver has some weird artifacts in the display and I could not really run the solver and display results. So just opened and resaved the file.

RobotExample gives "Sketch: This feature is deprecated and won't be longer supported in future FreeCAD versions" on full recompute so again just opened and resaved.
Attachments
FemCalculixCantilever3D.FCStd
(108.09 KiB) Downloaded 10 times
FemCalculixCantilever2D.FCStd
(84.95 KiB) Downloaded 10 times
EngineBlock.FCStd
(65.5 KiB) Downloaded 11 times
DrawingExample.FCStd
(250.67 KiB) Downloaded 8 times
ArchDetail.FCStd
(219.05 KiB) Downloaded 9 times