[Pattern Features enhancing] : circular and linear pattern must support also fillets and chamfers

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
Piero69
Posts: 70
Joined: Thu Jul 04, 2019 1:22 pm

[Pattern Features enhancing] : circular and linear pattern must support also fillets and chamfers

Postby Piero69 » Wed Feb 12, 2020 12:34 pm

I feel like a circular and linear pattern don't support the fillet and chamfer feature, this would implemented

i made a cut with filleted edges and then a circular patter with 48 instances. if the pattern don't allow to add fillets i have to fillet manually all the 48x2=96 borders :shock:
Attachments
02.jpg
02.jpg (145.11 KiB) Viewed 456 times
01.jpg
01.jpg (106.58 KiB) Viewed 456 times
Jee-Bee
Posts: 1992
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: [Pattern Features enhancing] : circular and linear pattern must support also fillets and chamfers

Postby Jee-Bee » Wed Feb 12, 2020 12:59 pm

If you just tried one search action you had seen this is requested about 100 times...
but at this moment nobody is activly maintaining PDN... So if you have to do it yourself or you should wait till somebody thinks it is importand enough to do...
chrisb
Posts: 22534
Joined: Tue Mar 17, 2015 9:14 am

Re: [Pattern Features enhancing] : circular and linear pattern must support also fillets and chamfers

Postby chrisb » Wed Feb 12, 2020 1:02 pm

The only way is to modify your design so that you can use Draft->Array on the whole body.
fcaduser
Posts: 240
Joined: Wed Feb 19, 2014 6:53 pm
Location: Near Paris, France

Re: [Pattern Features enhancing] : circular and linear pattern must support also fillets and chamfers

Postby fcaduser » Wed Feb 12, 2020 1:45 pm

@ chrisb

And generally speaking using a polar pattern is the *first* choice to consider when you have such part.
chrisb
Posts: 22534
Joined: Tue Mar 17, 2015 9:14 am

Re: [Pattern Features enhancing] : circular and linear pattern must support also fillets and chamfers

Postby chrisb » Wed Feb 12, 2020 3:17 pm

Right, I should have said: The only way to use a repitition function is to modify your design so that you can use Draft->Array on the whole body.
realthunder
Posts: 1405
Joined: Tue Jan 03, 2017 10:55 am

Re: [Pattern Features enhancing] : circular and linear pattern must support also fillets and chamfers

Postby realthunder » Thu Feb 13, 2020 3:04 am

PR submitted here

It's a quick fix. Someone please check if this works well, or introduces any problem to existing file.

The fix works like this. FeatureDressUp (parent of fillet, chamfer, draft) is changed to be derived from FeatureAddSub (parent of pad, pocket, etc). The AddSubShape is calculated by subtracting the dressed up shape with the base shape of its base feature (yes, base of the base). This solution does not have any topo naming issue.

This new feature is disabled for existing FeatureDressUp with its property 'SupportTransform' setting to False, for backward compatibility reason. You can manually turn on this property to see the difference. For newly created FeatureDressUp, it will be set to True.
Try Assembly3 (latest version 0.10.2) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
chrisb
Posts: 22534
Joined: Tue Mar 17, 2015 9:14 am

Re: [Pattern Features enhancing] : circular and linear pattern must support also fillets and chamfers

Postby chrisb » Thu Feb 13, 2020 7:58 am

Wow!
Good to see fresh development in PartDesign!
realthunder
Posts: 1405
Joined: Tue Jan 03, 2017 10:55 am

Re: [Pattern Features enhancing] : circular and linear pattern must support also fillets and chamfers

Postby realthunder » Thu Feb 13, 2020 8:15 am

chrisb wrote:
Thu Feb 13, 2020 7:58 am
Wow!
Good to see fresh development in PartDesign!
Well, I have big plans for PartDesign, adding support of multi-body, for one. Got delayed a bit, because of other stuff. And your wish for linked base for body has already been implemented. Not sure if I shall split it out or wait till the multi-body is done, at least must wait for my group change PR gets merged first.
Try Assembly3 (latest version 0.10.2) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
User avatar
Zolko
Posts: 728
Joined: Mon Dec 17, 2018 10:02 am

Re: [Pattern Features enhancing] : circular and linear pattern must support also fillets and chamfers

Postby Zolko » Thu Feb 13, 2020 8:43 am

realthunder wrote:
Thu Feb 13, 2020 8:15 am
Well, I have big plans for PartDesign
Hold-on, shouldn't this be planned in a more organized way ?

If you're taking on to dive into the PartDesign workbench — which is great news in itself — then I'd personally like to see some discussion about priorities, especially now that App::Link is merged. For me, for example, the priority would rather be to correctly handle PartDesign::DatumThings, and one of those would be to be able to extrude (pad ?) a sketch up to a datum plane: today it's not possible.

Another big question is: how are Part, Body and Assemblies supposed to interact ? If PartDesign is orphaned code, and since you have spent quite some effort in making App::Part objects App::Link compatible, shouldn't the focus rather go towards the Part workbench ? It can mostly do the same things.
try the Assembly4 workbench for FreCAD v0.19
install with Tools > Addon Manager > Assembly4 — tutorials here and here