AppImage - Include auto-updating logic in to appimage directly?

[Kunda1]

@looo This line -> https://github.com/FreeCAD/FreeCAD-AppI ... dle.sh#L74 is the culprit for the updater to fail.

The $DEPLOY_RELEASE is always empty, it should be 0.19_pre for development build and change according to type of build. This is causing to fail the AppImage delta update on any AppImage delta update tool.

Hi Antonyjr
Clarification: what do you mean by 'always empty'? Are you saying the way it's setup now that variable (is it an environmental variable?) is that it's empty but shouldn't be because something isn't configured? Or are you saying that we should hardcode the version number instead ?

[antonyjr]

@looo This line -> https://github.com/FreeCAD/FreeCAD-AppI ... dle.sh#L74 is the culprit for the updater to fail.

The $DEPLOY_RELEASE is always empty, it should be 0.19_pre for development build and change according to type of build. This is causing to fail the AppImage delta update on any AppImage delta update tool.

Hi Antonyjr
Clarification: what do you mean by 'always empty'? Are you saying the way it's setup now that variable (is it an environmental variable?) is that it's empty but shouldn't be because something isn't configured? Or are you saying that we should hardcode the version number instead ?

I mean the $DEPLOY_RELEASE environmental variable is somehow turns out to be empty. I guess there is some difficulties migrating from Travis-CI to Github Actions.

[looo]

@looo This line -> https://github.com/FreeCAD/FreeCAD-AppI ... dle.sh#L74 is the culprit for the updater to fail.

The $DEPLOY_RELEASE is always empty, it should be 0.19_pre for development build and change according to type of build. This is causing to fail the AppImage delta update on any AppImage delta update tool.

Hi Antonyjr
Clarification: what do you mean by 'always empty'? Are you saying the way it's setup now that variable (is it an environmental variable?) is that it's empty but shouldn't be because something isn't configured? Or are you saying that we should hardcode the version number instead ?

I mean the $DEPLOY_RELEASE environmental variable is somehow turns out to be empty. I guess there is some difficulties migrating from Travis-CI to Github Actions.

I guess I missed this part. Will have a look tomorrow.

https://github.com/FreeCAD/FreeCAD-AppI ... yml.tmp#L4

[looo]

@looo This line -> https://github.com/FreeCAD/FreeCAD-AppI ... dle.sh#L74 is the culprit for the updater to fail.

The $DEPLOY_RELEASE is always empty, it should be 0.19_pre for development build and change according to type of build. This is causing to fail the AppImage delta update on any AppImage delta update tool.

Hi Antonyjr
Clarification: what do you mean by 'always empty'? Are you saying the way it's setup now that variable (is it an environmental variable?) is that it's empty but shouldn't be because something isn't configured? Or are you saying that we should hardcode the version number instead ?

I mean the $DEPLOY_RELEASE environmental variable is somehow turns out to be empty. I guess there is some difficulties migrating from Travis-CI to Github Actions.

hopefully this solves the issue:
https://github.com/FreeCAD/FreeCAD-AppI ... f911604cf2

[Kunda1]

hopefully this solves the issue:
https://github.com/FreeCAD/FreeCAD-AppI ... f911604cf2

I guess we can only test the build after this next one.

[looo]

Should the 0.19-pre builds update to the 0.20-pre builds?

[hmk]

For the record, this is what I see when I try incremental updating with the latest image:

Code: Select all

/appimageupdatetool-x86_64.AppImage -O FreeCAD_0.19-24267-Linux-Conda_glibc2.12-x86_64.AppImage 
Checking for updates...
Fetching release information for tag "" from GitHub API.
GitHub API request failed!
Could not find any artifacts in release data. Please contact the author of the AppImage and tell them the files are missing on the releases page.
ZSync URL not available. See previous messages for details.
Update check failed, exiting!

[Kunda1]

Should the 0.19-pre builds update to the 0.20-pre builds?

I assume so. But there is no 0.20_pre tag yet

[looo]

Should the 0.19-pre builds update to the 0.20-pre builds?

I assume so. But there is no 0.20_pre tag yet

I guess some disconnection with the updating tool won't be avoidable. For the updating process, it would be best if we remove the version from the naming-scheme and call the bundles FreeCAD_<commit_nr>*.Appimage

[antonyjr]

For the record, this is what I see when I try incremental updating with the latest image:

Code: Select all

/appimageupdatetool-x86_64.AppImage -O FreeCAD_0.19-24267-Linux-Conda_glibc2.12-x86_64.AppImage 
Checking for updates...
Fetching release information for tag "" from GitHub API.
GitHub API request failed!
Could not find any artifacts in release data. Please contact the author of the AppImage and tell them the files are missing on the releases page.
ZSync URL not available. See previous messages for details.
Update check failed, exiting!

This was caused by the transition from Travis-CI to Github Action at FreeCAD. You can fix this with this one liner. You should have a wget,python3 and curl installed.

Open a Terminal and Go to the location of your FreeCAD application and execute the following command.

Code: Select all

 $ cd /path/to/FreeCAD-AppImage/
 $ bash <(curl -s https://git.io/JqTBd)