Thanks for looking over the proposed changes, with regard to:openBrain wrote: ↑Sun May 17, 2020 1:24 pm Just 2 remarks :
- Before creating a new setting accessible in the Preferences dialog, I think it should be thought if this is something useful for a majority of users. If this option is used only by a few ones, it can live as an hidden setting only accessible through the Parameters editor (and of course be documented in Fine-tuning)
- In the 2 'getBool()' functions, you set the default value (used if setting isn't defined) to 'true'. I'd have set it to 'false' so current behavior is preserved when upgrading.
1) I'll leave that decision up to those who actually think this is a useful feature.
2) This is bit more of a split decision, the existing code in https://github.com/FreeCAD/FreeCAD/blob ... c.cpp#L432 already sets it to True when you use File>New. I'd never even heard of this functionality until a few days ago (in nearly 3 years of using FreeCAD) and mine was set to True so in the distant past I'd used File>New and it had been set at that point. It's the point IMHO that @hammax and @FCADUSER are trying to make in that why has File>New had it set for years and the rest of the Gui not been inline with it.