paullee wrote: ping
bitacovir wrote: ping
carlopav wrote: ping
Sure! Id like to try It, May I Ask you to use GIT ti create a branch or a pull request so it's easier to review your work also for yorik?
Code: Select all
1abef0f (HEAD -> bim_super_library) carlopav I hate you
db0017f (origin/master, origin/HEAD, master) Created horizontal and vertical dimension tools
82b287b Added Leader command
etc.
ABeton wrote: ↑Tue Jun 01, 2021 10:07 am To try the changes out it is necessary to put the file attached bellow, to the place where the BIM folder is and replace the existing "BimLibrary.py" file. First do a backup of course. If this i not the propper way to share and test code please let me know, because I don't know any better at the moment
ahahahaah that made me laugh a lot!
Thanks It is not related to that, that much, but it I am trying to do a general improvement of the library.paullee wrote: ↑Wed Jun 02, 2021 6:10 pmABeton wrote: ↑Tue Jun 01, 2021 10:07 am To try the changes out it is necessary to put the file attached bellow, to the place where the BIM folder is and replace the existing "BimLibrary.py" file. First do a backup of course. If this i not the propper way to share and test code please let me know, because I don't know any better at the moment
Thanks! May have a closer look later
BTW, is this something relevant to earlier discussion [Discussion Features] Library of Coloured Textured Wall / Furnitures / Floor Finishes / Light ? I had one or two models there.
Hahahahhaa, that is the official name from now oncarlopav wrote: ↑Wed Jun 02, 2021 7:03 pmahahahaah that made me laugh a lot!
Nice that you tried! BTW i'm still using mostly GitKraken, and I find it really intuitive. I think that it is more than enough at the beginning
Anyway I did a git checkout of your branch and tried it.
Very nice work. I just love to browse the list and have the documents opened for preview!
I have never looked before at the BimLibrary code, so It's hard to me to say if it's good to merge as is or not as I do not forsee any potential problems. It would be the best if yorik could say what he thinks about that.
I just can add some random thoughts to the discussion in the hope they could be of some help to you:
- does FreeCAD documents provide a kind of preview, so you can have an idea of what is inside without opening the document? I mean something like what is used to customize the file icon. I'm saying that cause it could be quite time consuming to open some documents for preview expecially with old hardware. Eventually a checkbox to disable preview could be desirable in some cases I think.
- does the link button work? It would be super useful, but it doesn't seem to produce any result. On this it could be useful to have also an "insert as a Part::Feature" (the most simple Part object, having the library element shape condensed into), and an "insert as a PartDesign::SubShapeBinder" (another super interesting object that I suggest you to checkout). Take this last point as an unnecessary improvement.
If you want I can leave I left some inline comments on the code , but take into account that i'm not a developer by education but just a dumb architect with really few spare time, except today that it's national holidays here
Good! you should commit the changes and resolve the conversations that are already handled by you
good!- the Library macro has the preview option, with images as you say, but for some reason it works with a very small number of models. When I finish this, I will try to figure it out. Having both preview options which you can turn on and off would be the best.
yes, indeed... btw it could be worth to gather more comments from the COMMUNITY on the behavior of linking a library object (is it a link to the library object itself, could the command make a local copy in your document folder and then link it so the library stay safe, etc.).- the link does work, but it is necessary to sellect all the items you want to link. It would be good if the link worked in the same way as the "Insert" command.
Well, it's good to leave it for the moment. Anyway, since we still have to cope with a limited number of objects in the document, something that keep that number low is lot of time a desirable optionI am not sure about your second sugestion, because I think it would be better to have rules that dictate how the files which are added to the library organised. So that each file added to a library should already be put in the Part::Feature by it's creator. What do you think about this?
eheh, nice, where do you study? maybe we are not so far awayThanks for the comment, and I guess that makes us two dumb architects on this forum Yes I know, I study in Italy hahahaha, happy Republic day
I did all that I think, you can check if it is in the repository.carlopav wrote: ↑Thu Jun 03, 2021 5:53 pm Good! you should commit the changes and resolve the conversations that are already handled by you
so... git status to check your modified files since last commit, git add to add the files to the staging area, git commit to commit them to your local tree and git push to send them to your online repository (origin/bim-super-library)!
I made changes to this, what it does now is that when you press link it first asks you to save the file("Save as") I think it is best to save the file in a folder where you are doing the project and not the library, because it would bloat the library really fast. When you save in this way, it remembers in which folder you saved last time and when you try to link consecutive times, it opens the same folder every time. If you use the "Save" option than it again saves to the library folder.yes, indeed... btw it could be worth to gather more comments from the COMMUNITY on the behavior of linking a library object (is it a link to the library object itself, could the command make a local copy in your document folder and then link it so the library stay safe, etc.).
I study Industrial design in Bari, but I finished architecture before. If your location is correct I think we are on different ends of the countryeheh, nice, where do you study? maybe we are not so far away
And I think that now I have fixed my lazy quoting habitsEDIT: I forgot a small suggestion: when you quote a post, do not quote the whole post, but just the sentences you are referring to, so it's easier to follow the flow