[Features Requests] Sketcher Radius/Diameter presentation
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
Be nice to others! Read the FreeCAD code of conduct!
Re: [Features Requests] Sketcher Radius/Diameter presentation
I am happy with any solution beyond the purely horizontal line.
And I am not unhappy with the solution we have now .
And I am not unhappy with the solution we have now .
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Re: [Features Requests] Sketcher Radius/Diameter presentation
Can Make a diàmetre or radius presentation on non circular object? Kike radius on sketch that need to be revòlvef towards Axis.
Re: [Features Requests] Sketcher Radius/Diameter presentation
No.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Re: [Features Requests] Sketcher Radius/Diameter presentation
Oh that was an interesting read. I will start review of this now. Sorry OpenBrain for the huge delay. Kudo's for the community interaction
Re: [Features Requests] Sketcher Radius/Diameter presentation
I encountered a little buggy for the case of external geometry group constraining:
Which should be:
I have already a fix for that locally (no need to update the PR).
About the parameter name, I have changed them in my local commit to:
Believe it or not, it took me a while to understand "Disp" (Disponibility?).
Then I have some minor code naming things. Like changing finishDistanceConstraint to finishDatumConstraint as now it does more than distances, giving it an additional parameter to handle the case with multiple constraints (the bug above), and some extra checking to avoid unconditionally setting/assigning the label position to all constraints. While now other constraints ignore this field, this may change and would lead to unexpected behaviour.
For the rest I think that functionality and code is ok.
Hopefully tomorrow I will test my local correction commit and will merge PR and my local commit with minor fixes.
The important bit I wanted to convey is the change of the name of the parameters, as this will go to the wiki.
Which should be:
I have already a fix for that locally (no need to update the PR).
About the parameter name, I have changed them in my local commit to:
Code: Select all
labelPosition = hGrp->GetFloat("RadiusDiameterConstraintDisplayBaseAngle", 15) * (M_PI / 180); // Get radius/diameter constraint display angle
labelPositionRandomness = hGrp->GetFloat("RadiusDiameterConstraintDisplayAngleRandomness", 0) * (M_PI / 180); // Get randomness
Then I have some minor code naming things. Like changing finishDistanceConstraint to finishDatumConstraint as now it does more than distances, giving it an additional parameter to handle the case with multiple constraints (the bug above), and some extra checking to avoid unconditionally setting/assigning the label position to all constraints. While now other constraints ignore this field, this may change and would lead to unexpected behaviour.
For the rest I think that functionality and code is ok.
Hopefully tomorrow I will test my local correction commit and will merge PR and my local commit with minor fixes.
The important bit I wanted to convey is the change of the name of the parameters, as this will go to the wiki.
Re: [Features Requests] Sketcher Radius/Diameter presentation
Indeed. I remember I didn't think about testing this.
Yes, as a non native English speaker, less vocabulary is less confusing. -- I'll look for this word, that is pretty the same as the French one for 'availability'. Maybe a false friend --.About the parameter name, I have changed them in my local commit
Believe it or not, it took me a while to understand "Disp" (Disponibility?).
Sounds great.Then I have some minor code naming things. Like changing finishDistanceConstraint to finishDatumConstraint as now it does more than distances...
Very good idea, I probably wouldn't have check for an extra commit when documenting.The important bit I wanted to convey is the change of the name of the parameters, as this will go to the wiki.
Re: [Features Requests] Sketcher Radius/Diameter presentation
There was another thing. This seems to be intended for circles, but not for arcs:
I modified it so that arcs are excluded:
I modified it so that arcs are excluded:
Re: [Features Requests] Sketcher Radius/Diameter presentation
git commit 873e0977cae84d96153ba6040fe7601a73ce5f1e
Re: [Features Requests] Sketcher Radius/Diameter presentation
I'll document in the coming hours.
Re: [Features Requests] Sketcher Radius/Diameter presentation
Thanks to everybody involved! I've to admit I love free software!
Regards / Viele Grüße
Max
Max