2 Issues related to Marz WB

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
Post Reply
NuriEv
Posts: 31
Joined: Thu Jun 18, 2020 10:02 pm

2 Issues related to Marz WB

Post by NuriEv »

MarzWB is one of those really cool addons of FC.
Came across two different issues while trying it.

Attached example drawing is the basis for both issues.

The location is the transition between the head and the neck geometries

Issue 1
Fig. 1: An artifact (A) appears in v.2
Fig. 2: Link Branch _does not_ create the artifact (A).

Issue 2
Fig. 1 and Fig.2
Marz WB seems to create an anomalous ledge (B) between the head and the neck, true for both v.2 and the LinkBranch.
The parameters used for the example neck are probably somewhat unusual. However I'm not sure if that might be the root cause for issue 2.

I only wanted to put this out there in case anyone cares to take a look.

-------------
OS: Debian GNU/Linux 11 (bullseye) (KDE/plasma)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 2022.430.28641 (Git) AppImage
Build type: Release
Branch: LinkStage3
Hash: a77045488092c24ece25d63c91f362cbd2181d36
Python version: 3.9.12
Qt version: 5.12.9
Coin version: 4.0.1
OCC version: 7.5.3
Locale: English/United States (en_US)
-----------------------------------------------

OS: Debian GNU/Linux 11 (bullseye) (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.20.28929 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 6f24fd3)
Hash: 6f24fd3053a89a5fb12ab765f9df93ec04deeac1
Python 3.9.12, Qt 5.12.9, Coin 4.0.0, OCC 7.5.3
Locale: English/United States (en_US)
Installed mods:
* Manipulator 1.4.3
* Design456 880975216.0.0
* Help 1.0.0-alpha
* workfeature
* CADExchanger
* Marz 0.0.26-alpha
* ArchTextures
* workfeature-macro
-----------------------------------
FIG_1_v0.2.jpeg
FIG_1_v0.2.jpeg (153.63 KiB) Viewed 1062 times
FIG_2_LBranch.jpeg
FIG_2_LBranch.jpeg (131.62 KiB) Viewed 1062 times
EXAMPLE.FCStd
(355.28 KiB) Downloaded 7 times
chrisb
Veteran
Posts: 53922
Joined: Tue Mar 17, 2015 9:14 am

Re: 2 Issues related to Marz WB

Post by chrisb »

You may have to contact the author directly via github.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: 2 Issues related to Marz WB

Post by Kunda1 »

CC @mnesarco
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
mnesarco
Posts: 446
Joined: Thu Mar 26, 2020 8:52 pm

Re: 2 Issues related to Marz WB

Post by mnesarco »

Hello Friends,

MarzWB is very outdated. I have rewritten it in plain c++/opencascade. But It turned out to be a monumental effort. right now I have only neck/headstock/fretboard functionality rewritten, the body part is a lot more easy but i have had no time to put on this project. When I started MarzWB i knew nothing about FreeCAD APIs nor OpenCascade, there are some things in MarzWB that are just wrong, especially the transitions.


This is how it started:
Selection_020.png
Selection_020.png (31.24 KiB) Viewed 839 times

And this is how it looks today (c++ dev version)
Screenshot from 2021-10-28 10-00-56.png
Screenshot from 2021-10-28 10-00-56.png (134.39 KiB) Viewed 839 times

During the journey, I have tried versions with Qt/QML, Electron, Diligent Engine, BFGX Engine, ThreeJS, Google Filament, but the current version and the one I am happy with is just plain C++, OpenCascade and ImGui.

Contrary to popular opinion, C++ is an amazing and expressive language. Look at this snippet:

screenshot_82.png
screenshot_82.png (45.09 KiB) Viewed 839 times

Another thing is that I am a 100% linux developer, I know how to package and distribute this as an AppImage for any linux distro. But I have not idea yet how to package this for Windows/Mac. That would be another journey...


I hope I can continue this project soon.

Coming back to your question, there are things that work better in LinkStage3 and others are better in mainstream FreeCAD. I have no plans to continue coding MarzWB as a FreeCAD Python AddOn, my idea is to integrate FreeCAD and MarzDesigner so the user can use both programs together to create guitars. I will never have the FreeCAD's CAD functionality and it is not my intention. The idea is using MarzDesigner to model a parametric instrument in Luthier's terms, then import all the resulting parts into FreeCAD for further processing if required.

Cheers,
Frank.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: 2 Issues related to Marz WB

Post by Kunda1 »

Thanks [@mnesarco. I haven't checked, but would you be open to posting this on the MarzWB README so users understand the direction the workbench is going? Thanks for weighing-in and also all your efforts. Cheers!
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
NuriEv
Posts: 31
Joined: Thu Jun 18, 2020 10:02 pm

Re: 2 Issues related to Marz WB

Post by NuriEv »

Thank you Frank
MarzWB is a wonderful, creative idea. A great effort and matching skills, one of many in the awesome body of work FreeCAD is.
Very happy to hear about the direction you're taking.
Best wishes to you, and all.
User avatar
mnesarco
Posts: 446
Joined: Thu Mar 26, 2020 8:52 pm

Re: 2 Issues related to Marz WB

Post by mnesarco »

Hi Friends,

For sure I don't want to move away from FreeCAD ecosystem. I am still looking for the best integration possible. Maybe a compiled python module that can be used directly from inside FreeCAD or maybe an external running service that can be called from FreeCAD, or a simple import/export mechanism. In any case, I think the way is FreeCAD+MarzDesigner.

Once I have a more clear path, I will update the README accordingly.
Post Reply