[finally released] FreeCAD 0.19 Windows installer release candidate

Info about new community or project announcements, implemented features, classes, modules or APIs. Might get technical!
PLEASE DO NOT POST HELP REQUESTS OR OTHER DISCUSSIONS HERE!
User avatar
turn211
Posts: 133
Joined: Mon Feb 01, 2021 11:37 pm

Re: [finally released] FreeCAD 0.19 Windows installer release candidate

Postby turn211 » Fri Apr 02, 2021 10:43 pm

uwestoehr wrote:
Fri Apr 02, 2021 9:54 pm
bug on all Pre Releases up to Version: 0.19.24267 (Git) which was QT 5.12.5

Confirmed. So the question is not if it is a Conda build or a LibPack build and since it occurs with Qt 5.12 and 5.15, it is most probably not Qt.
What was the last Windows build without the bug? Then I can do a bisect since it seems that a change in FreeCAD's code causes this.
I guess my previous post wasn't clear enough. ALL Windows builds up to Version: 0.19.24267 (Git) did not exhibit this bug. Side note: I design Stylesheets for other Qt 5.15 apps and they don't exhibit this bug. I don't think it is QT

Edit: Clarity
Last edited by turn211 on Sat Apr 03, 2021 2:15 am, edited 4 times in total.
User avatar
turn211
Posts: 133
Joined: Mon Feb 01, 2021 11:37 pm

Re: [finally released] FreeCAD 0.19 Windows installer release candidate

Postby turn211 » Fri Apr 02, 2021 10:51 pm

I stand corrected. The other apps i design Stylesheets for are using Qt 5.13.2
Last edited by turn211 on Sat Apr 03, 2021 2:14 am, edited 2 times in total.
User avatar
turn211
Posts: 133
Joined: Mon Feb 01, 2021 11:37 pm

Re: [finally released] FreeCAD 0.19 Windows installer release candidate

Postby turn211 » Fri Apr 02, 2021 11:02 pm

uwestoehr wrote:
Fri Apr 02, 2021 10:41 pm
uwestoehr wrote:
Fri Apr 02, 2021 9:54 pm
Confirmed. So the question is not if it is a Conda build or a LibPack build and since it occurs with Qt 5.12 and 5.15, it is most probably not Qt.
:oops: It is Qt and only Qt 5.15.1:
https://bugreports.qt.io/browse/QTBUG-86587
and
https://bugreports.qt.io/browse/QTBUG-88276

The first one is fixed in 5.15.2 and I am trying now out if a Qt upgrade fixes our problem.
I tested styling QPushButtons without padding and they work so indeed it is a Qt bug
User avatar
uwestoehr
Posts: 2675
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany

Re: [finally released] FreeCAD 0.19 Windows installer release candidate

Postby uwestoehr » Sat Apr 03, 2021 12:14 am

uwestoehr wrote:
Fri Apr 02, 2021 10:41 pm
The first one is fixed in 5.15.2 and I am trying now out if a Qt upgrade fixes our problem.
Yes, this fixes the bug. I'll now build a new installer that you can test.

@turn211, when you reply, please only cite the sentences you actually refer to. To edit your own post, don't reply to it but just edit it (the leftmost button at the upper right of a post)
User avatar
chennes
Posts: 817
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: [finally released] FreeCAD 0.19 Windows installer release candidate

Postby chennes » Sat Apr 03, 2021 12:17 am

uwestoehr wrote:
Sat Apr 03, 2021 12:14 am
Yes, this fixes the bug. I'll now build a new installer that you can test.
That's great news -- I was a little worried it would turn out to be one of the things they fixed in (commercial-only) 5.15.3. Thanks for tracking it down!!
Chris Hennes
Pioneer Library System
User avatar
uwestoehr
Posts: 2675
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany

Re: [finally released] FreeCAD 0.19 Windows installer release candidate

Postby uwestoehr » Sat Apr 03, 2021 3:48 am

uwestoehr wrote:
Sat Apr 03, 2021 12:14 am
Yes, this fixes the bug. I'll now build a new installer that you can test.
Here it is: https://github.com/donovaly/FreeCADInst ... ller-1.exe

Please test and report back.
I named it FC 0.19.2 because this will deserve a new maintenance release to distinguish it from the other 0.19 releases. I assume more users will complain about the broken style sheets.
User avatar
turn211
Posts: 133
Joined: Mon Feb 01, 2021 11:37 pm

Re: [finally released] FreeCAD 0.19 Windows installer release candidate

Postby turn211 » Sat Apr 03, 2021 5:11 am

uwestoehr wrote:
Sat Apr 03, 2021 3:48 am
Please test and report back.
I named it FC 0.19.2 because this will deserve a new maintenance release to distinguish it from the other 0.19 releases. I assume more users will complain about the broken style sheets.
Works perfect here. Bug gone. Could commit PR 4668 make it into this 19.2 maintenance release as it fixes a Qt 5.15 introduced Stylesheet bug.
Forum Discussion https://forum.freecadweb.org/viewtopic.php?f=34&t=56875
Thanks

OS: Windows 10 Version 2009
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.24276 (Git)
Build type: Release
Branch: releases/FreeCAD-0-19
Hash: a88db11e0a908f6e38f92bfc5187b13ebe470438
Python version: 3.8.6+
Qt version: 5.15.1
Coin version: 4.0.1
OCC version: 7.5.0
Locale: English/Canada (en_CA)
User avatar
uwestoehr
Posts: 2675
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany

Re: [finally released] FreeCAD 0.19 Windows installer release candidate

Postby uwestoehr » Sat Apr 03, 2021 5:02 pm

turn211 wrote:
Sat Apr 03, 2021 5:11 am
Works perfect here. Bug gone. Could commit PR 4668 make it into this 19.2 maintenance release as it fixes a Qt 5.15 introduced Stylesheet bug.
Very good that we fixed it that simple.

I asked Werner to commit the PR to the 0_19 branch.

Then we need to make a new release 0.19.2. @sgrogan, OK with you?
User avatar
sgrogan
Posts: 6326
Joined: Wed Oct 22, 2014 5:02 pm

Re: [finally released] FreeCAD 0.19 Windows installer release candidate

Postby sgrogan » Sat Apr 03, 2021 6:35 pm

uwestoehr wrote:
Sat Apr 03, 2021 5:02 pm
Then we need to make a new release 0.19.2. @sgrogan, OK with you?
Yes! This is how I'd prefer to handle these types of fixes. Your comment in the PR is spot on.
"fight the good fight"
User avatar
uwestoehr
Posts: 2675
Joined: Sun Jan 27, 2019 3:21 am
Location: Germany

Re: [finally released] FreeCAD 0.19 Windows installer release candidate

Postby uwestoehr » Wed Apr 07, 2021 2:07 pm

sgrogan wrote:
Sat Apr 03, 2021 6:35 pm
Yes! This is how I'd prefer to handle these types of fixes. Your comment in the PR is spot on.
Fine. Werner committed the PR now also to the 0.19 branch:
https://github.com/FreeCAD/FreeCAD/comm ... 292a476672

So we can release 0.19.2 right now. Can you please make a tag and all the other steps that need to be done? I can help with a Win-installer if you like.