Part Revolve parametric axis link

Info about new community or project announcements, implemented features, classes, modules or APIs. Might get technical!
PLEASE DO NOT POST HELP REQUESTS OR OTHER DISCUSSIONS HERE!
User avatar
DeepSOIC
Posts: 6639
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Part Revolve parametric axis link

Postby DeepSOIC » Tue Aug 09, 2016 10:28 am

Since 0.17.8172, Part Revolve can use arbitrary line or edge from the model as revolution axis, and establish parametric link to it.

The edge can be a line, or a circle/arc. If arc of circle, and angle of Revolve is set to zero, the angle span of the arc is used.

Also, symmetric option was added (functions like PartDesign's Symmetric to plane).

Image
Enjoy ;)
ezzieyguywuf
Posts: 455
Joined: Tue May 19, 2015 1:11 am

Re: Part Revolve parametric axis link

Postby ezzieyguywuf » Wed Aug 10, 2016 1:26 pm

Nicely done!
User avatar
f3nix
Posts: 299
Joined: Sat May 30, 2015 11:58 am

Re: Part Revolve parametric axis link

Postby f3nix » Wed Aug 31, 2016 8:44 pm

Thanks DeepSOIC! :)

I wanted to give it a try but it seems that the layout of the task panel is broken for me.

The spinboxes are too small. I'm using KDE.
revolve_task_panel.png
revolve_task_panel.png (24.21 KiB) Viewed 1434 times
OS: Debian GNU/Linux unstable (sid)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.8318 (Git)
Build type: Debug
Branch: master
Hash: ff2ccdd64852c0c6b2066ed439e2b2a3d53d842b
Python version: 2.7.12+
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.0.0

Cheers,
Mateusz
User avatar
DeepSOIC
Posts: 6639
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Part Revolve parametric axis link

Postby DeepSOIC » Wed Aug 31, 2016 10:40 pm

f3nix wrote:that the layout of the task panel is broken for me.
Oh, how was I supposed to know....
That Qt designer... I hate it.
Can you fix it, pleease? :roll: That probably applies to reworked Part Extrude dialog that is now stuck in pull requests...
triplus
Posts: 8415
Joined: Mon Dec 12, 2011 4:45 pm

Re: Part Revolve parametric axis link

Postby triplus » Wed Aug 31, 2016 10:49 pm

And after so much time invested in all the Tasks sidebar related things! ;)
User avatar
f3nix
Posts: 299
Joined: Sat May 30, 2015 11:58 am

Re: Part Revolve parametric axis link

Postby f3nix » Thu Sep 01, 2016 8:24 pm

Hi.
I've attached a patch that fixes it for me. Hopefully it does not break anything on other platforms. Please give it a try.

Thanks again for these new tools! :)

Cheers,
Mateusz

---
Some screenshots.
Revolve
Before
revolve_task_panel.png
revolve_task_panel.png (24.21 KiB) Viewed 1349 times
After
revolve_task_panel_fixed.png
revolve_task_panel_fixed.png (28.39 KiB) Viewed 1349 times
Extrude
Before
extrude_task_panel.png
extrude_task_panel.png (30.38 KiB) Viewed 1349 times
After
extrude_task_panel_fixed.png
extrude_task_panel_fixed.png (32.59 KiB) Viewed 1349 times
Attachments
layout_fix.patch.bz2
(2.17 KiB) Downloaded 27 times
User avatar
DeepSOIC
Posts: 6639
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Part Revolve parametric axis link

Postby DeepSOIC » Thu Sep 01, 2016 8:51 pm

Thanks f3nix, the layout is still all right on Windows 10.
User avatar
DeepSOIC
Posts: 6639
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Part Revolve parametric axis link

Postby DeepSOIC » Fri Sep 02, 2016 9:10 am

f3nix wrote:I've attached a patch that fixes it for me.
I created a pull-request for it. https://github.com/FreeCAD/FreeCAD/pull/271
I hope you don't mind that the commit bears my authorship. At least I mentioned you ;)
User avatar
f3nix
Posts: 299
Joined: Sat May 30, 2015 11:58 am

Re: Part Revolve parametric axis link

Postby f3nix » Sat Sep 03, 2016 12:53 pm

DeepSOIC wrote:
f3nix wrote:I've attached a patch that fixes it for me.
I created a pull-request for it. https://github.com/FreeCAD/FreeCAD/pull/271
I hope you don't mind that the commit bears my authorship. At least I mentioned you ;)
Great! :) No. I do not mind.

Thanks again for your work! :)

Cheers,
Mateusz