Gesture navigation style updates (may 2019)

Info about new community or project announcements, implemented features, classes, modules or APIs. Might get technical!
PLEASE DO NOT POST HELP REQUESTS OR OTHER DISCUSSIONS HERE!
chrisb
Posts: 18010
Joined: Tue Mar 17, 2015 9:14 am

Re: Gesture navigation style updates (may 2019)

Postby chrisb » Fri Jun 14, 2019 11:18 pm

This looks better:

Code: Select all

0(40,605)
0(40,605)
0(40,605)
0(40,605)
0(40,605)
0(40,605)
0(40,605)
Gesture start SoGesturePinchEvent(-338,707)
 -> GestureState
Gesture start SoGesturePinchEvent(-338,707)
Gesture end SoGesturePinchEvent(-338,707)
 -> IdleState
During the 0(40,605) outputs it zooms correctly (or vice versa). If I end zooming The camera position jumps and I get the three "Gesture" outputs.
User avatar
DeepSOIC
Posts: 6951
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Gesture navigation style updates (may 2019)

Postby DeepSOIC » Sat Jun 15, 2019 12:15 am

0(blah,blah) looks like mouse wheel events are coming. It looks like gesture events are not properly generated, so it's probably best to make FreeCAD ignore them altogether on MacOS.
chrisb
Posts: 18010
Joined: Tue Mar 17, 2015 9:14 am

Re: Gesture navigation style updates (may 2019)

Postby chrisb » Sat Jun 15, 2019 7:59 am

For zooming I use two fingers on the touchpad. Move them up is zooming out, moving down is zooming in. All this happens on the 0(blah,blah) events. Please don't disable them too :), the rest can well be ignored, as far as I am concerned.
User avatar
DeepSOIC
Posts: 6951
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Gesture navigation style updates (may 2019)

Postby DeepSOIC » Sat Jun 15, 2019 8:19 am

chrisb wrote:
Sat Jun 15, 2019 7:59 am
For zooming I use two fingers on the touchpad. Move them up is zooming out, moving down is zooming in.
Does anything happen if you pinch instead, as if the touchpad is a touchscreen?
chrisb
Posts: 18010
Joined: Tue Mar 17, 2015 9:14 am

Re: Gesture navigation style updates (may 2019)

Postby chrisb » Sat Jun 15, 2019 9:10 am

DeepSOIC wrote:
Sat Jun 15, 2019 8:19 am
Does anything happen if you pinch instead, as if the touchpad is a touchscreen?
Yes, the zoomed object moves immediately at the lower right corner out of sight, in the same way as it did before after finishing zooming.

Output:

Code: Select all

Gesture start SoGesturePinchEvent(186,524)
 -> GestureState
Gesture start SoGesturePinchEvent(186,524)
Gesture data SoGesturePinchEvent(186,524)
Gesture data SoGesturePinchEvent(186,524)
Gesture end SoGesturePinchEvent(186,524)
 -> IdleState
Gesture start SoGesturePinchEvent(-378,838)
 -> GestureState
Gesture end SoGesturePinchEvent(-378,838)
 -> IdleState
User avatar
DeepSOIC
Posts: 6951
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Gesture navigation style updates (may 2019)

Postby DeepSOIC » Sat Jun 15, 2019 12:46 pm

So I looked at the code, and it's probably the double start event that is causing a problem. I have for some reason commented out the ignoring of extra start events (don't remember why I did, possibly as an attempt to fix some early bug), now I wonder if I can uncomment it and it fixes the problem... I'll experiment later, i'm overloaded right now.
User avatar
Kunda1
Posts: 5466
Joined: Thu Jan 05, 2017 9:03 pm

Re: Gesture navigation style updates (may 2019)

Postby Kunda1 » Sat Jun 15, 2019 2:37 pm

quick question: should we open a ticket to track this ?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
DeepSOIC
Posts: 6951
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Gesture navigation style updates (may 2019)

Postby DeepSOIC » Sat Jun 15, 2019 2:45 pm

Kunda1 wrote:
Sat Jun 15, 2019 2:37 pm
quick question: should we open a ticket to track this ?
Why not? ;)
User avatar
Kunda1
Posts: 5466
Joined: Thu Jan 05, 2017 9:03 pm

Re: Gesture navigation style updates (may 2019)

Postby Kunda1 » Sat Jun 15, 2019 6:13 pm

DeepSOIC wrote:
Sat Jun 15, 2019 2:45 pm
Kunda1 wrote:
Sat Jun 15, 2019 2:37 pm
quick question: should we open a ticket to track this ?
Why not? ;)
chrisb wrote:
Sat Jun 15, 2019 7:59 am
@chrisb are these 2 separate issues? or all one?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
chrisb
Posts: 18010
Joined: Tue Mar 17, 2015 9:14 am

Re: Gesture navigation style updates (may 2019)

Postby chrisb » Sat Jun 15, 2019 8:57 pm

It's all in one.