Addon Manager improvements

Info about new community or project announcements, implemented features, classes, modules or APIs. Might get technical!
PLEASE DO NOT POST HELP REQUESTS OR OTHER DISCUSSIONS HERE!
Syres
Posts: 293
Joined: Thu Aug 09, 2018 11:14 am

Re: Addon Manager improvements

Postby Syres » Wed Jun 19, 2019 2:48 pm

Kunda1 wrote:
Wed Jun 19, 2019 2:30 pm
Awesome, do you have these edits in a git branch that we can easily make a Pull Request from ?
It won't be a big job for me to sort a PR out for my changes, let's see whether @sgrogan is happy with the latest fixes. I've got a bit of time tomorrow to look at anything else that maybe needs tweaking and then I'll submit the PR.

I'm still getting infrequent crashes though. Scenario, I accidently click the workbench in AddonManager just above/below the one I really want to check (not an unreasonable error to make) and then quickly click the correct one (I'm on a fairly slow by modern standards internet connection). FreeCAD intermittently crashes as if it not happy that it hasn't completed the loading of the Readme and images. This is getting out of my limited Python knowledge.
User avatar
yorik
Site Admin
Posts: 11397
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Addon Manager improvements

Postby yorik » Wed Jun 19, 2019 6:55 pm

Hi all,
Out of home now but I submitted a fix for:
nic wrote:
Wed Jun 19, 2019 6:51 am
It indeed misses AddonManager_rc.py and I cannot find this module from github.
For the rest, @Syres's solution seems a good way to go.

@Kunda1 I see your idea... Will look at what's possible after the WE when I'm back
User avatar
sgrogan
Posts: 5207
Joined: Wed Oct 22, 2014 5:02 pm

Re: Addon Manager improvements

Postby sgrogan » Wed Jun 19, 2019 9:10 pm

Syres wrote:
Wed Jun 19, 2019 2:48 pm
let's see whether @sgrogan is happy with the latest fixes
I'm very happy with all your fixes :) Thanks for your continued interest.

For the WebTools WB I still have trouble with the 3rd (Sketchfab) image. Indeed the link is broken in the upstream github repo, so no problem with the Add-ons manager.

For the SlopedPlaneMacro WB something weird id happening

Code: Select all

AddonManager: Debug: Error retrieving image from https://github.com/caceres/SlopedPlanesMacro/raw/master/SlopedPlanes.png
AddonManager: Debug: Error retrieving image from https://camo.githubusercontent.com/ff1752a9e32effcd5dba0a0b6da110b56c906e04/68747470733a2f2f7472617669732d63692e6f72672f636163657265732f536c6f706564506c616e65734d6163726f2e7376673f6272616e63683d6d6173746572
AddonManager: Debug: Error retrieving image from https://camo.githubusercontent.com/7098bc5a53df0faa7f17ff47633b460c3486bc37/68747470733a2f2f7472617669732d63692e6f72672f636163657265732f536c6f706564506c616e65734d6163726f2e7376673f6272616e63683d646576656c6f70
AddonManager: Debug: Error retrieving image from https://camo.githubusercontent.com/1c6769f69513f13be4463181732ceb704474cc9a/68747470733a2f2f7472617669732d63692e6f72672f636163657265732f536c6f706564506c616e65734d6163726f2e7376673f6272616e63683d312e31
The https://github.com/caceres account has no public repos. If you look at the repo that's linked from the FreeCAD-addons repo (https://github.com/luzpaz/SlopedPlanesM ... 65b662961f) the README.md doesn't even match what shown in the Addons-manager. The README.md does say that caceres is the developer.
I don't know how to further test this :( Maybe this is an upstream problem as well?

I think a pull request is in order now.

@Kunda1, I still see the folder, not the icon for the yaml-workspce WB.
User avatar
Kunda1
Posts: 4812
Joined: Thu Jan 05, 2017 9:03 pm

Re: Addon Manager improvements

Postby Kunda1 » Thu Jun 20, 2019 3:06 am

Issue: I have no idea what version of any workbench I have installed (except for A2plus which has the version in workbench drop-down menu).

Feature request: Addon Manager UI should show the version of the installed workbench.
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
Syres
Posts: 293
Joined: Thu Aug 09, 2018 11:14 am

Re: Addon Manager improvements

Postby Syres » Thu Jun 20, 2019 8:27 am

kisolre
Posts: 1106
Joined: Wed Nov 21, 2018 1:13 pm

Re: Addon Manager improvements

Postby kisolre » Thu Jun 20, 2019 8:30 pm

Clicking on image in WB description opens it as text
ImageAsText.gif
ImageAsText.gif (87.14 KiB) Viewed 356 times

Code: Select all

OS: Windows 8.1 (6.3)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.17065 (Git)
Build type: Release
Branch: master
Hash: d890b4ec17b9030dc2933c029debb2a655a08218
Python version: 3.6.8
Qt version: 5.12.1
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Bulgarian/Bulgaria (bg_BG)
User avatar
sgrogan
Posts: 5207
Joined: Wed Oct 22, 2014 5:02 pm

Re: Addon Manager improvements

Postby sgrogan » Fri Jun 21, 2019 9:09 pm

kisolre wrote:
Thu Jun 20, 2019 8:30 pm
Clicking on image in WB description opens it as text
I can confirm with double left click.
But how to fix it? I'm glad to able to right click and copy the link.
User avatar
yorik
Site Admin
Posts: 11397
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Addon Manager improvements

Postby yorik » Thu Jun 27, 2019 5:53 pm

kisolre wrote:
Thu Jun 20, 2019 8:30 pm
Clicking on image in WB description opens it as text
Fixed in git commit 49067725c
User avatar
furti
Posts: 277
Joined: Mon Nov 27, 2017 5:27 pm

Re: Addon Manager improvements

Postby furti » Fri Jun 28, 2019 3:49 am

sgrogan wrote:
Wed Jun 19, 2019 9:10 pm
For the SlopedPlaneMacro WB something weird id happening
What happend with the workbench is described in this thread starting from the following post.
http://forum.freecadweb.org/viewtopic.p ... 7&start=80
User avatar
sgrogan
Posts: 5207
Joined: Wed Oct 22, 2014 5:02 pm

Re: Addon Manager improvements

Postby sgrogan » Fri Jun 28, 2019 7:11 pm

furti wrote:
Fri Jun 28, 2019 3:49 am
What happend with the workbench is described in this thread starting from the following post.
http://forum.freecadweb.org/viewtopic.p ... 7&start=80
Thanks for the link. I don't see where the links to the defunct repo come from. It seems everything from the FreeCAD/repo points to the luzpaz repo?