Addon Manager Redesign 2021

Info about new community or project announcements, implemented features, classes, modules or APIs. Might get technical!
PLEASE DO NOT POST HELP REQUESTS OR OTHER DISCUSSIONS HERE!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
chennes
Veteran
Posts: 3876
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Addon Manager Redesign 2021

Post by chennes »

Now for something that will definitely affect everyone's Addon Manager experience... I am experimenting with replacing the current semi-offline README viewer with an embedded web browser. Please see the draft PR here and give it a run: https://github.com/FreeCAD/FreeCAD/pull/5413

The difference is most obvious, and most beneficial, for macros. For Workbenches it's a little annoying because there is so much stuff at the top of a GitHub page. I welcome your feedback and ideas.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
rynn
Posts: 454
Joined: Tue Jul 31, 2018 7:00 am

Re: Addon Manager Redesign 2021

Post by rynn »

chennes wrote: Sat Jan 22, 2022 3:13 am I am experimenting with replacing the current semi-offline README viewer with an embedded web browser.
This might become a security nightmare… Are you sure you want to open this can of worms?
User avatar
chennes
Veteran
Posts: 3876
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Addon Manager Redesign 2021

Post by chennes »

rynn wrote: Sun Jan 23, 2022 4:34 pm This might become a security nightmare… Are you sure you want to open this can of worms?
Alas, the can is already open - Start is already a QWebEngine.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
rynn
Posts: 454
Joined: Tue Jul 31, 2018 7:00 am

Re: Addon Manager Redesign 2021

Post by rynn »

chennes wrote: Sun Jan 23, 2022 6:00 pm Alas, the can is already open - Start is already a QWebEngine.
Yes, but as far as I know, Start is a local page and on default nothing is loaded from the net.
kisolre
Veteran
Posts: 4162
Joined: Wed Nov 21, 2018 1:13 pm

Re: Addon Manager Redesign 2021

Post by kisolre »

rynn wrote: Sun Jan 23, 2022 7:15 pm Start is a local page and on default nothing is loaded from the net.
There is a direct link to the FreeCAD home page, Help tab links to the Wki, ...
User avatar
chennes
Veteran
Posts: 3876
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Addon Manager Redesign 2021

Post by chennes »

Is there a specific security threat you are thinking of here? Obviously the Addon Manager is already downloading data off of the internet (that being its whole purpose), whether I use a web browser to show the information or a QTextEdit widget. But the QTextEdit does a poor job of rendering images, can't render online images at all (so we have to download and manually cache local copies), and doesn't support following hyperlinks, so e.g. you can't change the language displayed, even if there is a translated version available.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
freecad-heini-1
Veteran
Posts: 7788
Joined: Tue Jan 07, 2014 11:10 am
Contact:

Re: Addon Manager Redesign 2021

Post by freecad-heini-1 »

Guten Tag,
I am using the following daily updated Freecad version, which was updated this morning:

Code: Select all

OS: Ubuntu 18.04.6 LTS (XFCE/xubuntu)
Word size of FreeCAD: 64-bit
Version: 0.20.
Build type: Release
Branch: unknown
Hash: 4fb91e4f02636fdb69eb8471dbbbe154dc932872
Python version: 3.6.9
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.5.2
Locale: German/Germany (de_DE)
Since the redesign of the Addon Manager I am missing the following workbenches and I don't know how to install them:
Manipulator
Lattice2
Defeaturing

Who can help, how do these workbenches find their way into the new Addon Manager?

Many regards from Germany
Wilfried
User avatar
chennes
Veteran
Posts: 3876
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Addon Manager Redesign 2021

Post by chennes »

Can you please turn on logging and have the Addon Manager re-cache? I see all three of those in mine, so I'd like to see if there is some specific error that's cropping up for you.
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
rynn
Posts: 454
Joined: Tue Jul 31, 2018 7:00 am

Re: Addon Manager Redesign 2021

Post by rynn »

FYIO:

I had strange behaviour with git-version from today:
It was a temporary problem. I got a lot of
Addon Manager internal error: lost metadata for package XXX

For about half the workbenches I had installed, addon-manager no longer knew the source and could not determine if they are up-to-date. Including quite popular workbenches like A2plus or SheetMetal.
B.png
B.png (73.71 KiB) Viewed 1616 times
If I filtered for workbenches these were not even displayed.
A.png
A.png (46.45 KiB) Viewed 1616 times
If I filter for workbenches they are not even displayed.
User avatar
chennes
Veteran
Posts: 3876
Joined: Fri Dec 23, 2016 3:38 pm
Location: Norman, OK, USA
Contact:

Re: Addon Manager Redesign 2021

Post by chennes »

I pushed a significant change under the hood yesterday -- can you try re-caching?
Chris Hennes
Pioneer Library System
GitHub profile, LinkedIn profile, chrishennes.com
Post Reply