[New feature] Sketcher Constrain Contextually

[Haavard]

I agree, much better to get the first version merged when its ready, so more people can test and give their opinion. Lets keep the feature creep away for now I will see if i dare look at the source code this weekend, perhaps i can help polish the text strings a bit.

[paddle]

I agree, much better to get the first version merged when its ready, so more people can test and give their opinion. Lets keep the feature creep away for now I will see if i dare look at the source code this weekend, perhaps i can help polish the text strings a bit.

Sooooo after 8 hours on that space key issue the problem is still standing...
For now I switched back to shift. But it does not solve the space key toggling on and off the visibility of the sketch

Which is not a fatal flaw but annoying behaviour. Especially because it prevents us to use Space key.

Beside after capitulating I improved some things on the constrain tree. Prevented the tool from offering parallel or perpendicular if both lines are vertical/horizontal for instance.

Symmetric constrain is added for 3 points, 1point 1 line, 2 points 1 line.

I havent removed parallel + distance mode for now. But yeah maybe it's overkill I'll think about it some more.

Topic standing :
- Polishing the constrain tree to get the most intuitive/usefull combo. Also it needs to test the tool, find errors, in the hints also.
- Space key issue. Which is a problem of sending the complete focus back to the ViewproviderSketcher...
- Moving the constraints slightly shifted to avoid cluttering the mouse pointer.
- ?

Github updated if you want to try.

[paddle]

I agree, much better to get the first version merged when its ready, so more people can test and give their opinion. Lets keep the feature creep away for now I will see if i dare look at the source code this weekend, perhaps i can help polish the text strings a bit.

Some comments on your PDF :
- 1 point : autodimension to the origin is an interesting idea. Though I don't know if distance to origin is really useful.
edit: Changed to lock, autodimensions.
- 2 points : horizontal/vertical? edit: oh I didn't knew that it was possible. I actually tried to implement that for 3+ points but using distanceX/Y which is ugly. Thanks for the tip I'll add that.
edit2:So I added horizontal/vertical for 2+ points
- 3points : coincident, symmetry, horizontal, vertical
- 4+points coincident, horizontal, vertical
- 1line : autodimension, vertical horizontal (it wasn't working due to space key bug)
- 2lines : tangent?

[Haavard]

Some comments on your PDF :
- 1 point : autodimension to the origin is an interesting idea. Though I don't know if distance to origin is really useful.
edit: Changed to lock, autodimensions.
- 2 points : horizontal/vertical? edit: oh I didn't knew that it was possible. I actually tried to implement that for 3+ points but using distanceX/Y which is ugly. Thanks for the tip I'll add that.
edit2:So I added horizontal/vertical for 2+ points
- 3points : coincident, symmetry, horizontal, vertical
- 4+points coincident, horizontal, vertical
- 1line : autodimension, vertical horizontal (it wasn't working due to space key bug)
- 2lines : tangent?

Just my rationale:
-1 point: i just really enjoy using the "autodimension" feature, in my mind it replaces horizontal and vertical length since you have both by moving the mouse..
- Yeah horizontal and vertical constraint on points is used just as much as on lines, at least on my sketches
- I feel like coincident as default, and symmetry as second option worked very well in the last commit! Nice!
- 2 lines tangent: this is useful when two lines must be "on axis", but can also be constrained by making them parallel and 0mm (or point on object).

Now off to test some more

[Haavard]

And i hope some others are also testing this, i don't want to let my biases push the development in a wrong direction

[paddle]

Some comments on your PDF :
- 1 point : autodimension to the origin is an interesting idea. Though I don't know if distance to origin is really useful.
edit: Changed to lock, autodimensions.
- 2 points : horizontal/vertical? edit: oh I didn't knew that it was possible. I actually tried to implement that for 3+ points but using distanceX/Y which is ugly. Thanks for the tip I'll add that.
edit2:So I added horizontal/vertical for 2+ points
- 3points : coincident, symmetry, horizontal, vertical
- 4+points coincident, horizontal, vertical
- 1line : autodimension, vertical horizontal (it wasn't working due to space key bug)
- 2lines : tangent?

Just my rationale:
-1 point: i just really enjoy using the "autodimension" feature, in my mind it replaces horizontal and vertical length since you have both by moving the mouse..
- Yeah horizontal and vertical constraint on points is used just as much as on lines, at least on my sketches
- I feel like coincident as default, and symmetry as second option worked very well in the last commit! Nice!
- 2 lines tangent: this is useful when two lines must be "on axis", but can also be constrained by making them parallel and 0mm (or point on object).

Now off to test some more

Oh yes tangent is good indeed. I have a lot of time where I needed that and never thought of using tangent between lines.

[paddle]

And i hope some others are also testing this, i don't want to let my biases push the development in a wrong direction

I added a few combinaisons, and solved few bugs. But mostly I cleaned the code so that you can have a look at the IF tree.
I tried to prevent overconstraints. So for instance if 2 lines are already parallel, then the tangent deletes the parallel before applying. This way you can make tangent even if line are parallels

It's in the function makeAppropriateConstraint

With this you should be able to understand what behaviour is expected where (kind of your PDF).

If you can check it out and repport any issue or uncaught behaviours !

[fortress_bravo]

I see that this (and the tool settings PR) hasn't yet been merged. Are there any blockers preventing it from going in?

[paddle]

I see that this (and the tool settings PR) hasn't yet been merged. Are there any blockers preventing it from going in?

As GeneFC pointed out in PR topic, it's a big feature so it may take a while to merge.
Also Abdullah, the main Sketcher Merger, is currently not available. I seem to recall he told he'll be back end of February.
Hope it'll get merged then
In the meantime I'm improving some small things and looking for the eventual bug.

[Kunda1]

In the meantime I'm improving some small things and looking for the eventual bug.

Thanks for you patience and all your efforts!