Just force-pushed replacing them. There are some other places we can change to unsigned or size_t but they are outside of the changes in the PR.abdullah wrote: ↑Tue Nov 08, 2022 1:48 pm Momentarily, I have changed branch to test the knot only version:
https://github.com/FreeCAD/FreeCAD/pull/7484
This still has the issues with the signed/unsigned we discussed via PM for version 2.
B-Spline Constraints: Fully Funded! Thanks everybody!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: B-Spline Constraints: Almost Done! Help Reach Goal!
My latest (or last) project: B-spline Construction Project.
Re: B-Spline Constraints: Almost Done! Help Reach Goal!
@abdullah, I just added another commit to #7484 which makes the knot constraint internal alignment in the solver. This doesn't solve any tangent issue, but of course this one was necessary.
My latest (or last) project: B-spline Construction Project.
Re: B-Spline Constraints: Fully Funded! Thanks everybody!
@jnxd You wouldn't happen to be working on a fix for a mesh issue by any chance would you?
Ref my last post right at the bottom of this thread: https://forum.freecadweb.org/viewtopic. ... 44&t=69151
Thanks,
Jon
Ref my last post right at the bottom of this thread: https://forum.freecadweb.org/viewtopic. ... 44&t=69151
Thanks,
Jon
Re: B-Spline Constraints: Fully Funded! Thanks everybody!
I'm not, but I'll take a look.Jon557 wrote: ↑Sun Nov 13, 2022 8:37 pm @jnxd You wouldn't happen to be working on a fix for a mesh issue by any chance would you?
Ref my last post right at the bottom of this thread: https://forum.freecadweb.org/viewtopic. ... 44&t=69151
Thanks,
Jon
My latest (or last) project: B-spline Construction Project.
Re: B-Spline Constraints: Fully Funded! Thanks everybody!
Just wanted to note that I have finished reviewing the knot part. There are some comments that need addressing, but my expectation is that it will be merged soon.
Then, knowing that tangencies are generally more problematic at solver level (not only B-Spline, but many others), I wonder if it makes sense to you to prepare a PR for Point on Object. This is generally easier on the solver, it is very useful for users, and I think will have a much better change for a quick review and merge. What do you think?
Then, knowing that tangencies are generally more problematic at solver level (not only B-Spline, but many others), I wonder if it makes sense to you to prepare a PR for Point on Object. This is generally easier on the solver, it is very useful for users, and I think will have a much better change for a quick review and merge. What do you think?
Re: B-Spline Constraints: Fully Funded! Thanks everybody!
Indeed I've seen this. Let's discuss further in the PR itself.
I was thinking the exact same thing: https://github.com/FreeCAD/FreeCAD/pull/7782. However as noted there, removing commits from tangent-at-knot is not trivial so I need to work on that. You can start testing, however, provided you don't use tangents.abdullah wrote: ↑Tue Nov 15, 2022 11:27 am Then, knowing that tangencies are generally more problematic at solver level (not only B-Spline, but many others), I wonder if it makes sense to you to prepare a PR for Point on Object. This is generally easier on the solver, it is very useful for users, and I think will have a much better change for a quick review and merge. What do you think?
My latest (or last) project: B-spline Construction Project.
Re: B-Spline Constraints: Fully Funded! Thanks everybody!
I have been able to do some tests (not comprehensive yet). It looks good.jnxd wrote: ↑Tue Nov 15, 2022 12:35 pm I was thinking the exact same thing: https://github.com/FreeCAD/FreeCAD/pull/7782. However as noted there, removing commits from tangent-at-knot is not trivial so I need to work on that. You can start testing, however, provided you don't use tangents.
I only had an issue with the Block constraint, which I am not sure yet if it is a problem of the PoO or of other parts of the Sketcher. I need to investigate further.
Re: B-Spline Constraints: Fully Funded! Thanks everybody!
OK. Not sure what you're referring to. Maybe it's best if we finish off the knot constraints before moving to PoO.
My latest (or last) project: B-spline Construction Project.
Re: B-Spline Constraints: Fully Funded! Thanks everybody!
Did you change the PoO branch in the meantime? Now I cannot reproduce the problem anymore, and I would like to know if gobbles are messing with my PC or your magic wand is at hand here...
Re: B-Spline Constraints: Fully Funded! Thanks everybody!
Ajinkya, now that knots are merged, would you prepare a PoO rebased on master for review, so that we move forward?