Thanks!ickby wrote:Nic work Eivind!
Sketcher points don't create any vertices do they? Currently I iterate through the actual shape to get the circles. My initial implementation required an actual sketch, so to be able to use points (which I tend to agree is better), I would need to required a sketch again, and then look for point objects in the sketch.ickby wrote:1. Could this be made to also work with points in sketches? As the circle radius is ignored anyway, it is easier to get a fully constraint sketch with single points.
I've just implemented the missing bits in the already existing FeatureHole class in PartDesign. I can see that this is a bit limiting, as it forces you to use PartDesign for the part. I'll see if I can come up with a refactoring of the code that can place much of the geomtry in the Part module. Another thing; wouldn't this be the first then of "negative" objects. These also need to cut into objects they attach to. Do we have support for that? A manual cut after the attachment isn't very elegant...ickby wrote: 2. While playing I intuitively thougth the holes are placed like the primitives, with the attachment code. One at a time. I personally would find that a usefull method to have next to sketches (which are obvisoly better for multiple holes). Would it be possible to either support both methods or have a second hole feature which is placed with attachments?
Thanks!sgrogan wrote:First Impression...WOW
It's not passed to TechDraw as of now, but I think this should be fairly easy to implement (without having looked at the code), as all the hole data are available as properties.sgrogan wrote: There is a lot here. Is the thread information somehow passed to TechDraw for example? Haven't tested this yet. too many properties to explore.
This is going to be extremely useful!
Thank You!, threads handled by meta-data or properties will be great. Accurate 3d threads are unnecessary for me, I usually just model the tap drill. I do like @ickby's idea about using points. I've just been making all circle radii equal and constraining one to a small random value. I'm still experimenting, but this is very good.eivindkvedalen wrote:Thanks!
sgrogan wrote:
There is a lot here. Is the thread information somehow passed to TechDraw for example? Haven't tested this yet. too many properties to explore.
This is going to be extremely useful!
It's not passed to TechDraw as of now, but I think this should be fairly easy to implement (without having looked at the code), as all the hole data are available as properties.
In Part Design there is a AddSub object from which also the subtracrive primitives derived that handle the Cut.eivindkvedalen wrote:
I've just implemented the missing bits in the already existing FeatureHole class in PartDesign. I can see that this is a bit limiting, as it forces you to use PartDesign for the part. I'll see if I can come up with a refactoring of the code that can place much of the geomtry in the Part module. Another thing; wouldn't this be the first then of "negative" objects. These also need to cut into objects they attach to. Do we have support for that? A manual cut after the attachment isn't very elegant...
Eivind
). All the time since 1982 I worked as a designer for tool machines. Freecad I joined 2014 for testing, Now I attend to use it for a small private project. Now my questions:
FreeCAD