[SOLVED] Migrating (soon to be deprecated) Drawing WB tickets to TechDraw WB

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
User avatar
Kunda1
Posts: 5927
Joined: Thu Jan 05, 2017 9:03 pm

[SOLVED] Migrating (soon to be deprecated) Drawing WB tickets to TechDraw WB

Postby Kunda1 » Sun Jan 29, 2017 7:13 pm

I've started this thread due to understanding that soon the Drawing WB will be replaced by the TechDraw WB. If that is the case I had the idea of a place to discuss (I didn't find another thread so far) migrating the remaining Drawing tracker bugs to TechDraw. These are the current open Drawing bugs:

issue #0002620 Appears in both V0.16 and daily builds Drawing dxf export not working correctly
issue #0002383 Drawing lines missing or incorrect
issue #0001867 Use QtWebKit (QWebView) instead of QtSvg for DW drawing area
issue #0001822 Scale factor property in drawing page limited to one digit (sometime two)
issue #0001688 Orthographic projection uses more digits behind decimal point for scale than shown in properties
issue #0002004 Performance regression when more drawing pages inserted
issue #0002283 Drawing::FeatureViewPart LineWidth should not be scaled
issue #0001727 API function Drawing.projectToDXF
issue #0002184 Drawing template filenames for ISO7200 are numbered consecutively but corresponding files do not exist
issue #0002384 Drawing dotted lines are inconsistent
issue #0002123 drawing workbench - enable rotation by 3 axis
issue #0002629 Merge Drawing_dimensioning into Drawing
issue #0001921 Drawing view hidden lines and stroke-dasharray
issue #0001920 Drawing scale and stroke-dasharray
issue #0002648 Changing the template in the Drawing-Workbench is not saved
issue #0000143 Allow moving of views graphically on the page
issue #0001880 Show/hide drawing template structure
issue #0001863 Global preference for drawing line width
issue #0001494 Add the current view in the orthographic projection tool
issue #0001679 Add an action to set orthographic projections as hints for a drawing page

Lets discuss which can be migrated and how. Thanks!
Last edited by Kunda1 on Tue Dec 18, 2018 11:50 am, edited 13 times in total.
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Migrating (soon to be deprecated) Drawing WB tickets to TechDraw WB

Postby NormandC » Sun Jan 29, 2017 11:56 pm

Kunda1 wrote:issue #0000143 Allow moving of views graphically on the page
That's one of my bug reports! You can tell how long I've been around by its low number :D

This can actually be closed as fixed in 0.17/TechDraw, I just wasn't sure how to proceed, maybe refer to the commit that merged the TechDraw code to master? (Can't find a way to get it)
User avatar
Kunda1
Posts: 5927
Joined: Thu Jan 05, 2017 9:03 pm

Re: Migrating (soon to be deprecated) Drawing WB tickets to TechDraw WB

Postby Kunda1 » Mon Jan 30, 2017 1:07 am

NormandC wrote:
Kunda1 wrote:issue #0000143 Allow moving of views graphically on the page
That's one of my bug reports! You can tell how long I've been around by its low number :D

This can actually be closed as fixed in 0.17/TechDraw, I just wasn't sure how to proceed, maybe refer to the commit that merged the TechDraw code to master? (Can't find a way to get it)
6+ years ago :shock: :lol:
That felt pretty good to resolve. I left a note for @wmayer to please find to correct commit for reference.
Thanks @NormandC
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
wmayer
Site Admin
Posts: 14992
Joined: Thu Feb 19, 2009 10:32 am

Re: Migrating (soon to be deprecated) Drawing WB tickets to TechDraw WB

Postby wmayer » Mon Jan 30, 2017 8:48 am

I left a note for @wmayer to please find to correct commit for reference.
No way. I was never involved in the development of Techdraw and thus doesn't know much about internals. And I doubt that moving items graphically can be nailed down to a specific commit.
User avatar
Kunda1
Posts: 5927
Joined: Thu Jan 05, 2017 9:03 pm

Re: Migrating (soon to be deprecated) Drawing WB tickets to TechDraw WB

Postby Kunda1 » Mon Jan 30, 2017 11:28 am

wmayer wrote:
I left a note for @wmayer to please find to correct commit for reference.
No way. I was never involved in the development of Techdraw and thus doesn't know much about internals. And I doubt that moving items graphically can be nailed down to a specific commit.
The we perhaps should let sleeping dogs lie and close it discretely...or else we could give some recognition to some of the folks who made major contributions to it happening?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
yorik
Site Admin
Posts: 11577
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Migrating (soon to be deprecated) Drawing WB tickets to TechDraw WB

Postby yorik » Mon Jan 30, 2017 12:07 pm

Kunda1 wrote: issue #0001867 Use QtWebKit (QWebView) instead of QtSvg for DW drawing area
issue #0002629 Merge Drawing_dimensioning into Drawing
I think these two can be closed, because most probably no big undergroud work will be done on Drawing anymore, and now we have the addons repo which is a better place for Drawing_dimensioning, but Drawing is not dead yet.

The DXF-related ones could be gathered under one big "DXF support in techdraw" issue. DXF export doesn't exist in TechDraw yet. That would be a cool feature to work on, if anybody interested :)

For the others, I guess we should verify if the same problem exists/applies in techdraw...
User avatar
Kunda1
Posts: 5927
Joined: Thu Jan 05, 2017 9:03 pm

Re: Migrating (soon to be deprecated) Drawing WB tickets to TechDraw WB

Postby Kunda1 » Mon Jan 30, 2017 1:18 pm

yorik wrote:
Kunda1 wrote: issue #0001867 Use QtWebKit (QWebView) instead of QtSvg for DW drawing area
issue #0002629 Merge Drawing_dimensioning into Drawing
I think these two can be closed, because most probably no big undergroud work will be done on Drawing anymore, and now we have the addons repo which is a better place for Drawing_dimensioning, but Drawing is not dead yet.
So should I close these for sure?
yorik wrote: The DXF-related ones could be gathered under one big "DXF support in techdraw" issue. DXF export doesn't exist in TechDraw yet. That would be a cool feature to work on, if anybody interested :)
I've created issue #2882 for this. Please specify which DXF related bugs you want me to transfer? So far I see these:
issue #1727 API function Drawing.projectToDXF
issue #2620 Appears in both V0.16 and daily builds Drawing dxf export not working correctly
yorik wrote:For the others, I guess we should verify if the same problem exists/applies in techdraw...
Yes, lets.
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
Kunda1
Posts: 5927
Joined: Thu Jan 05, 2017 9:03 pm

Re: Migrating (soon to be deprecated) Drawing WB tickets to TechDraw WB

Postby Kunda1 » Mon Jan 30, 2017 8:18 pm

Lets talk about:
issue #2648: Changing the template in the Drawing-Workbench is not saved
Is it even a Drawing bug ?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Migrating (soon to be deprecated) Drawing WB tickets to TechDraw WB

Postby NormandC » Tue Jan 31, 2017 3:54 am

Yes, I confirm it's a bug. When I open someone else's FCStd file containing a Drawing page, there's always an error on the Page because the template isn't found.

But since:
  • There will likely be no further development on Drawing
  • TechDraw has an entirely new template system
I would tend to close issue #2648 as won't fix. Unless some developer manifests the desire to fix this bug and others? After all it's been mentioned that Drawing would be kept at least for the 0.17 release...
User avatar
wandererfan
Posts: 3149
Joined: Tue Nov 06, 2012 5:42 pm

Re: Migrating (soon to be deprecated) Drawing WB tickets to TechDraw WB

Postby wandererfan » Wed Feb 01, 2017 12:47 am

Sorry to take so long to get back to you @kunda1. Here is my take on your list. As others have mentioned, there are no actual plans to retire Drawing at this time.

0143 - Allow moving of views graphically on the page
- in TD
1494 - Add the current view in the orthographic projection tool
- in TD DPG dialog
1679 - Add an action to set orthographic projections as hints for a drawing page
- TD is drag and drop. x/y aren't generally set manually
1688 - Orthographic projection uses more digits behind decimal point for scale than shown in properties
- TD uses global decimals setting
1727 - API function Drawing.projectToDXF
- TD has no projectToDXF API function. no plans for one at this time.
1822 - Scale factor property in drawing page limited to one digit (sometime two)
- TD uses global decimal setting
1863 - Global preference for drawing line width
- Line style/weight preference changes are planned (related 1920,1921)
1867 - Use QtWebKit (QWebView) instead of QtSvg for DW drawing area
- not relevant to TD
1880 - Show/hide drawing template structure
- no plans for this. is it useful for something?
1920 - Drawing scale and stroke-dasharray
1921 - Drawing view hidden lines (style) and stroke-dasharray
- Line style/weight preference changes are planned (related 1863)
2004 - Performance regression when more (empty) drawing pages inserted
- empty pages do not seem to be an issue in TD. more non-empty pages will of course slow things down.
2123 - drawing workbench - enable rotation by 3 axis
- you can set the direction of a view to anything you want. Not really applicable to TD
2184 - Drawing template filenames for ISO7200 are numbered consecutively but corresponding files do not exist
- not an issue in TD. different handling of templates.
2283 - Drawing::FeatureViewPart LineWidth should not be scaled
- line widths are not scaled in TD
2620 - Appears in both V0.16 and daily builds Drawing dxf export not working correctly
- no plans for dxf export in TD at this time
2629 - Merge Drawing_dimensioning into Drawing
- no plans to merge Drawing_dimensioning into TD. Some intention to steal good ideas.
2648 - Changing the template in the Drawing-Workbench is not saved
- works in TD
2384 - Drawing dotted lines are inconsistent
- appears to be OCC hidden line issue. resolved in 7.1
2383 - Drawing lines missing or incorrect
- resolved in OCC 7.1
2427 - hidden lines
- resolved OCC 7.1

Hope this helps.
wf