Part Design Workbench icons aligned to guidelines
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Part Design Workbench icons aligned to guidelines
Sorry about the delay on these, I totally borked my system last weekend and had to divert hobby time to recovering everything.
As usual, old on left, new on right on light, gray and dark backgrounds at 16,24,32 64px. Comments and feedback welcome.
As usual, old on left, new on right on light, gray and dark backgrounds at 16,24,32 64px. Comments and feedback welcome.
Re: Part Design Workbench icons aligned to guidelines
Looking good and thanks for doing it.
Re: Part Design Workbench icons aligned to guidelines
No worries, thank you. Not many left to go now!triplus wrote:Looking good and thanks for doing it.
Re: Part Design Workbench icons aligned to guidelines
Great!
But sorry to be nitpicking, the perspective in a few icons is way off. Granted on at least one of them it was bad to begin with.
I doubled the following's resolution to better display what I mean.
PartDesign_Hole.svg Green oval at far right represents mostly correct shape. basically the ellipse shape's main axis should be horizontal.
See this screenshot I found in my Images folder. This is an isometric view. BTW this icon is still not visible in the PartDesign toolbar, it's for the Hole feature. There's code by eivindkvedalen for it in a separate branch, I hope it gets merged soon.
PartDesign_LinearPattern.svg If a sense of perspective was intended, the point where the green projection lines meet should be on the left side rather than the right side.
The same problem can be seen on the Mirrored and PolarPattern icons.
Overall I think they look much better! I like the new InvoluteGear.
But sorry to be nitpicking, the perspective in a few icons is way off. Granted on at least one of them it was bad to begin with.
I doubled the following's resolution to better display what I mean.
PartDesign_Hole.svg Green oval at far right represents mostly correct shape. basically the ellipse shape's main axis should be horizontal.
See this screenshot I found in my Images folder. This is an isometric view. BTW this icon is still not visible in the PartDesign toolbar, it's for the Hole feature. There's code by eivindkvedalen for it in a separate branch, I hope it gets merged soon.
PartDesign_LinearPattern.svg If a sense of perspective was intended, the point where the green projection lines meet should be on the left side rather than the right side.
The same problem can be seen on the Mirrored and PolarPattern icons.
Overall I think they look much better! I like the new InvoluteGear.
Re: Part Design Workbench icons aligned to guidelines
True, I have to admit I was trying to make the ellipse as big as possible rather than as accurate as possible. As a true round hole, the icon appears very similar to the pocket icon at smaller/normal sizes. I'll have another crack at it, but knowing it's a 0.17 icon, I might even put the hole in the front face rather than the top face to make it more distinguishable. Thanks for the feedback!NormandC wrote:basically the ellipse shape's main axis should be horizontal.
My focus here was on dropping that front line to give me more space for the small cubes - I agree it's messed up the perspective. I'll straighten up the rear line to make it more parallel to reduce the effect. Thanks for the spot.NormandC wrote:If a sense of perspective was intended, the point where the green projection lines meet should be on the left side rather than the right side.
Also thanks for taking the time to make the visuals, it really gets across the feedback very clearly and I know it can sometimes take a bit of time. Much appreciated.
Re: Part Design Workbench icons aligned to guidelines
Here's the new icons with the updated perspective. (I only show one of the pattern ones, but it's the same perspective change on all of them).NormandC wrote:But sorry to be nitpicking, the perspective in a few icons is way off.
I've now made the hole in the square before transfroming.
Unless there's any other feedback, I hope to submit a pull request tomorrow sometime. Robot workbench is almost done and should be ready for this weekend.
Re: Part Design Workbench icons aligned to guidelines
Cool!
Looks fine to me!
I'm getting used to the realigned icons so much that when in 0.16, I find the old icons weird
Looks fine to me!
I'm getting used to the realigned icons so much that when in 0.16, I find the old icons weird
Re: Part Design Workbench icons aligned to guidelines
Great!NormandC wrote:Looks fine to me!
Cool, out of interest though, despite weirdness, you can still orient yourself ok, right? I've been trying to make sure the new icons are still recognizable for people used to the old ones.NormandC wrote:I'm getting used to the realigned icons so much that when in 0.16, I find the old icons weird
Re: Part Design Workbench icons aligned to guidelines
Of course! I just meant that they look, well maybe "old fashioned". Even though I did design half a dozen of themagryson wrote:Cool, out of interest though, despite weirdness, you can still orient yourself ok, right?