I ran into the same issue - it's a bit of a pain but not too hard. Look at TaskPanel in PathDressupTagGui.py - it loads both task panels (the real one and one for getPoint) and switches between the two. It's still awkward from a UX perspective but it works.roivai wrote: ↑Fri Aug 04, 2017 9:13 amIt is great for that. But I still have one problem. As the getPoint() is implemented as task panel, the drilling task panel will be closed when the point selection is activated. I'm not sure if the panel changes are accepted or rejected when doing that? I suppose I should manually accept the panel when point selection is clicked?
I was thinking that, just wasn't sure about all the places where that isDrillable is used so I didn't dare to modify it. Adding a flag with a default would have worked of course.. Based on the name, the whole isDrillable is very drilling-specific, so it might make sense to implement it there, but for now it is that way..mlampert wrote: ↑Fri Aug 11, 2017 6:33 pmHad a quick look and it looks good. I only had one question, if it would make sense to implement the arc-detection in PathUtils.isDrillable and add a flag to enable/disable. OTOH, this behaviour is pretty drilling specific so it can also stay in PathDrilling.
I created a pull request. https://github.com/FreeCAD/FreeCAD/pull/924
awesome!roivai wrote: ↑Fri Aug 11, 2017 7:10 pmI created a pull request. https://github.com/FreeCAD/FreeCAD/pull/924