woot - thanks a lot man, that is awesome!kkremitzki wrote:
libocct 7.3 in Debian Testing
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
Be nice to others! Read the FreeCAD code of conduct!
libocct 7.3 in Debian Testing
- kkremitzki
- Veteran
- Posts: 2511
- Joined: Thu Mar 03, 2016 9:52 pm
- Location: Illinois
Re: libocct 7.3 in Debian Testing
Thanks! We should also be thankful to Tobias Frost, the co-maintainer of the package, who helped a lot especially with handling the symbols files and fixing build failures to make sure the package was available on all of Debian's SupportedArchitectures.
This also means that it's a lock for the next version of Ubuntu!
Re: libocct 7.3 in Debian Testing
Congrats Kris! (and Tobias)
I'm thinking we should not wait for it, and upgrade the PPA...kkremitzki wrote: ↑Mon Jul 02, 2018 11:45 am This also means that it's a lock for the next version of Ubuntu!
Re: libocct 7.3 in Debian Testing
Need to modify cmake though to check `/usr/include/occt` - currently it doesn't find the headers when trying to build. Unfortunately cmake is a black art for me...
Re: libocct 7.3 in Debian Testing
I can try to set up the occt repo as a mirror now that the CLA is not required.I'm thinking we should not wait for it, and upgrade the PPA...
"fight the good fight"
Re: libocct 7.3 in Debian Testing
I meant changing the cmake config file so it finds the OCC header files in /usr/include/occt
EDIT: I'm not being clear I'm afraid. I can build it for myself, but I can't submit a PR so others don't have to go through the configuration step - hope that makes sense.
Re: libocct 7.3 in Debian Testing
Thanks for the clarification.
Re: libocct 7.3 in Debian Testing
The magic happens here: https://github.com/FreeCAD/FreeCAD/blob ... .cmake#L36
We need to additionally search for occt if OpenCASCADE is not found, not sure how to do this.
https://cmake.org/cmake/help/v3.8/comma ... ighlight=i
EDIT: https://github.com/FreeCAD/FreeCAD/blob ... ke#L70-L75
Maybe?
Code: Select all
FIND_PATH(OCC_INCLUDE_DIR Standard_Version.hxx
/usr/include/opencascade
+ /usr/include/occt
/usr/local/include/opencascade
/opt/opencascade/include
/opt/opencascade/inc
)
FIND_LIBRARY(OCC_LIBRARY TKernel
/usr/lib
/usr/local/lib
/opt/opencascade/lib
)
endif(WIN32)
"fight the good fight"
Re: libocct 7.3 in Debian Testing
IMHO it would be much simpler to clone the Debian Science Team's opencascade repo instead. As wmayer wrote in another topic, some clean up of OCC sources is preferrable (sorry, don't remember the details). The Debian guys (Kurt and Tobias) already did that in the Debian repo.
Kurt patched it to enable exception handling, which will drastically reduce the number of crashes caused by OCC (which didn't happen as much prior to OCCT 7.0). We could clone the master branch and make minimal changes to it (in the debian folder).
The build recipe would no longer need to merge multiple branches.
In the future, when new OCCT versions are released, we could wait for the Debian guys to update their repo - and import it again in the same opencascade repo on Launchpad.
I think it would make the job easier in the long run.
The only problem is, AFAICT these new packages will still conflict with our libocct-7.2 packages. So we'll be in the same situation as when we switched from 7.1 to 7.2. We need to upgrade both stable and daily packages because many people have both installed on their systems (as I do). We need to force uninstall of libocct-7.2 packages.