[PR] [0.18-0.21_pre] Arch Stair - More Geometry Control? Profile Generator
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: Arch Stair - Control Length of Landing? More Geometry Control? + Bug Report ['pre-Pull Request' ?]
To the contrary, Yorik, Kunda etc. is spending their extra time just to help me to commit the few changes I manage to made
I always think Yorik can do the changes I made with 5 to 6 weeks, if useful at all, in a few days, or just in a few hours.
Anyway, I am having 2nd attempt to merge the HalfTurnLeft 'basic feature', hope it is found useful.
Join the camp, it's fun, when you have a gap having a rest not drafting designing.
I always think Yorik can do the changes I made with 5 to 6 weeks, if useful at all, in a few days, or just in a few hours.
Anyway, I am having 2nd attempt to merge the HalfTurnLeft 'basic feature', hope it is found useful.
Join the camp, it's fun, when you have a gap having a rest not drafting designing.
Re: Arch Stair - Control Length of Landing? More Geometry Control? + Bug Report ['pre-Pull Request' ?]
No problem! I'm happy to see someone wanting to spend some sweat on those stairs... They are a very tricky geometry problem
Re: [Merging Pull-request] Arch Stair - More Geometry Control? Bug Report
Thanks to all helps and comments here.
Yorik is so kind to accept a nos. of PR / 10 commits for the 0.18_pre
As I start playing the ArchStairs.py based on 0.17 Git13522, I have spent more than 1 week just to 'port' part of it to 0.18_pre the current master (Python newbie)
(another 1 week to read github / git related tutorials!)
ArchStairs.py 'Revision' in 0.18_pre
Now it seem there is no point of return for me as I think many of the 'features' are not fully done, not even for the 'latest' development I did (as of 1.8.2018)
So it would be buggy at the moment, and features half-done still in near future. Hope peoples still find it useful and comments welcome to improve it (codes from more peoples?)
Cheers.
Yorik is so kind to accept a nos. of PR / 10 commits for the 0.18_pre
As I start playing the ArchStairs.py based on 0.17 Git13522, I have spent more than 1 week just to 'port' part of it to 0.18_pre the current master (Python newbie)
(another 1 week to read github / git related tutorials!)
ArchStairs.py 'Revision' in 0.18_pre
- PR/Commits Accepted :
Up to around 10.7.2018 discussion in the thread - PR/Commits Proposed :
Up to around 16.7.2018 discussion in the thread - Commits in Pipeline :
Up to around 18.7.2018 discussion in the thread - Commits yet to be 'ported' to 0.18_pre :
About 4 more; Up to around 1.8.2018 discussion in the thread
Now it seem there is no point of return for me as I think many of the 'features' are not fully done, not even for the 'latest' development I did (as of 1.8.2018)
So it would be buggy at the moment, and features half-done still in near future. Hope peoples still find it useful and comments welcome to improve it (codes from more peoples?)
Cheers.
Re: [Pull-request Merged upto 1.8] Arch Stair - More Geometry Control? Bug Report
Now:
ArchStairs.py 'Revision' in 0.18_pre
ArchStairs.py 'Revision' in 0.18_pre
- PR/Commits Accepted :
Up to around 1.8.2018 discussion in the thread
https://forum.freecadweb.org/viewtopic. ... 70#p247814
Re: [PR Merged upto 1.8.2018] Arch Stair - More Geometry Control? Bug Report
Hello,
May I add my two cents to the discussion?
I would suggest some feature, cant implement it personally so far-just learning JS and Python-but as soon as I reach reasonable skills
I promise to help extend FC, starting with ArchModule first.
The thing is: maybe its only country specific feature but I suppose it may be very useful.
Aside of local regulations reg.stairs there is a 'rule of thumb' for it: 2h+s = 60-65
Meaning: h-height of a step, s-width/depth of a step and above formula '2h+s' should be fulfilled in range of 60-65.
Suppose dims are in centimeters. Above guarantee most usable and comfortable stairs in given conditions.
May I add my two cents to the discussion?
I would suggest some feature, cant implement it personally so far-just learning JS and Python-but as soon as I reach reasonable skills
I promise to help extend FC, starting with ArchModule first.
The thing is: maybe its only country specific feature but I suppose it may be very useful.
Aside of local regulations reg.stairs there is a 'rule of thumb' for it: 2h+s = 60-65
Meaning: h-height of a step, s-width/depth of a step and above formula '2h+s' should be fulfilled in range of 60-65.
Suppose dims are in centimeters. Above guarantee most usable and comfortable stairs in given conditions.
cheers,
Re: [PR Merged upto 1.8.2018] Arch Stair - More Geometry Control? Bug Report
Thanks for comment! and participation!zbigg wrote: ↑Thu Aug 30, 2018 6:29 am Hello,
May I add my two cents to the discussion?
I would suggest some feature, cant implement it personally so far-just learning JS and Python-but as soon as I reach reasonable skills
I promise to help extend FC, starting with ArchModule first.
The thing is: maybe its only country specific feature but I suppose it may be very useful.
Aside of local regulations reg.stairs there is a 'rule of thumb' for it: 2h+s = 60-65
Meaning: h-height of a step, s-width/depth of a step and above formula '2h+s' should be fulfilled in range of 60-65.
Suppose dims are in centimeters. Above guarantee most usable and comfortable stairs in given conditions.
I am also python newbie, 1st attempt to write something for Arch!
(With help from York and all other people here)
I think York / FC already had a "BlondelRatio" - "The Blondel ratio indicates comfortable stairs and should be between 62 and 64cm or 24.5 and 25.5in")) - Check the property box.
Code: Select all
obj.BlondelRatio = obj.RiserHeight.Value*2+obj.TreadDepth.Value
Do help!
Re: [PR Merged upto 1.8.2018] Arch Stair - More Geometry Control? Bug Report
Great! That should do the job. /Although its an option anyway )) /
cheers,
Re: [PR] Arch Stair - More Geometry Control? Bug Report
Hi, implemented different width for the (mult-edge) landing (as no much idea how other features should be done )
A new Property 'Width of Landing' is added
It is a list of width which set the width of different 'edge' of a Landing
- this is for 2nd edge and after, 1st edge follow original Width property
- 'default' setting in original Width property would be used if a '0' (zero) setting is made for any 'edge'
Below ArchStairs.py is for 0.18_pre
Version for 0.17 is available if anyone is intertested)
It is implemented with App::PropertyFloatList ... as App::PropertyLengthList is not yet available
See if there is any comments before a PR is being made.
Thanks.
A new Property 'Width of Landing' is added
It is a list of width which set the width of different 'edge' of a Landing
- this is for 2nd edge and after, 1st edge follow original Width property
- 'default' setting in original Width property would be used if a '0' (zero) setting is made for any 'edge'
Below ArchStairs.py is for 0.18_pre
Version for 0.17 is available if anyone is intertested)
It is implemented with App::PropertyFloatList ... as App::PropertyLengthList is not yet available
See if there is any comments before a PR is being made.
Thanks.
- Attachments
-
- ArchStairs.py
- (51.62 KiB) Downloaded 54 times
Re: [PR] Arch Stair - More Geometry Control? Bug Report
Some more images, landing & flight in different width:-
Re: [PR] Arch Stair - More Geometry Control? Bug Report
ArchPipe objects named as "Rail"