Freecad 0.17 - Pad up to face - Datum Plane is invalid

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
vectronic
Posts: 23
Joined: Sun Feb 18, 2018 9:44 pm

Re: Freecad 0.17 - Pad up to face - Datum Plane is invalid

Postby vectronic » Sun Sep 02, 2018 8:28 pm

@freedman, just checking in if you ended up raising this as a bug?
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Freecad 0.17 - Pad up to face - Datum Plane is invalid

Postby NormandC » Sun Sep 02, 2018 8:37 pm

@vectronic

I wish you had attached your FreeCAD file showing the issue. I believe this was reported in the past, but I need to make sure with your file.
TheMarkster
Posts: 634
Joined: Thu Apr 05, 2018 1:53 am

Re: Freecad 0.17 - Pad up to face - Datum Plane is invalid

Postby TheMarkster » Mon Sep 03, 2018 5:20 am

NormandC wrote:
Sun Sep 02, 2018 8:37 pm
@vectronic

I wish you had attached your FreeCAD file showing the issue. I believe this was reported in the past, but I need to make sure with your file.
Is this the same thing Werner fixed recently? padding to a datum plane with pad to face? I think he said there was a bug that causing the dimension to be zero.
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Freecad 0.17 - Pad up to face - Datum Plane is invalid

Postby NormandC » Mon Sep 03, 2018 8:11 am

No, I believe this is the same bug as issue #1190.
wmayer
Site Admin
Posts: 14288
Joined: Thu Feb 19, 2009 10:32 am

Re: Freecad 0.17 - Pad up to face - Datum Plane is invalid

Postby wmayer » Mon Sep 03, 2018 8:16 am

At the least the issue the OP has reported is fixed.
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Freecad 0.17 - Pad up to face - Datum Plane is invalid

Postby NormandC » Mon Sep 03, 2018 8:21 am

wmayer
Site Admin
Posts: 14288
Joined: Thu Feb 19, 2009 10:32 am

Re: Freecad 0.17 - Pad up to face - Datum Plane is invalid

Postby wmayer » Mon Sep 03, 2018 11:29 am

NormandC wrote:
Mon Sep 03, 2018 8:21 am
Unfortunately, with a limitation: https://freecadweb.org/tracker/view.php?id=3177#c11687
I only have fixed the case where the padding fails if the sketch is the first element in the body and a datum is used to limit the pad. However, I added one small extension too: the limiting plane doesn't need to be a plane but it suffices to be planar which e.g. includes a B-spline surface if all its poles lie on a plane.

I did not pay any attention to use a line, a point as limiting element or that the datum plane does not need to be parallel. When looking at the old code then there is an explicit check that the datum plane must be parallel to the sketch. I did not modify this behaviour.
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Freecad 0.17 - Pad up to face - Datum Plane is invalid

Postby NormandC » Mon Sep 03, 2018 8:58 pm

Thanks for the info. Should I create a separate Mantis report about it then? I really see no logical reason for purposely making this limitation.
vectronic
Posts: 23
Joined: Sun Feb 18, 2018 9:44 pm

Re: Freecad 0.17 - Pad up to face - Datum Plane is invalid

Postby vectronic » Mon Sep 03, 2018 9:56 pm

Hello,

Now with added sample file (forgot that might be useful!)

If you change the "sticks_pad" pad parameters from "Up to face" to "Dimension" you will see a second item from the "sticks_sketch" sketch appear.

I realise now that this is different to the OP issue. Didn't mean to hijack the thread - still learning concepts in FreeCAD.

So I agree the issue I am experiencing is not

0003177: Part Design Pad should allow besides "Up to face" something like "Up to plane" as well

But can't say whether it is the same as:

0001190: Polar pattern doesn't obey UpToFirst/UpToLast/UpToFace pad features


Just tried this with:

OS: Mac OS X
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.13541 (Git)
Build type: Release
Branch: releases/FreeCAD-0-17
Hash: 9948ee4f1570df9216862a79705afb367b2c6ffb
Python version: 2.7.14
Qt version: 5.10.1
Coin version: 4.0.0a
OCC version: 7.2.0
Locale: English/UnitedKingdom (en_GB)
Attachments
test.FCStd
(36.53 KiB) Downloaded 11 times
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Freecad 0.17 - Pad up to face - Datum Plane is invalid

Postby NormandC » Mon Sep 03, 2018 10:33 pm

Thanks for providing your file. Sorry I was mistaken, I believe your issue is not related to issue #1190 which relates to Polar Pattern, this is not the case here.

This is a separate, third issue that does not depend on the datum plane: even if you select a face on the body, it fails to pad the second cylinder.

BTW is there a specific reason why the second set of circles is not constrained to the horizontal sketch axis, but is on a line only angled 0.0165833 degrees from the horizontal? This angle value is so negligible as to suggest some error...