make an svg icon from png for a FEM tool

A forum for research and development of the user interface of FreeCAD

Moderator: agryson

User avatar
bitacovir
Posts: 673
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: make an svg icon from png for a FEM tool

Postby bitacovir » Thu Sep 20, 2018 11:09 pm

bernd wrote:
Thu Sep 20, 2018 7:33 pm
Kunda1 wrote:
Thu Sep 20, 2018 5:21 pm
Github
wow I did not know we have got such a great documantation :D Will you give it a try bitacovir? If you encounter any problems feel free to ask just here in this topic. You will be a FreeCAD developer after the merge :mrgreen: If not just drop a line, I will include it in my next PR.

bernd
Ok. I'll try. Ill let you know if I change my mind.
::bitacovir::
===================================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

My Blog
Mini Airflow Tunnel Project
User avatar
Kunda1
Posts: 5120
Joined: Thu Jan 05, 2017 9:03 pm

Re: make an svg icon from png for a FEM tool

Postby Kunda1 » Fri Sep 21, 2018 12:23 am

bitacovir wrote:
Thu Sep 20, 2018 11:09 pm
bernd wrote:
Thu Sep 20, 2018 7:33 pm
Kunda1 wrote:
Thu Sep 20, 2018 5:21 pm
Github
wow I did not know we have got such a great documantation :D Will you give it a try bitacovir? If you encounter any problems feel free to ask just here in this topic. You will be a FreeCAD developer after the merge :mrgreen: If not just drop a line, I will include it in my next PR.

bernd
Ok. I'll try. Ill let you know if I change my mind.
right on @bitacovir ;)
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
bernd
Posts: 8204
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: make an svg icon from png for a FEM tool

Postby bernd » Fri Sep 21, 2018 4:25 am

Kunda1 wrote:
Fri Sep 21, 2018 12:23 am
bitacovir wrote:
Thu Sep 20, 2018 11:09 pm
bernd wrote:
Thu Sep 20, 2018 7:33 pm
Kunda1 wrote:
Thu Sep 20, 2018 5:21 pm
Github
wow I did not know we have got such a great documantation :D Will you give it a try bitacovir? If you encounter any problems feel free to ask just here in this topic. You will be a FreeCAD developer after the merge :mrgreen: If not just drop a line, I will include it in my next PR.

bernd
Ok. I'll try. Ill let you know if I change my mind.
right on @bitacovir ;)
yeah bitacovir2FreeCADdeveloper :D
User avatar
bitacovir
Posts: 673
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: make an svg icon from png for a FEM tool

Postby bitacovir » Tue Sep 25, 2018 3:44 am

bernd wrote:
Fri Sep 21, 2018 4:25 am
yeah bitacovir2FreeCADdeveloper :D
Well. I opened a Github account and installed the Gitkraken software for windows. Also, I followed the instructions from https://www.freecadweb.org/wiki/Develop ... _GitKraken
Now, I have cloned the official repo and have set up my upstream remote repo.

Now. What are the steps to make the Pull Request?
I see pull request buttons on github platform, in the Gitkraken interface and there is this FreeCAD forum Pull Requests.
what protocol should I follow to do the pull request for this graphic icon?

PD: in https://www.freecadweb.org/wiki/Develop ... _GitKraken Point 7) the upstream address is wrong.
::bitacovir::
===================================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

My Blog
Mini Airflow Tunnel Project
User avatar
Kunda1
Posts: 5120
Joined: Thu Jan 05, 2017 9:03 pm

Re: make an svg icon from png for a FEM tool

Postby Kunda1 » Tue Sep 25, 2018 10:09 am

bitacovir wrote:
Tue Sep 25, 2018 3:44 am
bernd wrote:
Fri Sep 21, 2018 4:25 am
yeah bitacovir2FreeCADdeveloper :D
Well. I opened a Github account and installed the Gitkraken software for windows. Also, I followed the instructions from https://www.freecadweb.org/wiki/Develop ... _GitKraken
Now, I have cloned the official repo and have set up my upstream remote repo.

Now. What are the steps to make the Pull Request?
I see pull request buttons on github platform, in the Gitkraken interface and there is this FreeCAD forum Pull Requests.
what protocol should I follow to do the pull request for this graphic icon?

PD: in https://www.freecadweb.org/wiki/Develop ... _GitKraken Point 7) the upstream address is wrong.
Fixed the wiki page. Thanks @bitacovir

I made a quick and dirty reference on how to make PRs through Gitkraken at
Developing_FreeCAD_with_GitKraken#Making_Pull_Requests
I will refine it later. Hope that helps.
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
bitacovir
Posts: 673
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: make an svg icon from png for a FEM tool

Postby bitacovir » Thu Sep 27, 2018 2:05 pm

Kunda1 wrote:
Tue Sep 25, 2018 10:09 am
I made a quick and dirty reference on how to make PRs through Gitkraken at
Developing_FreeCAD_with_GitKraken#Making_Pull_Requests
I will refine it later. Hope that helps.
Thanks @Kunda1
Now. I have a question. Should I make a new branch for a pull request? Even if I'm not doing any code?
I mean, bernd asked me to make the PR with a reference to this forum topic, where the svg file is. I understand I must write an explanation and the link to here in the description of the PR's dialog box. Should this description be enough? No problem with an empty branch?
I just don't want to do something that the developer community could find annoying.
::bitacovir::
===================================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

My Blog
Mini Airflow Tunnel Project
User avatar
Kunda1
Posts: 5120
Joined: Thu Jan 05, 2017 9:03 pm

Re: make an svg icon from png for a FEM tool

Postby Kunda1 » Thu Sep 27, 2018 3:38 pm

bitacovir wrote:
Thu Sep 27, 2018 2:05 pm
Kunda1 wrote:
Tue Sep 25, 2018 10:09 am
I made a quick and dirty reference on how to make PRs through Gitkraken at
Developing_FreeCAD_with_GitKraken#Making_Pull_Requests
I will refine it later. Hope that helps.
Thanks @Kunda1
Now. I have a question. Should I make a new branch for a pull request? Even if I'm not doing any code?
The simple answer is, Yes. This is the convention used when someone wants to contribute to a git version control system project that you will encounter. Only those that have permission to merge code in to the master branch directly. Everyone else submits their contributions in a separate branch (that is branched off of the 'master' branch, or whatever the project deem as 'master').
bitacovir wrote:
Thu Sep 27, 2018 2:05 pm
I mean, bernd asked me to make the PR with a reference to this forum topic, where the svg file is. I understand I must write an explanation and the link to here in the description of the PR's dialog box. Should this description be enough? No problem with an empty branch?
So you make a branch, checkout that branch, make the changes to the source (modify the code, add files, remove files...whatever) and then you submit the PR. As for the summary, You can make a reference to this forum thread (if you can link directly to the most informative portion of the thread is a nice consideration for the core devs time) and maybe share some summarizing words what the necessity of the PR is.
bitacovir wrote:
Thu Sep 27, 2018 2:05 pm
I just don't want to do something that the developer community could find annoying.
I know the feeling. I've stepped on some folks toes here and ignorantly overlooked contribution norms. In general what is nice in this community is that folks are reasonable and cool. So if you make a mistake, you'll most likely be told and then shown how to remedy it. This is how we learn. I think it's great you're contributing which is the spirit of FOSS.
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
bernd
Posts: 8204
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: make an svg icon from png for a FEM tool

Postby bernd » Thu Sep 27, 2018 4:54 pm

- make a new branch
- make a commit wich adds the new icon
- make a PR with this branch

sure you gone make no code, but a new icon is some development since icons are part of the code ... BTW only if you make a commit in a separate branch and make a PR with this you will be a developer.

As an example see:

PR:
https://github.com/FreeCAD/FreeCAD/pull/1691

the branch on the developers github
https://github.com/furti/FreeCAD/commit ... r-all-icon

the commit in FreeCAD after the merge:
git commit f054788
User avatar
bitacovir
Posts: 673
Joined: Sat Apr 19, 2014 6:23 am
Contact:

Re: make an svg icon from png for a FEM tool

Postby bitacovir » Sat Sep 29, 2018 2:58 am

bernd wrote:
Thu Sep 27, 2018 4:54 pm
- make a new branch
- make a commit wich adds the new icon
- make a PR with this branch

sure you gone make no code, but a new icon is some development since icons are part of the code ... BTW only if you make a commit in a separate branch and make a PR with this you will be a developer.

As an example see:

PR:
https://github.com/FreeCAD/FreeCAD/pull/1691

the branch on the developers github
https://github.com/furti/FreeCAD/commit ... r-all-icon

the commit in FreeCAD after the merge:
git commit f054788
It's not working. When I click on Create Pull Request button, it shows a message saying "Fail to create a Pool Request. No commits between FreeCAD:master and bitacovir:new-fem-svgicon-branch"

But I made the commit in my new-fem-svgicon-branch (see screenshot)
gitkraken_2018-09-28_23-58-51.png
gitkraken_2018-09-28_23-58-51.png (194.54 KiB) Viewed 182 times
::bitacovir::
===================================
One must be absolutely modern.
Arthur Rimbaud (A Season in Hell -1873)

My Blog
Mini Airflow Tunnel Project
User avatar
Kunda1
Posts: 5120
Joined: Thu Jan 05, 2017 9:03 pm

Re: make an svg icon from png for a FEM tool

Postby Kunda1 » Sat Sep 29, 2018 3:05 am

bitacovir wrote:
Sat Sep 29, 2018 2:58 am
It's not working. When I click on Create Pull Request button, it shows a message saying "Fail to create a Pool Request. No commits between FreeCAD:master and bitacovir:new-fem-svgicon-branch"

But I made the commit in my new-fem-svgicon-branch (see screenshot)
gitkraken_2018-09-28_23-58-51.png
Image
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features