0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
Post Reply
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Post by abdullah »

Moderators: Not sure where you would like to have this. Feel free to move it to another subforum.

I write to ask for user input regarding this feature. Something is telling me that is not working as expected, but I am not sure what I would like to have.
FilletArcOfConics.gif
FilletArcOfConics.gif (85.07 KiB) Viewed 2003 times
Does this look like what is requested?
GeneFC
Veteran
Posts: 5373
Joined: Sat Mar 19, 2016 3:36 pm
Location: Punta Gorda, FL

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Post by GeneFC »

Not sure what was "requested", but that would be a nice feature.

I have always made that sort of shape with three arcs connected using end-to-end tangency. This new method would be easier.

Gene
RogerK
Posts: 28
Joined: Thu Oct 04, 2018 6:25 pm
Location: Elsau

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Post by RogerK »

Hi abdullah

In my point of view it's exact the expected result when you filet two arcs. The result is similar as when you do this with just two lines. Great that you have implemented this.

What other result can you imagine, when you filet two arcs? What makes you worry about your current implementation?


Kind regards

Roger
abdullah
Veteran
Posts: 4935
Joined: Sun May 04, 2014 3:16 pm
Contact:

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Post by abdullah »

GeneFC wrote: Tue Oct 16, 2018 3:52 pm Not sure what was "requested", but that would be a nice feature.
RogerK wrote: Tue Oct 16, 2018 3:54 pm In my point of view it's exact the expected result when you filet two arcs. The result is similar as when you do this with just two lines. Great that you have implemented this.
I am not sure exactly what is requested. I am not sure this is the way (tm). Curves are trickier than segments, as curvature keeps changing. It also admits a plurality of intersections. I am struggling to consistently get the same result. But it is good to see that what is shown is what is expected.
RogerK wrote: Tue Oct 16, 2018 3:54 pm What other result can you imagine, when you filet two arcs? What makes you worry about your current implementation?
One initial problem I had was related to the fact that curvature keeps changing, so it is very relevant where you click the segments. I had also to restrict to curves that (if extended) intersect.

As of now, it does not work segment with arc of conic. It does not work with B-splines. Sometimes I am still getting a very wrong result. See:
FilletArcOfConics2_ok.gif
FilletArcOfConics2_ok.gif (250.55 KiB) Viewed 1985 times
FilletArcOfConics2_fail.gif
FilletArcOfConics2_fail.gif (254.3 KiB) Viewed 1985 times
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Post by Kunda1 »

ooh, I bet @joel_graff (who's working on the Transportation Engineering WB) would dig this thread
Joel_graff wrote:
Last edited by Kunda1 on Tue Oct 16, 2018 5:43 pm, edited 1 time in total.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
chrisb
Veteran
Posts: 53930
Joined: Tue Mar 17, 2015 9:14 am

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Post by chrisb »

Does it work as well with just clicking the corner?
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
Joel_graff
Veteran
Posts: 1949
Joined: Fri Apr 28, 2017 4:23 pm
Contact:

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Post by Joel_graff »

That's really awesome. Nice that it's integrated into the existing tool, too - eliminates the need for geometry checking.

I wrote a monstrous amount of python code to achieve this same effect, but my results were exact. Still, this is a lot easier than anything I'd imagined.

Thanks for the great work!
FreeCAD Trails workbench for transportation engineering: https://www.github.com/joelgraff/freecad.trails

pivy_trackers 2D coin3D library: https://www.github.com/joelgraff/pivy_trackers
User avatar
bejant
Veteran
Posts: 6075
Joined: Thu Jul 11, 2013 3:06 pm

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Post by bejant »

abdullah wrote: Tue Oct 16, 2018 2:56 pm Does this look like what is requested?
Yes, you nailed it - thanks abdullah!

To me it looks like the size of the Fillet is determined by where the user clicks on the two existing arcs (maybe you alluded to that in your next post) - is that right?


abdullah wrote: Tue Oct 16, 2018 4:47 pm It also admits a plurality of intersections.
In the event that multiple possible intersections exist, I think the user would expect the Fillet to be created near to where the cursor picks happened on the parent curves.


abdullah wrote: Tue Oct 16, 2018 4:47 pm Sometimes I am still getting a very wrong result.
I wonder, do the directions in which the Arc and Arc Of Ellipse were originally created (clockwise or anti-clockwise) come into play there?

Thanks again abdullah; it's good to see you back coding again!
chrisb
Veteran
Posts: 53930
Joined: Tue Mar 17, 2015 9:14 am

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Post by chrisb »

bejant wrote: Tue Oct 16, 2018 10:47 pm To me it looks like the size of the Fillet is determined by where the user clicks on the two existing arcs (maybe you alluded to that in your next post) - is that right?
Thats how it works with straight lines.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
User avatar
bejant
Veteran
Posts: 6075
Joined: Thu Jul 11, 2013 3:06 pm

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Post by bejant »

Yes, but I'm asking about the curves...
Post Reply