0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
chrisb
Posts: 18821
Joined: Tue Mar 17, 2015 9:14 am

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby chrisb » Sun Oct 21, 2018 8:12 am

You don't have to do all the testing yourself. As soon as you are confident enough, roll it out and wait for the feedback. From the echo here, there are enough testers around.
User avatar
bejant
Posts: 5933
Joined: Thu Jul 11, 2013 3:06 pm

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby bejant » Sun Oct 21, 2018 2:44 pm

abdullah wrote:
Sun Oct 21, 2018 6:49 am
Look at the endpoint of the major axis of the left ellipse. It does move slightly when applying the tangency.
I don't see the movement either...

I don't think it's unreasonable for an unconstrained endpoint to move a tiny bit after the Fillet is applied, and I'm pretty sure that behavior existed before. I think your changes should be merged, and we can report back to you regarding any issues we might find.
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby abdullah » Tue Oct 23, 2018 3:22 pm

chrisb wrote:
Sun Oct 21, 2018 8:12 am
You don't have to do all the testing yourself. As soon as you are confident enough, roll it out and wait for the feedback. From the echo here, there are enough testers around.
bejant wrote:
Sun Oct 21, 2018 2:44 pm
I don't think it's unreasonable for an unconstrained endpoint to move a tiny bit after the Fillet is applied, and I'm pretty sure that behavior existed before. I think your changes should be merged, and we can report back to you regarding any issues we might find.
Ok. I see you all are eager. I am going to do some tests and will ask Werner about when to merge.
Fillet_BSpline.gif
Fillet_BSpline.gif (143.52 KiB) Viewed 216 times
Fillet_LinesandConics.gif
Fillet_LinesandConics.gif (271.71 KiB) Viewed 216 times
chrisb
Posts: 18821
Joined: Tue Mar 17, 2015 9:14 am

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby chrisb » Tue Oct 23, 2018 6:12 pm

You shouldn't take the moving too serious, things move all the time in sketcher as long as the sketch is not fully constraint. I see that it would be nice not to move in this case, but there is no need for it.
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby abdullah » Wed Oct 24, 2018 6:24 am

chrisb wrote:
Tue Oct 23, 2018 6:12 pm
You shouldn't take the moving too serious, things move all the time in sketcher as long as the sketch is not fully constraint. I see that it would be nice not to move in this case, but there is no need for it.
I am no longer considering moving as an issue. B-Splines will move, but I think this is normal.

I am trying to clean up the code and make some meaningful messages for the user, as:
Fillet_Exception_notification.gif
Fillet_Exception_notification.gif (205.33 KiB) Viewed 193 times
User avatar
Kunda1
Posts: 5763
Joined: Thu Jan 05, 2017 9:03 pm

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby Kunda1 » Wed Oct 24, 2018 10:59 am

abdullah wrote:
Wed Oct 24, 2018 6:24 am
I am trying to clean up the code and make some meaningful messages for the user
@abdullah is there a way to tell Qt to create a popup that doesn't cease operations till you press 'OK' ?
Instead it either stays open and less conspicuous (to the side) or even dissolves after a certain time threshold is reached ?
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby abdullah » Fri Oct 26, 2018 2:09 pm

Kunda1 wrote:
Wed Oct 24, 2018 10:59 am
abdullah wrote:
Wed Oct 24, 2018 6:24 am
I am trying to clean up the code and make some meaningful messages for the user
@abdullah is there a way to tell Qt to create a popup that doesn't cease operations till you press 'OK' ?
Instead it either stays open and less conspicuous (to the side) or even dissolves after a certain time threshold is reached ?
Not to my knowledge.

Another task for the idea of the "clipper"-alike assistant. ;)
User avatar
Kunda1
Posts: 5763
Joined: Thu Jan 05, 2017 9:03 pm

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby Kunda1 » Fri Oct 26, 2018 3:39 pm

abdullah wrote:
Fri Oct 26, 2018 2:09 pm
Another task for the idea of the "clipper"-alike assistant.
@abdullah Did you ever hear/see the tragic story of what happened to Clippy? :lol:
https://i.gifer.com/Axob.gif (it's an animated gif and I wanted to save data for mobile users)
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: 0001304: Allow Sketcher to Fillet Arcs, Not Only Lines

Postby abdullah » Fri Oct 26, 2018 5:08 pm

Kunda1 wrote:
Fri Oct 26, 2018 3:39 pm
abdullah wrote:
Fri Oct 26, 2018 2:09 pm
Another task for the idea of the "clipper"-alike assistant.
@abdullah Did you ever hear/see the tragic story of what happened to Clippy? :lol:
https://i.gifer.com/Axob.gif (it's an animated gif and I wanted to save data for mobile users)
Poor thing...

It seems you trying to make a fillet...

we could always task "Rocky" with it.