Release of 0.18

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
User avatar
yorik
Site Admin
Posts: 12064
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels, Belgium
Contact:

Re: Release of 0.18

Postby yorik » Tue Jan 01, 2019 3:00 pm

on my qt4 version it displays the same problem as Normand. But on qt5 apparently everything is fine for everybody, so probably not worth putting much effort into this...
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Release of 0.18

Postby NormandC » Wed Jan 02, 2019 8:33 pm

I think it's been mentioned here somewhere in this 28-page long topic, but I really, really miss the old Qt 4 color picker!!! :cry:

In Qt 5, its usability has considerably plummeted. :?

Do you think there's any way to get the original color picker back?
Attachments
FC_Qt5_Color_picker_01.png
FC_Qt5_Color_picker_01.png (37.54 KiB) Viewed 954 times
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Release of 0.18

Postby NormandC » Wed Jan 02, 2019 10:31 pm

Time to update these, guys! :)

src/Main/MainCmd.cpp

Code: Select all

const char sBanner[] = "(c) Juergen Riegel, Werner Mayer, Yorik van Havre 2001-2018\n"\
src/Main/MainGui.cpp

Code: Select all

const char sBanner[] = "\xc2\xa9 Juergen Riegel, Werner Mayer, Yorik van Havre 2001-2018\n"\
src/Main/FreeCADGuiPy.cpp

Code: Select all

 App::Application::Config()["CopyrightInfo"] = "\xc2\xa9 Juergen Riegel, Werner Mayer, Yorik van Havre 2001-2018\n";
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Release of 0.18

Postby NormandC » Wed Jan 02, 2019 11:44 pm

NormandC wrote:
Wed Jan 02, 2019 8:33 pm
I think it's been mentioned here somewhere in this 28-page long topic, but I really, really miss the old Qt 4 color picker!!! :cry:
Just stumbled upon this: http://doc.qt.io/qt-5/qcolordialog.html#details

Why doesn't the color chooser in FreeCAD look like the one in the Qt5 doc, which looks identical to what FreeCAD/Qt4 has?

Image
User avatar
yorik
Site Admin
Posts: 12064
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels, Belgium
Contact:

Re: Release of 0.18

Postby yorik » Thu Jan 03, 2019 2:00 pm

NormandC wrote:
Wed Jan 02, 2019 10:31 pm
Time to update these, guys! :)

src/Main/MainCmd.cpp

Code: Select all

const char sBanner[] = "(c) Juergen Riegel, Werner Mayer, Yorik van Havre 2001-2018\n"\

src/Main/MainGui.cpp

Code: Select all

const char sBanner[] = "\xc2\xa9 Juergen Riegel, Werner Mayer, Yorik van Havre 2001-2018\n"\

src/Main/FreeCADGuiPy.cpp

Code: Select all

App::Application::Config()["CopyrightInfo"] = "\xc2\xa9 Juergen Riegel, Werner Mayer, Yorik van Havre 2001-2018\n";
One thing is crystal clear, @NormandC is at the verge of doing his first PR and becoming a full-fledged FreeCAD developer...

Personally I would vote for changing this text to something like this:

Code: Select all

(c) Juergen Riegel, Werner Mayer and the FreeCAD community 2001-2019
wmayer
Site Admin
Posts: 16647
Joined: Thu Feb 19, 2009 10:32 am

Re: Release of 0.18

Postby wmayer » Thu Jan 03, 2019 3:19 pm

NormandC wrote:
Wed Jan 02, 2019 11:44 pm
Just stumbled upon this: http://doc.qt.io/qt-5/qcolordialog.html#details

Why doesn't the color chooser in FreeCAD look like the one in the Qt5 doc, which looks identical to what FreeCAD/Qt4 has?
git commit 8358d7f876
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Release of 0.18

Postby NormandC » Fri Jan 04, 2019 4:08 am

Thanks Werner! I didn't know the stripped down color chooser was the native one rather than the Qt one... Considering I'm using GNOME Shell, I should have known better :roll:

yorik wrote:
Thu Jan 03, 2019 2:00 pm
One thing is crystal clear, @NormandC is at the verge of doing his first PR and becoming a full-fledged FreeCAD developer...
Funny, but that won't happen anytime soon as long as there is no clear "Making PRs for dummies" step-by-step summary. The topic about it is too damn long and confusing for someone who still struggles with Git like me.
Last edited by NormandC on Fri Jan 04, 2019 4:34 am, edited 1 time in total.
User avatar
NormandC
Posts: 18534
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Release of 0.18

Postby NormandC » Fri Jan 04, 2019 4:33 am

@Yorik

Friendly reminder, there have been a few modified and some new text strings (in Part wb) added in the past week, so they'll have to be uploaded to Crowdin then translated. I think text strings should not change anymore, what will be missing are of course the FEM menu entries in Crowdin, unless you find the solution...

Thanks!

Over the Holidays I proofread the French translations for Part, PartDesign and Sketcher, I left just a few strings I was not sure about. Didn't have time for other workbenches, I must admit I'd have no clue for Path and FEM.
User avatar
yorik
Site Admin
Posts: 12064
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels, Belgium
Contact:

Re: Release of 0.18

Postby yorik » Fri Jan 04, 2019 1:01 pm

Ok, doing a crowdin upload/download cycle now
User avatar
yorik
Site Admin
Posts: 12064
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels, Belgium
Contact:

Re: Release of 0.18

Postby yorik » Fri Jan 04, 2019 5:44 pm

The credits page in the about dialog is updated.