mumme wrote: ↑
Thu Jan 17, 2019 5:45 am
wmayer wrote: ↑
Wed Jan 16, 2019 1:14 pm
I rebased your branch and open a merge request: issue #3774
It obviously needs more testing before merge.
For instance the webkit fallback isn't really tested by me.
Is it still the preferred method to open a merge bug report before all kinks are ironed out?
(Still trying to learn, how to do it right..)
OK, it's good to know that it requires some testing.
Well, it makes sense to open a PR only then once you think you are done. It doesn't necessarily mean that everything works 100% correctly but that's why we do at least some testing to see if it causes problems.
Btw, since you are on github anyway it's best to make a PR there rather than opening a merge request ticket in mantis. I only did it in mantis because it'll be merged after v0.18 and I don't like to have too many pending requests in the queue.