Datum Plane orientation request

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
ppemawm
Veteran
Posts: 1240
Joined: Fri May 17, 2013 3:54 pm
Location: New York NY USA

Re: Datum Plane orientation request

Post by ppemawm »

Zolko wrote: Thu Jan 24, 2019 7:17 pm Looks like an OCC bug
OK, thanks for sorting this out.
"It is a poor workman who blames his tools..." ;)
User avatar
Zolko
Veteran
Posts: 2213
Joined: Mon Dec 17, 2018 10:02 am

Re: Datum Plane orientation request

Post by Zolko »

chrisb wrote: Tue Jan 22, 2019 2:17 pm Could you give some preferably simple or very simple examples which show the power of LCSs?
another demo, somewhat more complicated. All parametric of course. I don't see how this could be done without LCS, with Datum Planes may-be, but then you don't see which way the plane is oriented, which is actually the subject of this thread.

LCS_demo6.png
LCS_demo6.png (327.01 KiB) Viewed 2672 times
Attachments
LCS_demo6.fcstd
(51.91 KiB) Downloaded 85 times
try the Assembly4 workbench for FreCAD — tutorials here and here
realthunder
Veteran
Posts: 2190
Joined: Tue Jan 03, 2017 10:55 am

Re: Datum Plane orientation request

Post by realthunder »

Zolko wrote: Thu Jan 24, 2019 7:17 pm Looks like an OCC bug: I tested my demo file and yours, and mine always works on OCC 7.3, and never on anything else, and yours always works on anything except 7.3
Yes, I think we are going to have a hard time on transition from older OCC to 7.3. It is not that 7.3 is buggy, but it actually fixed some bug in previous versions, but as a result (somewhat) breaks backward compatibility of the index based topological name. For example, see here and here.
Try Assembly3 with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
User avatar
ppemawm
Veteran
Posts: 1240
Joined: Fri May 17, 2013 3:54 pm
Location: New York NY USA

Re: Datum Plane orientation request

Post by ppemawm »

Zolko wrote: Thu Jan 24, 2019 10:27 pm I don't see how this could be done without LCS
Each section sketch can be attached directly to Sketch exactly like the LCS and edited parametrically. A sketch has its own 'LCS' defined by its attachment properties even though the axes are not visible after the sketch is closed. So, in this instance, the LCS's seem redundant.

What advantage am I missing again other than the visibility of the LCS?
"It is a poor workman who blames his tools..." ;)
chrisb
Veteran
Posts: 53786
Joined: Tue Mar 17, 2015 9:14 am

Re: Datum Plane orientation request

Post by chrisb »

Zolko, thanks for showing these examples. LCSs have what I had missed with the DatumPLanes: they show where the origin is. Besides that, their function is pretty similar. There are some advantages for LCS - such as direct attachments to XZ and YZ planes - and some for DatumPlanes - such as visualizing the plane. DatumPlanes offer the additional attachment modes indirectly by rotating the attached items by 90°.

What I really would like to see is a combination of both: An LCS having the three principal planes like the Body's Origin. They would have the same visibility behaviour and it should be able to select a plane and directly attach a sketch to it. An additional property could make the axis cross disappear.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
ickby
Veteran
Posts: 3116
Joined: Wed Oct 05, 2011 7:36 am

Re: Datum Plane orientation request

Post by ickby »

I think the original request is a nice idea. Just adding a small axis cross to the visalisation of the datum plane would help a lot. One could put it on a corner vertex of the plane, this ensures it is always visisble (as the plane autoscales to be a bit larger than the largest model element). Or maybe just add two charchters "X" and "Y" on the side of the datum outside the rectangle, and an arrow on each vertex showing into Z. Would also make the orientation clear. A bit like Yoriks arch section views (I think they are called like that)
User avatar
Zolko
Veteran
Posts: 2213
Joined: Mon Dec 17, 2018 10:02 am

Re: Datum Plane orientation request

Post by Zolko »

chrisb wrote: Fri Jan 25, 2019 5:34 am What I really would like to see is a combination of both: An LCS having the three principal planes like the Body's Origin. They would have the same visibility behaviour and it should be able to select a plane and directly attach a sketch to it. An additional property could make the axis cross disappear.
Something like these ?

LCS_AxisCross.png
LCS_AxisCross.png (203.08 KiB) Viewed 2608 times

  • The App::Placement is defined visually in ~/src/Gui/ViewProviderPlacement.cpp
  • The Axis Cross is defined visually in ~/src/Gui/SoAxisCrossKit.cpp
  • The LCS is defined visually in ~/src/Mod/PartDesign/Gui/ViewProviderDatumCS.cpp
Personally, I prefer the behaviour of the Axis Cross: it has a defined size as per screen reference, meaning that when zooming in and out, it keeps the same size on the screen, doesn't follow zoom.
try the Assembly4 workbench for FreCAD — tutorials here and here
User avatar
Zolko
Veteran
Posts: 2213
Joined: Mon Dec 17, 2018 10:02 am

Re: Datum Plane orientation request

Post by Zolko »

ppemawm wrote: Fri Jan 25, 2019 12:52 am What advantage am I missing again other than the visibility of the LCS?
For example if you want to attach more than 1 object (sketches, axis...) on the same position: this took me 30 seconds (really)

LCS_demo6.2.png
LCS_demo6.2.png (315.73 KiB) Viewed 2600 times

Another thing is, if you mess things up (because word censored happens): if your sketches are attached to LCS, you'll have to re-attach the LCS-s but the sketches themselves will remain consistent. For example, in the demo6 attached previously, add another arc and another section to the Sketch profile, to make the sweep longer. It'll completely confuse things. Now, you can re-attach the LCS to the correct positions, add another LCS, another hexagonal sketch, re-edit the sweep to add those objects, and you're done. All the while dynamically seeing what you're doing.

But anyway, I don't have any incentive to convince you to use LCS or not, please do as you wish.
try the Assembly4 workbench for FreCAD — tutorials here and here
chrisb
Veteran
Posts: 53786
Joined: Tue Mar 17, 2015 9:14 am

Re: Datum Plane orientation request

Post by chrisb »

Zolko wrote: Fri Jan 25, 2019 9:26 am Something like these ?
Yes please, the right one if it is possible to attach sketches directly to the 3 principal planes of the LCS. I had been thinking of something like this:
Attachments
Bildschirmfoto 2019-01-25 um 14.01.53.png
Bildschirmfoto 2019-01-25 um 14.01.53.png (17.14 KiB) Viewed 2572 times
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
GeneFC
Veteran
Posts: 5373
Joined: Sat Mar 19, 2016 3:36 pm
Location: Punta Gorda, FL

Re: Datum Plane orientation request

Post by GeneFC »

I prefer the simple tri-vector used for the axis cross. All of those extra lines in the origin style add a lot of clutter.

Gene
Post Reply