feature: general initial value and body source, to be tested

About the development of the FEM module/workbench.

Moderator: bernd

qingfeng.xia
Posts: 153
Joined: Tue Sep 22, 2015 1:47 pm
Location: Oxford Uk
Contact:

Re: feature: general initial value and body source, to be tested

Postby qingfeng.xia » Thu Jan 24, 2019 8:52 pm

bernd wrote:
Tue Jan 22, 2019 7:41 pm
your generall constraints are improvements we should get into master. About a time line ... I do not know, we it is ready ... I will have another look before february.

I will separete the fixes commit and add it to my next PR.

We might need to change the unit tests. I will have a look at this too.
I have done "git pull bernd fembodyconstraint" in my new local branch. For the moment, I can carry on some fix work now.
I will send in some pull request to your branch about this weekend, to fix some issues like unit test.

Thank you
Ubuntu LTS 64bit in virtualbox, always work with latest FreeCAD git version
Mainly work on OpenFOAM + Fenics for CFD, FSI
qingfeng.xia
Posts: 153
Joined: Tue Sep 22, 2015 1:47 pm
Location: Oxford Uk
Contact:

Re: feature: general initial value and body source, to be tested

Postby qingfeng.xia » Thu Jan 31, 2019 11:22 pm

It has been fixed by some one, it is not shown in github webpage history
https://github.com/FreeCAD/FreeCAD/blob ... undary.cpp
bernd wrote:
Thu Jan 24, 2019 6:31 am
bernd wrote:
Wed Jan 23, 2019 5:35 am
qingfeng.xia wrote:
Sun Jan 20, 2019 9:07 pm
2) yes there is a bug fix for my fluidboundary, do you suggest splitting it out for pull request directly to master by myself?
https://github.com/FreeCAD/FreeCAD/pull/1925
it compiles for me, but it fails on travis with

Code: Select all

[ 76%] [32mBuilding CXX object src/Mod/Fem/Gui/CMakeFiles/FemGui.dir/TaskFemConstraintPressure.cpp.o[0m
/home/travis/build/FreeCAD/FreeCAD/src/Mod/Fem/Gui/TaskFemConstraintFluidBoundary.cpp: In member function ‘void FemGui::TaskFemConstraintFluidBoundary::onBoundaryTypeChanged()’:
/home/travis/build/FreeCAD/FreeCAD/src/Mod/Fem/Gui/TaskFemConstraintFluidBoundary.cpp:634:108: error: cannot pass objects of non-trivially-copyable type ‘std::string {aka class std::basic_string<char>}’ through ‘...’
         Base::Console().Error("Fluid boundary recomputationg failed for boundaryType `%s` \n", boundaryType);
                                                                                                            ^
make[2]: *** [src/Mod/Fem/Gui/CMakeFiles/FemGui.dir/TaskFemConstraintFluidBoundary.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
[ 76%] [34m[1mGenerating ui_PropertiesDialog.h[0m
see https://api.travis-ci.org/v3/job/483739833/log.txt

would you have a look at this quing feng?
Ubuntu LTS 64bit in virtualbox, always work with latest FreeCAD git version
Mainly work on OpenFOAM + Fenics for CFD, FSI
User avatar
bernd
Posts: 7306
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland

Re: feature: general initial value and body source, to be tested

Postby bernd » Fri Feb 01, 2019 6:35 am

qingfeng.xia wrote:
Thu Jan 31, 2019 11:22 pm
It has been fixed by some one, it is not shown in github webpage history
yeah, I realized this too, but just did not post about this here.
qingfeng.xia
Posts: 153
Joined: Tue Sep 22, 2015 1:47 pm
Location: Oxford Uk
Contact:

Re: feature: general initial value and body source, to be tested

Postby qingfeng.xia » Mon Feb 11, 2019 9:30 pm

I fixed the UnitTest failure, it is a following on work on your pep8. It is mergeable to upstream master.

it is on my new branch: fembodyconstraint
https://github.com/qingfengxia/FreeCAD/ ... constraint

Code: Select all



Merge branch 'fembodyconstraint' of https://github.com/berndhahnebach… 
Commits on Feb 11, 2019
FEM: fix FemTest failure after introduction of fembodyconstraint classes
Fem: refactor on BoyConstraintWidget as the taskpanel for taskpanel 

bernd wrote:
Fri Feb 01, 2019 6:35 am
qingfeng.xia wrote:
Thu Jan 31, 2019 11:22 pm
It has been fixed by some one, it is not shown in github webpage history
yeah, I realized this too, but just did not post about this here.
Ubuntu LTS 64bit in virtualbox, always work with latest FreeCAD git version
Mainly work on OpenFOAM + Fenics for CFD, FSI