Reference constraint wrong on diameters of external references

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
chrisb
Posts: 18143
Joined: Tue Mar 17, 2015 9:14 am

Re: Reference constraint wrong on diameters of external references

Postby chrisb » Fri Feb 15, 2019 9:32 am

Now it seems to wrong the other way, if I take a normal circle, radius and diameter of reference constraints show the same value:
Bildschirmfoto 2019-02-15 um 09.50.45.png
Bildschirmfoto 2019-02-15 um 09.50.45.png (18.09 KiB) Viewed 208 times
abdullah wrote:
Thu Feb 14, 2019 5:13 am
ping
Should I reopen the ticket?

Concerning the question, why I was not aware of the ticket ...
openBrain wrote:
Thu Feb 14, 2019 1:21 pm
And so probably a unique chance to use that screenshot at chrisb's attention
... I found the explanation. It was not my fault, but the reporter's, who did not conform to the process. If he had done so, we would have seen here a forum discussion. I read all forum posts, but I don't scan the bug tracker.

OS: Ubuntu 16.04.5 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15860 (Git)
Build type: Release
Branch: master
Hash: 3b708c7f84b0425076b520e1d95627b20fd75fe0
Python version: 2.7.12
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)
kisolre
Posts: 1359
Joined: Wed Nov 21, 2018 1:13 pm

Re: Reference constraint wrong on diameters of external references

Postby kisolre » Fri Feb 15, 2019 9:39 am

Confirmed:
RefConstraintErr.JPG
RefConstraintErr.JPG (55.6 KiB) Viewed 205 times
OS: Windows 8.1
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15816 (Git)
Build type: Release
Branch: master
Hash: 7ee0e4d43909ec688299b8498b240cccf8362c47
Python version: 3.6.6
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Bulgarian/Bulgaria (bg_BG)

and 44 commits later it is still there:
OS: Windows 8.1
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.15860 (Git)
Build type: Release
Branch: master
Hash: 3b708c7f84b0425076b520e1d95627b20fd75fe0
Python version: 3.6.6
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: Bulgarian/Bulgaria (bg_BG)
openBrain
Posts: 1959
Joined: Fri Nov 09, 2018 5:38 pm

Re: Reference constraint wrong on diameters of external references

Postby openBrain » Fri Feb 15, 2019 10:08 am

chrisb wrote:
Fri Feb 15, 2019 9:32 am
Concerning the question, why I was not aware of the ticket ...
openBrain wrote:
Thu Feb 14, 2019 1:21 pm
And so probably a unique chance to use that screenshot at chrisb's attention
... I found the explanation. It was not my fault, but the reporter's, who did not conform to the process. If he had done so, we would have seen here a forum discussion. I read all forum posts, but I don't scan the bug tracker.
I knew that ! :D Anyway don't waste too much precious time with my post. I was just kidding (as the name of the previous screenshot confirms). ;)
chrisb
Posts: 18143
Joined: Tue Mar 17, 2015 9:14 am

Re: Reference constraint wrong on diameters of external references

Postby chrisb » Fri Feb 15, 2019 11:48 am

I sometimes get rather upset, that people request much for free , but don't conform to the processes which help the helpers to help. So it is rather a request to myself.
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: Reference constraint wrong on diameters of external references

Postby abdullah » Fri Feb 15, 2019 12:42 pm

chrisb wrote:
Fri Feb 15, 2019 9:32 am
abdullah wrote:
Thu Feb 14, 2019 5:13 am
ping
Should I reopen the ticket?
Sure! I will try to take a look... :?
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: Reference constraint wrong on diameters of external references

Postby abdullah » Fri Feb 15, 2019 12:53 pm

chrisb wrote:
Fri Feb 15, 2019 9:32 am
abdullah wrote:
Thu Feb 14, 2019 5:13 am
ping
Should I reopen the ticket?
Note to self:

Probably this:

Code: Select all

else if((*it).constr->Type==Diameter && (*it).constr->First>0 )
should be:

Code: Select all

else if((*it).constr->Type==Diameter && (*it).constr->First>=0 )
gauna
Posts: 11
Joined: Fri Dec 04, 2015 8:20 pm

Re: Reference constraint wrong on diameters of external references

Postby gauna » Fri Feb 15, 2019 4:01 pm

openBrain wrote:
Thu Feb 14, 2019 1:21 pm
I found the explanation. It was not my fault, but the reporter's, who did not conform to the process. If he had done so, we would have seen here a forum discussion. I read all forum posts, but I don't scan the bug tracker.
You can be sure that this has been my last bug report to FreeCAD, if you stay accusing me that it would be my fault that you are not checking the bug tracker before reporting a bug while using an outdated version. I checked the bug tracker and the forum just before reporting the bug. I do not have the time to ask the forum if it may be a bug or perhaps an optical illusion if radius and diameter are differing more that 2 times.
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: Reference constraint wrong on diameters of external references

Postby abdullah » Fri Feb 15, 2019 5:00 pm

I think we all are guilty of being a great community. Guilty as .... ;) :D
chrisb wrote:
Fri Feb 15, 2019 9:32 am
abdullah wrote:
Thu Feb 14, 2019 5:13 am
ping
Should I reopen the ticket?
PR:
https://github.com/FreeCAD/FreeCAD/pull/1973
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: Reference constraint wrong on diameters of external references

Postby abdullah » Fri Feb 15, 2019 6:15 pm

gauna wrote:
Fri Feb 15, 2019 4:01 pm
openBrain wrote:
Thu Feb 14, 2019 1:21 pm
I found the explanation. It was not my fault, but the reporter's, who did not conform to the process. If he had done so, we would have seen here a forum discussion. I read all forum posts, but I don't scan the bug tracker.
You can be sure that this has been my last bug report to FreeCAD, if you stay accusing me that it would be my fault that you are not checking the bug tracker before reporting a bug while using an outdated version. I checked the bug tracker and the forum just before reporting the bug. I do not have the time to ask the forum if it may be a bug or perhaps an optical illusion if radius and diameter are differing more that 2 times.
A bug is a bug and should be reported when found. I cannot stress sufficiently how important it is that bugs get reported. Free software users should feel at least slightly morally compelled to report bugs. But I admit I am not reporting all the bugs I found in every single free software I use, so I am not a good example either. In any case, I really hope it is not your last bug report.

We need rules because otherwise it would be a chaos. The rule of posting in the forum before posting a bug has saved considerable developer time. Not infrequently a user thinks it is a bug, which in fact is a feature. Not infrequently a user uses an outdated version of FreeCAD and reports an already fixed bug. Many times it is not obvious from the description of a ticket what the problem actually is. Sometimes there is not a Freecad file to download to reproduce the problem easily. Forum regulars have proven to be an outstanding filter to better manage a scarce resource, development time.

It is not the first time that somebody is very confident it is a bug and directly posts a ticket. Regulars may grill me for what I am about to say. It is not the end of the world. Some bugs are so obviously a bug that nothing else could have been intended. The case of the reporter is one such case. In cases of direct bug posting. I would vote for grilling the reporter for not following the rule if it is not a bug and parade him over our shoulders like a hero if it is indeed a bug.

The irony of all this is that a good reporter is being grilled over the procedure, because an outstanding forum regular and invaluable helper was erroneously jokingly grilled for not following the procedure, because I jokingly noted the oddity of the situation in which the aforementioned forum regular was not aware of a reported bug which I had already handled, all because I failed to fully fix the bug (the corner case is a circle that is the first geometry in the sketcher, in any other circle there is no bug).

So please blame it on me and keep reporting bugs and helping filter them and grilling bad reporters that do not follow the rules and contributing to make FreeCAD a bit better ;)
openBrain
Posts: 1959
Joined: Fri Nov 09, 2018 5:38 pm

Re: Reference constraint wrong on diameters of external references

Postby openBrain » Fri Feb 15, 2019 6:38 pm

abdullah wrote:
Fri Feb 15, 2019 6:15 pm
gauna wrote:
Fri Feb 15, 2019 4:01 pm
openBrain wrote:
Thu Feb 14, 2019 1:21 pm
I found the explanation. It was not my fault, but the reporter's, who did not conform to the process. If he had done so, we would have seen here a forum discussion. I read all forum posts, but I don't scan the bug tracker.
[...]
Hey guys, there is an actual bug : I'm not the author of this fight ignition sentence. :lol: :lol:
[...] was erroneously jokingly grilled for not following the procedure [...]
I disagree : chrisb admitted he didn't search the tracker which is an imposition in the procedure :lol:

Anyway, all that will soon be a tremendous thread where a bug was discovered and fixed thanks to another "non procedure compliant" bug reporting (that actually has already been "almost but not completely fixed with some regression" by the amazing developers of FreeCAD). :lol: