Coverity

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
mlampert
Veteran
Posts: 1772
Joined: Fri Sep 16, 2016 9:28 pm

Re: Coverity

Post by mlampert »

saso wrote: Thu Jul 12, 2018 8:56 am For Path python code there are also issues 168953 and 168942... Could you take a look at the issue 168953 ? Issue 168942 I believe we could mark as "Classification: Intentional & Action: Ignore" ? This would then close all current issues in the Path python code.
I have never used PathSurface (nor is it likely I ever will) so I can't fix 168953, maybe
sliptonic wrote:ping
can take a look.

The same is true for 168942, although that one I should manage to fix without verification.
User avatar
sliptonic
Veteran
Posts: 3457
Joined: Tue Oct 25, 2011 10:46 pm
Location: Columbia, Missouri
Contact:

Re: Coverity

Post by sliptonic »

I think this is just a matter of making the test for ocl not conditional.
https://github.com/sliptonic/FreeCAD/co ... a5a1fbdb7d

I'll send a PR unless someone sees an issue.
User avatar
saso
Veteran
Posts: 1920
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Post by saso »

Thanks, I have marked them all in Coverty as "fix submitted". For issues like 168942, where the intend of that line was basically the same as the reason for detecting it and where the issue by itself is not critical (not a bug), if there is preference to keep such code we can also just mark such issues in the Covertiy as "Classification: Intentional & Action: Ignore".
User avatar
saso
Veteran
Posts: 1920
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Post by saso »

I was having problems uploading to Coverity so the results for build 0.18.14996 from October are available only now. A new build for November should hopefully be done in the next days...
User avatar
saso
Veteran
Posts: 1920
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Post by saso »

Coverity was unavailable for the past few weeks so there was no build analysis of FreeCAD code in January, but now it is back online and new results for build 0.18.15892 are available...
User avatar
saso
Veteran
Posts: 1920
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Post by saso »

New report has been created from build 0.19.16291...
User avatar
saso
Veteran
Posts: 1920
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Post by saso »

The last build from May was stuck in coverty for some time so the new report from build 0.19.16718 is available only now
User avatar
saso
Veteran
Posts: 1920
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Post by saso »

New report from build 0.19.17300 has been created...

As before, I would recommend to use the Coverity online app for issues reviewing and managing, here are a few posts I did in the past on how to use it https://forum.freecadweb.org/viewtopic. ... 30#p210644

Coverity also has a new version of its scanning tool so there might be some new issues detected from the improved analysis https://community.synopsys.com/s/questi ... 19-upgrade
User avatar
saso
Veteran
Posts: 1920
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Post by saso »

New report from build 0.19.18227 has been created, unfortunately code quality seems to have gone down quite a bit... :|
User avatar
saso
Veteran
Posts: 1920
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Post by saso »

New report from build 0.19.21984 has been created...

PS: If you get an error in Coverity when opening the "View Defects" window, just try to close it and open it again...
Post Reply