Marking PartDesign not properly attached datums
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
Be nice to others! Read the FreeCAD code of conduct!
Marking PartDesign not properly attached datums
I am doing a medium size project, and one problem I have come across is that when reworking a part done with PartDesign, in which datum planes and lines where used attached to a master sketch, the datum planes and lines eventually lost the link (probably licit because of the rework), but nevertheless stayed in place. The rework should cause these datums to move about 1 mm and it was not very much evident that they were no longer linked, until I made the master sketch visible and set the right view.
I do not know if this is something relevant, so my question.
I have just hacked away a half working implementation that looks like this:
So basically, datums could get an overlay status icon somewhere (now is bottom left). The ones that are attached would get the greenish thingy (I thought it was a weight when I made the text pixmap, but it is not clear at all) and ones that are not attached the yellow thingy (was supposed to be a yellow balloon, not my best art, not that I can do art anyway). Practical implementation says that it should be something that can be distinguished by shape, because datums are generally not visible and a greyed out icon makes them look the same.
Well, this is just to ask the question, does this make any sense? Any follow up ideas?
I do not know if this is something relevant, so my question.
I have just hacked away a half working implementation that looks like this:
So basically, datums could get an overlay status icon somewhere (now is bottom left). The ones that are attached would get the greenish thingy (I thought it was a weight when I made the text pixmap, but it is not clear at all) and ones that are not attached the yellow thingy (was supposed to be a yellow balloon, not my best art, not that I can do art anyway). Practical implementation says that it should be something that can be distinguished by shape, because datums are generally not visible and a greyed out icon makes them look the same.
Well, this is just to ask the question, does this make any sense? Any follow up ideas?
Re: Marking PartDesign not properly attached datums
It makes perfectly sense to distinguish attached and not attached items, as we have seen here some troubles. The concept should be extended to sketches and primitives. To not overload the tree it would be sufficient to mark only the non attached items.
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.
Re: Marking PartDesign not properly attached datums
could be with the caption of items: Sketch for attached, Sketch for free. or something like that.
Re: Marking PartDesign not properly attached datums
And IMO the overlay icon shouldn't be in green, orange or red but in a neutral color because at least for non-attached datum objects it doesn't mean there is something broken in the design.
Re: Marking PartDesign not properly attached datums
An attempt:
https://github.com/FreeCAD/FreeCAD/pull/2272
If the code is acceptable, the icon may be changed: It is not really difficult to make something better...
https://github.com/FreeCAD/FreeCAD/pull/2272
If the code is acceptable, the icon may be changed: It is not really difficult to make something better...
- Hannu
- Posts: 130
- Joined: Fri Sep 11, 2015 4:12 pm
- Location: Strängnäs, Sweden - 1hr drive west from Stockholm
Re: Marking PartDesign not properly attached datums
FWIW: I use glasses, a different pair depending on what I'm at - the latest pair received just a month ago or so.
These tiny 'status indicators' isn't very helpful IMO.
I can see there is one but have a hard time to distinguish between them.
Suggestion:
Might it be possible to "append" (a?) larger icon(s) after (to the right of) the main feature icon, before the text?
Maybe make it/them be 2/3 the height of the main one?
These tiny 'status indicators' isn't very helpful IMO.
I can see there is one but have a hard time to distinguish between them.
Suggestion:
Might it be possible to "append" (a?) larger icon(s) after (to the right of) the main feature icon, before the text?
Maybe make it/them be 2/3 the height of the main one?
/Hannu - engineer & mild
- Embedded, Computer, Software, Electronic, Fault analysis. A&D Photography http://flickr.com/arkane
- Mechanics, FDM 3D-prints, Solder, Lathe, Mill, Weld -work. ISO Audits, Claim, Deviation, Corrective action
- Embedded, Computer, Software, Electronic, Fault analysis. A&D Photography http://flickr.com/arkane
- Mechanics, FDM 3D-prints, Solder, Lathe, Mill, Weld -work. ISO Audits, Claim, Deviation, Corrective action
Re: Marking PartDesign not properly attached datums
Glasses or no glasses, with the current icon size it is difficult to actually identify the shape of the overlay. I cannot. I only pay attention to the colour and the position relative to the main icon:Hannu wrote: ↑Wed Jun 19, 2019 5:03 pm FWIW: I use glasses, a different pair depending on what I'm at - the latest pair received just a month ago or so.
These tiny 'status indicators' isn't very helpful IMO.
I can see there is one but have a hard time to distinguish between them.
Suggestion:
Might it be possible to "append" (a?) larger icon(s) after (to the right of) the main feature icon, before the text?
Maybe make it/them be 2/3 the height of the main one?
Top right (related to recomputes and errors). If blueish I need a recompute. If red oh oh, look a the report window.
Bottom right (only in PD, only for the tip, it is greenish).
Bottom left (only in PD, only for identification of lack of attachment, it is pink).
I would rather not include several icons. Having a larger icon would require increasing the icon sizes and the treeview lines would be restricted. This is kind of a general decision.
Re: Marking PartDesign not properly attached datums
I realized today that this feature is available. And indeed the icon is ... awful.
Looks like front view of a car, so can't give an obvious meaning to that.
What about something like that :
- Attachments
-
- not_attached_icon.svg
- (3.4 KiB) Downloaded 66 times
Re: Marking PartDesign not properly attached datums
How about an open lock?
A Sketcher Lecture with in-depth information is available in English, auf Deutsch, en français, en español.