Automate Reinforcement GSoC proposal

Have some feature requests, feedback, cool stuff to share, or want to know where FreeCAD is going? This is the place.
Forum rules
Be nice to others! Read the FreeCAD code of conduct!
User avatar
Kunda1
Posts: 5121
Joined: Thu Jan 05, 2017 9:03 pm

Re: Automate Reinforcement GSoC proposal

Postby Kunda1 » Sat Jun 22, 2019 2:10 pm

<!-- offtopic
Just wanted to put on your radar this cool macro: Automatic Light Gauge Steel Frame Creator macro + screencast. I wonder if this code could somehow be utilized in Rebars ?? Just curious. -->
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
amrit3701
Posts: 234
Joined: Mon Jun 13, 2016 5:37 pm

Re: Automate Reinforcement GSoC proposal

Postby amrit3701 » Sun Jun 23, 2019 3:59 pm

Suraj Dadral wrote:
Fri Jun 21, 2019 5:13 pm
Hello everyone,
Till now, I have made new UI using which user can create and edit Single Tie Four Rebars from UI.
And related code can be found here:
https://github.com/SurajDadral/FreeCAD- ... mate-newui

In new UI, I have implemented all suggestions by @hardeeprai except point 2 i.e. Add help button for every field.

Now, I am implementing creation and editing of secondary rebars.
I will try to implement it before 24 June. And will generate documentation for code.
Hi Suraj, I arrived in India and available from right now.

I tested your new dialog code and it works well. Now, we are on the right track. :D

The XDir Secondary Rebars and YDir Secondary Rebars is not working. Also, tell me how it's different from Main Rebars?

Screenshot after testing.
Screenshot 2019-06-23 at 8.51.32 PM.png
Screenshot 2019-06-23 at 8.51.32 PM.png (578.67 KiB) Viewed 537 times
User avatar
Suraj Dadral
Posts: 98
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Postby Suraj Dadral » Mon Jun 24, 2019 6:31 am

amrit3701 wrote:
Sun Jun 23, 2019 3:59 pm

Hi Suraj, I arrived in India and available from right now.

I tested your new dialog code and it works well. Now, we are on the right track. :D
Thanks
amrit3701 wrote:
Sun Jun 23, 2019 3:59 pm

The XDir Secondary Rebars and YDir Secondary Rebars is not working. Also, tell me how it's different from Main Rebars?
Now, it is working and user can create and edit reinforcement from ui.

In current implementation, function editSingleTieMultipleRebars deletes and recreate previously created secondary rebars.
Todo: delete and recreate secondary rebars only when rebar type or number#diameter changes. Otherwise edit already created rebars.

In below image,
Main rebars: present at corner of ties
Secondary rebars: all other rebars except main rebars (shown colored in image)
SingleTieMultipleRebars.png
SingleTieMultipleRebars.png (201.51 KiB) Viewed 517 times
Thanks,
User avatar
yorik
Site Admin
Posts: 11458
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Automate Reinforcement GSoC proposal

Postby yorik » Tue Jun 25, 2019 9:35 pm

Looks very nice! Well done so far!
User avatar
Suraj Dadral
Posts: 98
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Postby Suraj Dadral » Wed Jun 26, 2019 9:56 am

yorik wrote:
Tue Jun 25, 2019 9:35 pm
Looks very nice! Well done so far!
Thanks @yorik

I have created documentation page for current implementation and can be found here:
https://www.freecadweb.org/wiki/Arch_Re ... nforcement

Please review and give your suggestions.

Now, I am going to include examples for scripting.

Thanks,
User avatar
Suraj Dadral
Posts: 98
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Postby Suraj Dadral » Thu Jun 27, 2019 6:53 am

Suraj Dadral wrote:
Wed Jun 26, 2019 9:56 am

I have created documentation page for current implementation and can be found here:
https://www.freecadweb.org/wiki/Arch_Re ... nforcement

Please review and give your suggestions.

Now, I am going to include examples for scripting.
Hello everyone,
I have created examples on wiki page.
Now, I will work on code improvement as I discussed in post: https://forum.freecadweb.org/viewtopic. ... 40#p316484

Thanks,
User avatar
Suraj Dadral
Posts: 98
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Postby Suraj Dadral » Sat Jun 29, 2019 6:41 pm

Hello everyone,
Today me and @amrit3701 have video conference and we discussed about work done till now.
@amrit3701 suggested following things:
  1. Use black syntax for code section in documentation present here: https://www.freecadweb.org/wiki/Arch_Re ... nforcement
  2. Wrap long python strings as suggested here: https://docs.python.org/3/reference/lex ... catenation, https://stackoverflow.com/questions/106 ... ine-string
  3. Center align Recangular Column and Circular Column radio button in ColumnReinforcement ui.
  4. We discussed about next task to do, which will be to implement column reinforcement with two ties as in image: https://www.freecadweb.org/wiki/File:Co ... types1.png
Thanks,
User avatar
Suraj Dadral
Posts: 98
Joined: Fri Sep 07, 2018 5:32 pm
Contact:

Re: Automate Reinforcement GSoC proposal

Postby Suraj Dadral » Mon Jul 01, 2019 11:29 am

yorik wrote:
Sun May 12, 2019 12:48 am
IMHO the 4@20+3@16 notation is useful for you (easy to parse and store in a string), but not very easy to the user. I would change that edit field by a button, that opens a dialog that is specially made to create and edit such a string. Maybe a kind of grid where the use wouldn't have to care about entering special chars correctly...
I have created dialog box for editing Number#Diameter string. User can edit Number#Diameter string either directly in ui input field or he/she can click on "Edit Number and Diameter" button to open dialog box for editing that string.

New dialog box preview:
NewDialogBox.png
NewDialogBox.png (26.08 KiB) Viewed 265 times

Please review and give your suggestions.

Thanks,
User avatar
yorik
Site Admin
Posts: 11458
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Automate Reinforcement GSoC proposal

Postby yorik » Mon Jul 01, 2019 1:31 pm

Great! Perfect solution
User avatar
amrit3701
Posts: 234
Joined: Mon Jun 13, 2016 5:37 pm

Re: Automate Reinforcement GSoC proposal

Postby amrit3701 » Mon Jul 01, 2019 7:21 pm

Suraj Dadral wrote:
Wed Jun 26, 2019 9:56 am
I have created documentation page for current implementation and can be found here:
https://www.freecadweb.org/wiki/Arch_Re ... nforcement

Please review and give your suggestions.
Looks good. :D