Assembly3 preview

Discussion about the development of the Assembly workbench.
freecad-heini-1
Posts: 5882
Joined: Tue Jan 07, 2014 11:10 am
Contact:

Re: Assembly3 preview

Postby freecad-heini-1 » Sat Jun 29, 2019 10:38 am

Please be so kind as to look at my question about Assembly 3. Thanks a lot and best regards
Wilfried
https://forum.freecadweb.org/viewtopic. ... 15#p317615
realthunder
Posts: 1188
Joined: Tue Jan 03, 2017 10:55 am

Re: Assembly3 preview

Postby realthunder » Tue Jul 02, 2019 9:10 am

New bug fix version released.
Try Assembly3 (latest version 0.10.2) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
Mark Szlazak
Posts: 405
Joined: Tue Apr 04, 2017 6:06 pm
Location: Edmonton, Canada

Re: Assembly3 preview

Postby Mark Szlazak » Tue Jul 02, 2019 9:14 pm

realthunder wrote:
Tue Jul 02, 2019 9:10 am
New bug fix version released.
Thank you! Btw, what was fixed?

Also, there have been various requests in this thread which you stated would come in future updates. Can you or someone create a roadmap of these and anything’s you might want with progress status?

Thanks again.
realthunder
Posts: 1188
Joined: Tue Jan 03, 2017 10:55 am

Re: Assembly3 preview

Postby realthunder » Wed Jul 03, 2019 12:00 am

Mark Szlazak wrote:
Tue Jul 02, 2019 9:14 pm
realthunder wrote:
Tue Jul 02, 2019 9:10 am
New bug fix version released.
Thank you! Btw, what was fixed?

Also, there have been various requests in this thread which you stated would come in future updates. Can you or someone create a roadmap of these and anything’s you might want with progress status?

Thanks again.
The bug fixes are usually documented in git commit log, or in the github issue tracker if reported by user. I wasn't planning for this release, but freecad-heini-1 asked about a demo, and I found out a bug in toposhape makeLoft that caused recompute error with his file. The bug does not affect upstream, though. It is caused by inconsistent behavior between my branch and the upstream due to a recent change made in upstream.

I am currently busy preparing for the big merge. It is going to take some time, because I have to manually pick out changes scattered everywhere, and making adjustment along the way.
Try Assembly3 (latest version 0.10.2) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
realthunder
Posts: 1188
Joined: Tue Jan 03, 2017 10:55 am

Re: Assembly3 preview

Postby realthunder » Wed Jul 03, 2019 3:20 am

I have just updated the images of the latest release because of a critical bug reported by a user.
Try Assembly3 (latest version 0.10.2) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
toralf
Posts: 27
Joined: Fri May 03, 2019 3:54 am

Re: Assembly3 preview

Postby toralf » Sat Jul 13, 2019 9:29 pm

realthunder wrote:
Wed Jul 03, 2019 12:00 am
I am currently busy preparing for the big merge. It is going to take some time,
Do you have any idea how long it may take?
I’m considering to test ASM3, but if it will be merged upstream not to far into the future I might just wait for it.
Thanks for the great work.
realthunder
Posts: 1188
Joined: Tue Jan 03, 2017 10:55 am

Re: Assembly3 preview

Postby realthunder » Sat Jul 13, 2019 10:41 pm

toralf wrote:
Sat Jul 13, 2019 9:29 pm
Do you have any idea how long it may take?
I’m considering to test ASM3, but if it will be merged upstream not to far into the future I might just wait for it.
Thanks for the great work.
I am not merging asm3 the workbench. Instead, I am merging part of the FreeCAD core changes I made in order to run asm3. I have just finished picking up all the changes that related to Link functionality and pass the upstream test. And it is a huge 64K lines of change set. I am not sure how long it will take to review it. Next, I'll adjust my asm3 to work in this merged version before submitting the PR.
Try Assembly3 (latest version 0.10.2) along with my custom build of FreeCAD at here.
And if you'd like to show your support, you can donate through patreon, liberapay, or paypal
User avatar
fosselius
Posts: 344
Joined: Sat Apr 23, 2016 10:03 am

Re: Assembly3 preview

Postby fosselius » Sun Jul 14, 2019 5:07 am

awesome! once you make the PR i will spend at least an evening going through (some of) your changes. prepare for some silly questions ;)
I have to manually pick out changes scattered everywhere, and making adjustment along the way.
Are you doing any architectural changes to the Link implementation?

i guess it has become a bit more "modular" as you have isolated the functionality from all your other code.

in my codebases at work i usually have a annual or bi-annual rewrite of major parts of the code to better incoperate all the new features that have been integrated since the last architecture design.. It is actually something i enjoy doing ^_^

but my codebases are a bit smaller. only 1-30k lines usually. and pure c code for embedded systems, and a few python scripts to autogenerate code for different hardware configurations and customer integrations.

BTW, your documentation is outstanding.
https://github.com/realthunder/FreeCAD_ ... /wiki/Link
https://github.com/realthunder/FreeCAD_ ... re-Changes
Is this up to date with your linkmerge branch?
Jee-Bee
Posts: 1957
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: Assembly3 preview

Postby Jee-Bee » Sun Jul 14, 2019 3:35 pm

realthunder wrote:
Sat Jul 13, 2019 10:41 pm
...huge 64K lines of change...
:o :shock:
User avatar
saso
Posts: 1332
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Assembly3 preview

Postby saso » Sun Jul 14, 2019 7:33 pm

Well, it seems to me that we are continuously trying to break this "assembly wall" with heads first approach and it is bringing us nothing but headache... If we really want to make FreeCAD work as it should then I would personally do a few steps back and try to do it in about this order:

(not directly related to Link/Asm3 but represents important improvements to a proper Part workflow that gives the building stones for a proper assembly)
1. change the datum elements (point, line, plane, cs) so that they can be used everywhere, not just inside Bodies (should not be ignored and should IMO have priority, we have talked about this just before the 0.18 release https://forum.freecadweb.org/viewtopic. ... 4&start=30)
2. make it possible to work inside the Part container (should not be ignored and should IMO have priority, DeepSOIC had some ideas about this if I remember correctly)
3. change the Body to work like a proper body (this is giving us a lot of problems but it can maybe be done later, I don't know how much work this will be but it should not be ignored, I will make a special post about this)
4. proper strategies for managing the history tree (it is closely related to the Body problem and can also probably be done later but should not be ignored)
5. proper step import/export (should be done after above changes since it is highly dependent on them and should also not be ignored)

(related to Link/Asm3 I would actually try to get in to the master first many of the other things that have been developed with it. i think many of them have been reviewed and tested much better and have a very high value to the users and could have probably been added to the master a long time ago in the 0.18 dev cycle, personally i would specially like to see this...)
6. picked list
7. sketcher exports
8. sketcher toponaming (would be great if ickby and DeepSOIC would share their view on this implementation)
9. general toponaming (would be great if ickby and DeepSOIC would share their view on this implementation)
... there is much more, but some of it can probably have lower priority for later... go over the release notes https://github.com/realthunder/FreeCAD_assembly3/wiki

(the basic Link functionality I would personally like to see in 0.19 but it could probably need some more review... do we really need link groups?)
10. Link

(this should probably wait)
11. Asm3
12. enhanced expression engine

(This post is also related to my answer here https://forum.freecadweb.org/viewtopic. ... 10#p320880)
Last edited by saso on Wed Aug 07, 2019 12:07 pm, edited 1 time in total.