Body objects and errors in its features

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
chrisb
Posts: 16914
Joined: Tue Mar 17, 2015 9:14 am

Re: Body objects and errors in its features

Postby chrisb » Tue Jul 02, 2019 9:58 pm

Differentiating between the source of an error and derived broken objects is great. As DeepSOIC said, it takes considerable time to drill down a deeply nested Part tree of boolean operations. or to expand every feature in a body to find the sketch in error.
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: Body objects and errors in its features

Postby abdullah » Sat Jul 06, 2019 6:49 am

DeepSOIC wrote:
Tue Jul 02, 2019 2:35 pm
Nice one, Abdullah! These hidden errors have got me at least a few times. I even implemented a check in PoM Exporter feature, that would pop up a message that there is an error anywhere in the dependencies, when exporting.
chrisb wrote:
Tue Jul 02, 2019 9:58 pm
Differentiating between the source of an error and derived broken objects is great. As DeepSOIC said, it takes considerable time to drill down a deeply nested Part tree of boolean operations. or to expand every feature in a body to find the sketch in error.
If you liked that one, I think you will love this variant:
- Everything that is affected (OutListRecursive) gets flagged.
- It applies to every single object, not just groups
Screenshot_20190706_084620.png
Screenshot_20190706_084620.png (33.84 KiB) Viewed 73 times
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: Body objects and errors in its features

Postby abdullah » Sat Jul 06, 2019 7:02 am

PR:
https://github.com/FreeCAD/FreeCAD/pull/2326
wmayer wrote:
Tue Jul 02, 2019 2:07 pm
According to its execute() method there are two cases where the body itself is broken. The tip points to a non-PD object or the tip points to an empty shape
I have departed from extending group functionality.

I have done many tests, under the premise that what I wanted is extend the functionality of groups. I took me a while to realise that I did not want that, but just be notified of errors that affected the outcome of certain nodes. This made the implementation way much simpler and useful.
chrisb
Posts: 16914
Joined: Tue Mar 17, 2015 9:14 am

Re: Body objects and errors in its features

Postby chrisb » Sat Jul 06, 2019 8:07 am

Thanks! Big improvement in error searching!
User avatar
DeepSOIC
Posts: 6655
Joined: Fri Aug 29, 2014 12:45 am
Location: Saint-Petersburg, Russia

Re: Body objects and errors in its features

Postby DeepSOIC » Sat Jul 06, 2019 11:44 am

abdullah wrote:
Sat Jul 06, 2019 6:49 am
If you liked that one, I think you will love this variant:
Oh yes indeed!