Add ons manager - development and bugs topic

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
jmaustpc
Posts: 9566
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Add ons manager - development and bugs topic

Postby jmaustpc » Sun Jun 30, 2019 1:27 pm

Add ons manager - development and bugs topic .....
openBrain
Posts: 2138
Joined: Fri Nov 09, 2018 5:38 pm

Re: Add ons manager - development and bugs topic

Postby openBrain » Sun Jun 30, 2019 2:02 pm

jmaustpc
Posts: 9566
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Add ons manager - development and bugs topic

Postby jmaustpc » Sun Jun 30, 2019 2:07 pm

Hi Yorik, I hope all is well with you on this rather cold Sunday night, although for you it may well neither be cold nor Sunday night! :)

I noticed that if I click on an item (in either WB or Macro tab) in your new add ons manager and then on another before the description page has finished loading, it crashes FreeCAD. Sometimes you have to quickly click on several items before you get the crash.

This is FreeCAD from the daily PPA.

I think you already might know about this since you and Werner were talking about something that sounds similar here
https://forum.freecadweb.org/viewtopic. ... 20#p314328

So if you do already know about this....sorry for the noise. :)


Jim


OS: Ubuntu 18.04.2 LTS (KDE/plasma)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Python version: 3.6.8
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/Australia (en_AU)
User avatar
sgrogan
Posts: 5416
Joined: Wed Oct 22, 2014 5:02 pm

Re: Add ons manager - development and bugs topic

Postby sgrogan » Tue Jul 09, 2019 10:05 pm

rockn wrote:
Tue Jul 09, 2019 9:55 pm
This part is not very user friendly :P

That say, It's not going well.

Code: Select all

No module named 'git'
GitPython not found. Using standard download instead.
Downloading https://framagit.org/freecad-france/moo ... master.zip
Traceback (most recent call last):
File "/usr/share/freecad-daily/Mod/AddonManager/addonmanager_workers.py", line 588, in run
self.download(self.repos[idx][1],clonedir)
File "/usr/share/freecad-daily/Mod/AddonManager/addonmanager_workers.py", line 687, in download
zfile.write(u.read())
AttributeError: 'NoneType' object has no attribute 'read'
You need to install python3-git https://packages.ubuntu.com/bionic/python3-git
It would be nice if this could fall back to .zip, like standard WB.

BTW: bernd requested this feature for the exact same use case, a tutorial WB. Now I learn that yorik is also doing something similar. Seems like there is some synergy here.
User avatar
rockn
Posts: 1578
Joined: Wed Sep 28, 2011 10:39 am
Location: Toulouse, France
Contact:

Re: Add ons manager - development and bugs topic

Postby rockn » Tue Jul 09, 2019 10:34 pm

This is working very well with python3-git package ! :D
Formations et tutoriels FreeCAD en Français, soutenez moi : https://www.tipeee.com/formations-freecad
User avatar
sgrogan
Posts: 5416
Joined: Wed Oct 22, 2014 5:02 pm

Re: Add ons manager - development and bugs topic

Postby sgrogan » Tue Jul 09, 2019 10:45 pm

rockn wrote:
Tue Jul 09, 2019 10:34 pm
This is working very well with python3-git package ! :D
Do you get the readme.md in the description plane?
Capture.PNG
Capture.PNG (73.8 KiB) Viewed 921 times
BTW: Thanks for your early work on the addons-macro. That's where it all started!
User avatar
rockn
Posts: 1578
Joined: Wed Sep 28, 2011 10:39 am
Location: Toulouse, France
Contact:

Re: Add ons manager - development and bugs topic

Postby rockn » Wed Jul 10, 2019 8:35 am

@sgrogan
I get the same screen as your screenshot.
sgrogan wrote:
Tue Jul 09, 2019 10:45 pm
BTW: Thanks for your early work on the addons-macro. That's where it all started!
:P Yeah I remember it was in 2016 when I invited Yorik at home in France and we start coding this addon manager during the night. :geek:
Formations et tutoriels FreeCAD en Français, soutenez moi : https://www.tipeee.com/formations-freecad
alberich
Posts: 48
Joined: Thu Aug 17, 2017 2:09 pm
Location: Texas

Re: Add ons manager - development and bugs topic

Postby alberich » Wed Jul 10, 2019 12:06 pm

addon-0.18.png
0.18 Addon Manager
addon-0.18.png (29.8 KiB) Viewed 860 times
I have been having some small trouble with the Addon Manager's progress bar.

When installing an addon the progress bar never indicates completion,

In

Code: Select all

OS: Linux Mint 19.1
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.16117 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 0.18.2)
Hash: dbb4cc6415bac848a294f03b80f65e888d531742
Python version: 3.6.7
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)
the rectangle just keeps zipping back and forth no matter how long I wait. Checking the /Mod folder shows that the addon is there but the Manager never acknowledges it.

In

Code: Select all

OS: Linux Mint 19.1 (MATE/mate)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Python version: 3.6.8
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)

BuildRevisionDate = 2019/07/08 02:00:36
the progess bar is static, always stuck to the left margin. It also never acknowledges completion of the task.
addon-0.19.png
0.19 Addon Manager
addon-0.19.png (49.2 KiB) Viewed 860 times
User avatar
Kunda1
Posts: 5761
Joined: Thu Jan 05, 2017 9:03 pm

Re: Add ons manager - development and bugs topic

Postby Kunda1 » Wed Jul 10, 2019 12:15 pm

alberich wrote:
Wed Jul 10, 2019 12:06 pm
When installing an addon the progress bar never indicates completion,
Related to:
https://github.com/FreeCAD/FreeCAD-addons/issues/120
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
User avatar
yorik
Site Admin
Posts: 11552
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Add ons manager - development and bugs topic

Postby yorik » Wed Jul 10, 2019 2:39 pm

rockn wrote:
Wed Jul 10, 2019 8:35 am
:P Yeah I remember it was in 2016 when I invited Yorik at home in France and we start coding this addon manager during the night. :geek:
In a cyberpunk bar if I remember well :D (or was it something else we coded t that bar?)
sgrogan wrote:
Tue Jul 09, 2019 10:05 pm
You need to install python3-git https://packages.ubuntu.com/bionic/python3-git
It would be nice if this could fall back to .zip, like standard WB.
This error happens when the addon manager is already falling back to zip download. But apparently the URL to download a zip from framasoft is different from github. We need to have a better look and adapt the addon manager. In the meantime in git commit 4fc91dcc7 I added a more friendly message.
sgrogan wrote:
Tue Jul 09, 2019 10:45 pm
Do you get the readme.md in the description plane?
The readme file is markdown, but the addon manager can only display HTML. So for github what we do is take the HTML page of the readme file, and extract only the section that is the readme itself (discard the github stuff around). Obviously framasoft renders things differently so we need to adapt.

We'll likely get more of those in the future as people start hosting things on other sites too... I'll add some stuff to the addon manager to make it easier to support different sites