Add ons manager - development and bugs topic

[jmaustpc]

Add ons manager - development and bugs topic .....

[openBrain]

Won't that duplicate with https://forum.freecadweb.org/viewtopic. ... 6&p=309776 ?

[jmaustpc]

Hi Yorik, I hope all is well with you on this rather cold Sunday night, although for you it may well neither be cold nor Sunday night!

I noticed that if I click on an item (in either WB or Macro tab) in your new add ons manager and then on another before the description page has finished loading, it crashes FreeCAD. Sometimes you have to quickly click on several items before you get the crash.

This is FreeCAD from the daily PPA.

I think you already might know about this since you and Werner were talking about something that sounds similar here
https://forum.freecadweb.org/viewtopic. ... 20#p314328

So if you do already know about this....sorry for the noise.


Jim


OS: Ubuntu 18.04.2 LTS (KDE/plasma)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Python version: 3.6.8
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/Australia (en_AU)

[sgrogan]

This part is not very user friendly

That say, It's not going well.

Code: Select all

No module named 'git'
GitPython not found. Using standard download instead.
Downloading https://framagit.org/freecad-france/moo ... master.zip
Traceback (most recent call last):
File "/usr/share/freecad-daily/Mod/AddonManager/addonmanager_workers.py", line 588, in run
self.download(self.repos[idx][1],clonedir)
File "/usr/share/freecad-daily/Mod/AddonManager/addonmanager_workers.py", line 687, in download
zfile.write(u.read())
AttributeError: 'NoneType' object has no attribute 'read'

You need to install python3-git https://packages.ubuntu.com/bionic/python3-git
It would be nice if this could fall back to .zip, like standard WB.

BTW: bernd requested this feature for the exact same use case, a tutorial WB. Now I learn that yorik is also doing something similar. Seems like there is some synergy here.

[rockn]

This is working very well with python3-git package !

[sgrogan]

This is working very well with python3-git package !

Do you get the readme.md in the description plane?

Capture.PNG (73.8 KiB) Viewed 900 times

BTW: Thanks for your early work on the addons-macro. That's where it all started!

[rockn]

@sgrogan
I get the same screen as your screenshot.

BTW: Thanks for your early work on the addons-macro. That's where it all started!

Yeah I remember it was in 2016 when I invited Yorik at home in France and we start coding this addon manager during the night.

[alberich]

0.18 Addon Manager

addon-0.18.png (29.8 KiB) Viewed 839 times

I have been having some small trouble with the Addon Manager's progress bar.

When installing an addon the progress bar never indicates completion,

In

Code: Select all

OS: Linux Mint 19.1
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.18.16117 (Git) AppImage
Build type: Release
Branch: (HEAD detached at 0.18.2)
Hash: dbb4cc6415bac848a294f03b80f65e888d531742
Python version: 3.6.7
Qt version: 5.6.2
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)

the rectangle just keeps zipping back and forth no matter how long I wait. Checking the /Mod folder shows that the addon is there but the Manager never acknowledges it.

In

Code: Select all

OS: Linux Mint 19.1 (MATE/mate)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.
Build type: Release
Python version: 3.6.8
Qt version: 5.9.5
Coin version: 4.0.0a
OCC version: 7.3.0
Locale: English/UnitedStates (en_US)

BuildRevisionDate = 2019/07/08 02:00:36

the progess bar is static, always stuck to the left margin. It also never acknowledges completion of the task.

0.19 Addon Manager

addon-0.19.png (49.2 KiB) Viewed 839 times

[Kunda1]

When installing an addon the progress bar never indicates completion,

Related to:
https://github.com/FreeCAD/FreeCAD-addons/issues/120

[yorik]

Yeah I remember it was in 2016 when I invited Yorik at home in France and we start coding this addon manager during the night.

In a cyberpunk bar if I remember well (or was it something else we coded t that bar?)

You need to install python3-git https://packages.ubuntu.com/bionic/python3-git
It would be nice if this could fall back to .zip, like standard WB.

This error happens when the addon manager is already falling back to zip download. But apparently the URL to download a zip from framasoft is different from github. We need to have a better look and adapt the addon manager. In the meantime in git commit 4fc91dcc7 I added a more friendly message.

Do you get the readme.md in the description plane?

The readme file is markdown, but the addon manager can only display HTML. So for github what we do is take the HTML page of the readme file, and extract only the section that is the readme itself (discard the github stuff around). Obviously framasoft renders things differently so we need to adapt.

We'll likely get more of those in the future as people start hosting things on other sites too... I'll add some stuff to the addon manager to make it easier to support different sites