binary compatibility: occt + patch?

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

binary compatibility: occt + patch?

Post by looo »

There is a request to add a patch[1] to occt [2] for a reported issue [3]. Now the question is if applying this patch will result in a binary-compatible build. If not we have to rebuild netgen, smesh, freecad with a new occt (A lot of work) So my question is more general:
Which diff of the source lead to binary incompatible builds and which diff result in a binary compatible build?

[1] http://git.dev.opencascade.org/gitweb/? ... 636c2cf130
[2] https://github.com/conda-forge/occt-feedstock/pull/30
[3] https://tracker.dev.opencascade.org/view.php?id=30760
wmayer
Founder
Posts: 20241
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: binary compatibility: occt + patch?

Post by wmayer »

Now the question is if applying this patch will result in a binary-compatible build.
This won't break binary compatibility.
Which diff of the source lead to binary incompatible builds and which diff result in a binary compatible build?
In general changes to source files (.cpp, .cxx, ..) don't break binary compatibility while changes in header files can break it. This happens when changing the signature of an existing function, removing a function, changing the order of class members or adding new members.

See also
https://stackoverflow.com/questions/371 ... patibility
https://www.acodersjourney.com/20-abi-breaking-changes/
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: binary compatibility: occt + patch?

Post by looo »

Thanks!
User avatar
looo
Veteran
Posts: 3941
Joined: Mon Nov 11, 2013 5:29 pm

Re: binary compatibility: occt + patch?

Post by looo »

I have another question regarding binary compatibility:

boost depends on icu which recently was updated. Is it necessary to rebuild any boost dependent package because of the newer icu version?
User avatar
kkremitzki
Veteran
Posts: 2511
Joined: Thu Mar 03, 2016 9:52 pm
Location: Illinois

Re: binary compatibility: occt + patch?

Post by kkremitzki »

Speaking of this, I'm about to upload OCCT 7.3.0p3 aka 7.3.3 to Debian...
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: binary compatibility: occt + patch?

Post by Kunda1 »

kkremitzki wrote: Sat Jul 20, 2019 7:00 pm Speaking of this, I'm about to upload OCCT 7.3.0p3 aka 7.3.3 to Debian...
Nice!
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Post Reply