Welding Symbol Testing Help

Discussions about the development of the TechDraw workbench
User avatar
wandererfan
Posts: 3137
Joined: Tue Nov 06, 2012 5:42 pm

Welding Symbol Testing Help

Postby wandererfan » Wed Aug 14, 2019 6:29 pm

I could use some help in testing a new TechDraw tool for Welding Symbols. You'll have to be able to compile a version from here:
https://github.com/WandererFan/FreeCAD/tree/Welding.

There is some documentation here: TechDraw_WeldingSymbol
WeldingSymbolPromo.gif
WeldingSymbolPromo.gif (546.87 KiB) Viewed 555 times

Caveats:
* There are only a few symbols (Svg files) available at the moment.
* The work to date is based on American Welding Society standards (+/-)
* A message about "unable to read symbol file" appears sometimes. I can't reproduce it on demand, but it happens.
* Leader lines still have an issue where they aren't drawn at document restore. You may have to fiddle about to get them to show.

wf
User avatar
Kunda1
Posts: 5909
Joined: Thu Jan 05, 2017 9:03 pm

Re: Welding Symbol Testing Help

Postby Kunda1 » Wed Aug 14, 2019 7:03 pm

Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
CKJ
Posts: 1
Joined: Wed Aug 14, 2019 8:52 pm

Re: Welding Symbol Testing Help

Postby CKJ » Wed Aug 14, 2019 9:01 pm

Hello Wanderfan,
I'm very interested in your welding feature.
Do you need some help? What is the process of development of this part to push ist in the official FC v.0.19?

Best regards,
CKJ
jmaustpc
Posts: 9566
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Welding Symbol Testing Help

Postby jmaustpc » Wed Aug 14, 2019 9:38 pm

CKJ wrote:
Wed Aug 14, 2019 9:01 pm
Hello Wanderfan,
I'm very interested in your welding feature.
Do you need some help? What is the process of development of this part to push ist in the official FC v.0.19?

Best regards,
CKJ
He is one of our regular developers, he wrote nearly all of techdraw wb, he can push his work into master anytime he is happy with it. 8-)
chrisb
Posts: 19469
Joined: Tue Mar 17, 2015 9:14 am

Re: Welding Symbol Testing Help

Postby chrisb » Wed Aug 14, 2019 11:25 pm

wandererfan wrote:
Wed Aug 14, 2019 6:29 pm
You'll have to be able to compile a version from here:
I had recently played with a font of welding symbols and wanted to use it with TechDraw balloons, but it was rather difficult to handle. So here comes the integrated solution - thanks!

If this doesn't ruin FreeCAD 0.19 completely I would like to see it in master. After all, 0.19 is a developer version.
User avatar
wandererfan
Posts: 3137
Joined: Tue Nov 06, 2012 5:42 pm

Re: Welding Symbol Testing Help

Postby wandererfan » Wed Aug 14, 2019 11:40 pm

CKJ wrote:
Wed Aug 14, 2019 9:01 pm
Do you need some help? What is the process of development of this part to push ist in the official FC v.0.19?
I can always use help! :)

Right now I'm looking for another set of eyes on the tool's behaviour. The developer's view is always a little narrow when it comes to testing.

There are a bunch of Svg symbol files to be built too.

As for the process, if there are no "show stoppers" in what's been done so far, then it is just a matter of rebasing the code on the latest master branch, running the code through Travis to make sure it runs on all platforms, then merging the changes into master.
Then the daily builds pick up the changes and the new version is available to everybody.
Jee-Bee
Posts: 1966
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: Welding Symbol Testing Help

Postby Jee-Bee » Thu Aug 15, 2019 5:08 am

I have to say i don't have used your branch...
But what i see from your screengrap i see one thing.
Why not reversing the method? So first "add welding symbol" from the toolbar. Then you get the menu where to put in all the properties. and when finished select two points (geometry and placing of symbol) all the leader stuff follows out the size of the symbol...